Alert on Wins not landed

[snadrus]

Checklist

• This is not a new feature or an enhancement to the Filecoin protocol. If it is, please open an FIP issue.
• This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the Curio forum and select the category as Ideas.
• I have a specific, actionable, and well motivated feature request to propose.

Curio component

• PoRep Pipeline
• Snap Deals
• Market
• IPNI provider
• Curio UI
• Other

What is the motivation behind this feature request? Is your feature request related to a problem? Please describe.

Filfox wins (for some customers) show less that Curio UI displayed wins.
Deep-diving, it's the difference between wins offered & wins landed. That difference is money lost by the SP, so this should be a warning.

Describe the solution you'd like

A curio UI and/or alert to indicate that wins are not landing. This data is available on the existing table as included which can be null if it hasn't been polled yet.

Describe alternatives you've considered

This took Mongo's sharp eye to notice, so not all SPs will be so lucky. It's a high-level health check that could indicate anything from a Curio or Lotus bug to SP configuration or load.

Additional context

No response

[amughal]

Hi @snadrus I would also appreciate if Sector column can be added in the Recent Wins. This will allow quick check for an SP to look at the slow storage appliance.

[LexLuthr]

We already have this alerting. We check wins at

curio/tasks/winning/inclusion_check_task.go

Line 65 in a5972b0

tsAt, err := i.api.ChainGetTipSetByHeight(ctx, abi.ChainEpoch(check.Epoch), types.EmptyTSK)

and generate an alert at

curio/alertmanager/alerts.go

Line 615 in a5972b0

if !wn.Included {

.
We should check why Filfox shows less win. I don't think we can have a more robust check than actually checking the tipset itself. We also do a similar check before displaying the UI at

curio/web/api/webrpc/win_stats.go

Lines 43 to 49 in a5972b0

	if marks[i].Included == nil {
	marks[i].IncludedStr = "Not Checked"
	} else if *marks[i].Included {
	marks[i].IncludedStr = "Included"
	} else {
	marks[i].IncludedStr = "Not Included"
	}

.

@amughal Can you please provide details of one such instance with all the data?