fix(server): bind PORT and HOST env vars (#555)

* fix(server): bind PORT and HOST env vars

Declares --port and --host via Option.env() so the env vars
resolve with Commander precedence (cli > env > default) instead
of being overwritten by the flag defaults before createConfig()
reads them. Aligns the config loader and README on the 3000 and
127.0.0.1 defaults the CLI already uses.

* fix(config): harden PORT and HOST env parsing

Treats empty PORT/HOST (docker-compose interpolation of unset
variables) as unset and rejects non-numeric or out-of-range
ports with a clear startup error instead of passing NaN to the
listener. An empty HOST previously reached fastify as '' and
bound all interfaces.

---------

Co-authored-by: Julian Gruber <julian@juliangruber.com>

Author: SgtPooki

README.md

@@ -254,8 +254,8 @@ RPC_URL=wss://...              # Filecoin RPC endpoint (overrides NETWORK if spe
 # Optional for Pinning Server Daemon
 ACCESS_TOKEN=...               # Bearer token required on all API requests except GET /
 ALLOW_NO_AUTH=true             # Start without a token, serving all requests unauthenticated (not recommended)
-PORT=3456                      # Daemon server port
-HOST=localhost                 # Daemon server host
+PORT=3000                      # Daemon server port
+HOST=127.0.0.1                 # Daemon server host
 DATABASE_PATH=./pins.db        # SQLite database location
 CAR_STORAGE_PATH=./cars        # CAR file storage directory
 LOG_LEVEL=info                 # Logging verbosity (info, debug, error)

src/commands/server.ts

@@ -4,8 +4,8 @@ import { addNetworkOptions, addSigningAuthOptions, rpcUrlOption } from '../utils
 
 export const serverCommand = new Command('server')
   .description('Start the IPFS Pinning Service API server')
-  .option('-p, --port <number>', 'server port', '3000')
-  .option('--host <string>', 'server host', '127.0.0.1')
+  .addOption(new Option('-p, --port <number>', 'server port').env('PORT').default('3000'))
+  .addOption(new Option('--host <string>', 'server host').env('HOST').default('127.0.0.1'))
   .option('--car-storage <path>', 'path for CAR file storage', './cars')
   .option('--database <path>', 'path to SQLite database', './pins.db')
   .addOption(

src/config.ts

@@ -68,10 +68,18 @@ export function createConfig(): Config {
   // the endpoint to derive the chain. Default to mainnet when neither is supplied.
   const chain = hasRpcUrl ? resolveChain(undefined, true) : resolveChain(process.env.NETWORK ?? 'mainnet', false)
 
+  // Treat an empty PORT/HOST (e.g. docker-compose interpolation of an unset
+  // variable) the same as unset, and reject non-numeric or out-of-range ports
+  // with a clear error instead of letting NaN reach the listener.
+  const port = parseInt(process.env.PORT || '3000', 10)
+  if (Number.isNaN(port) || port < 0 || port > 65535) {
+    throw new Error(`Configuration error: PORT must be a number between 0 and 65535, got '${process.env.PORT}'`)
+  }
+
   const config: Config = {
     // Application-specific configuration
-    port: parseInt(process.env.PORT ?? '3456', 10),
-    host: process.env.HOST ?? 'localhost',
+    port,
+    host: process.env.HOST || '127.0.0.1',
     accessToken: process.env.ACCESS_TOKEN,
     allowNoAuth: process.env.ALLOW_NO_AUTH === 'true',
 

src/test/unit/cli-options.test.ts

@@ -192,3 +192,16 @@ describe('validateAndNormalizeAutoFundOptions', () => {
     )
   })
 })
+
+describe('server command PORT/HOST env bindings', () => {
+  function optionFor(long: string) {
+    return serverCommand.options.find((o) => o.long === long)
+  }
+
+  it('binds --port and --host to their env vars with the CLI defaults', () => {
+    expect(optionFor('--port')?.envVar).toBe('PORT')
+    expect(optionFor('--port')?.defaultValue).toBe('3000')
+    expect(optionFor('--host')?.envVar).toBe('HOST')
+    expect(optionFor('--host')?.defaultValue).toBe('127.0.0.1')
+  })
+})

src/test/unit/config.test.ts

@@ -58,8 +58,8 @@ describe('Config', () => {
 
     const expectedRpcUrl = mainnet.rpcUrls.default.webSocket?.[0] ?? mainnet.rpcUrls.default.http[0]
 
-    expect(config.port).toBe(3456)
-    expect(config.host).toBe('localhost')
+    expect(config.port).toBe(3000)
+    expect(config.host).toBe('127.0.0.1')
     expect(config.rpcUrl).toBe(expectedRpcUrl)
     expect(config.databasePath).toBe(join(expectedDataDir, 'pins.db'))
     expect(config.carStoragePath).toBe(join(expectedDataDir, 'cars'))
@@ -78,6 +78,24 @@ describe('Config', () => {
     expect(config.logLevel).toBe('debug')
   })
 
+  it('treats empty PORT and HOST as unset', () => {
+    process.env.PORT = ''
+    process.env.HOST = ''
+
+    const config = createConfig()
+
+    expect(config.port).toBe(3000)
+    expect(config.host).toBe('127.0.0.1')
+  })
+
+  it('throws on a non-numeric or out-of-range PORT', () => {
+    process.env.PORT = 'abc'
+    expect(() => createConfig()).toThrow(/PORT must be a number/)
+
+    process.env.PORT = '70000'
+    expect(() => createConfig()).toThrow(/PORT must be a number/)
+  })
+
   it('resolves chain from NETWORK so Synapse uses matching contracts', () => {
     process.env.NETWORK = 'mainnet'
     expect(createConfig().chain).toBe(mainnet)