You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There likely aren't any changes at this point, but this can be opened with a small whitespace change so the PR is open and we can more easily hold the standard of making improvements incrementally since improvements are usually better done by collecting changes/notes along the way rather than just thinking about it at the end.
This will get merged in a Post Release step.
Fork a new release/v1.34.4 branch from the master branch and make any further release-related changes to this branch.
Note: For critical security patches, fork a new branch from the last stable release/vX.Y.x to expedite the release process.
Fork a new release/miner/v1.34.4 branch from the master branch and make any further release-related changes to this branch.
Note: For critical security patches, fork a new branch from the last stable release/vX.Y.x to expedite the release process.
ποΈ RCs
rc1
Section
[!IMPORTANT]
These PRs should be done in and target the release/v1.34.4 or release/miner/v1.34.4 branch.
Backport PR for rc1
All explicitly tracked items from Dependencies for releases have landed
Release PR for rc1
Update the version string(s) in build/version.go to one ending with '-rc1'.
Ensure to update NodeBuildVersion
Ensure to update MinerBuildVersion
Run make gen && make docsgen-cli to generate documentation
Create a draft PR with title build: release Lotus Node and Miner v1.34.4-rc1
Example gh cli command looking at merged PRs into master and sorted by title to group similar areas (where YYYY-MM-DD is the start search date): gh pr list --repo filecoin-project/lotus --search "base:master merged:>YYYY-MM-DD" --json number,mergedAt,author,title | jq -r '.[] | [.number, .mergedAt, .author.login, .title] | @tsv' | sort -k4
Update the PR with the commit(s) made to the CHANGELOG
Mark the PR "ready for review" (non-draft)
Merge the PR
Merging the PR will trigger a CI run that will build assets, attach the assets to the GitHub release, publish the GitHub release, and create the corresponding git tag.
Example gh cli command looking at merged PRs into master and sorted by title to group similar areas (where YYYY-MM-DD is the start search date): gh pr list --repo filecoin-project/lotus --search "base:master merged:>YYYY-MM-DD" --json number,mergedAt,author,title | jq -r '.[] | [.number, .mergedAt, .author.login, .title] | @tsv' | sort -k4
Update the PR with the commit(s) made to the CHANGELOG
Mark the PR "ready for review" (non-draft)
Merge the PR
Merging the PR will trigger a CI run that will build assets, attach the assets to the GitHub release, publish the GitHub release, and create the corresponding git tag.
Link to any special steps for testing releases beyond ensuring CI is green. Steps can be inlined here or tracked elsewhere.
β‘ Post-Release
Section
Open a PR against master cherry-picking the CHANGELOG commits from the release/v1.34.4 branch. Title it chore(release): cherry-pick v1.34.4 changelog back to master
πΆβπ« Meta
π’ Estimated shipping date
πͺ’ Dependencies for releases
Note
master.Release Checklist.rc1
Stable Release (non-RC)
eth_syncingresult property casing & implementUnmarshalJSONforEthSyncingResultΒ #13484β Release Checklist
β¬ οΈ Before RC1
Section
docs(release): v1.34.4 release template improvementsfor improving future releases.Post Releasestep.release/v1.34.4branch from themasterbranch and make any further release-related changes to this branch.release/vX.Y.xto expedite the release process.release/miner/v1.34.4branch from themasterbranch and make any further release-related changes to this branch.release/vX.Y.xto expedite the release process.ποΈ RCs
rc1
Section
Backport PR for rc1
Dependencies for releaseshave landedRelease PR for rc1
build/version.goto one ending with '-rc1'.NodeBuildVersionMinerBuildVersionmake gen && make docsgen-clito generate documentationbuild: release Lotus Node and Miner v1.34.4-rc1git log --oneline --graph vA.B.C.., where A.B.C correspond to the previous release.ghcli command looking at merged PRs into master and sorted by title to group similar areas (whereYYYY-MM-DDis the start search date):gh pr list --repo filecoin-project/lotus --search "base:master merged:>YYYY-MM-DD" --json number,mergedAt,author,title | jq -r '.[] | [.number, .mergedAt, .author.login, .title] | @tsv' | sort -k4π’ Estimated shipping datetableTesting for rc1
Release PR for Stable Release (non-RC)
build/version.goto one NOT ending with 'rcX'.NodeBuildVersionMinerBuildVersionmake gen && make docsgen-clito generate documentationbuild: release Lotus Node and Miner v1.34.4git log --oneline --graph vA.B.C.., where A.B.C correspond to the previous release.ghcli command looking at merged PRs into master and sorted by title to group similar areas (whereYYYY-MM-DDis the start search date):gh pr list --repo filecoin-project/lotus --search "base:master merged:>YYYY-MM-DD" --json number,mergedAt,author,title | jq -r '.[] | [.number, .mergedAt, .author.login, .title] | @tsv' | sort -k4π’ Estimated shipping datetableTesting for Stable Release (non-RC)
Note
Link to any special steps for testing releases beyond ensuring CI is green. Steps can be inlined here or tracked elsewhere.
β‘ Post-Release
Section
mastercherry-picking the CHANGELOG commits from therelease/v1.34.4branch. Title itchore(release): cherry-pick v1.34.4 changelog back to mastermasterfirst before backporting to the release branch, the only changes should be CHANGELOG updates.Before RC1with any improvements determined from this latest release iteration.β€οΈ Contributors
See the final release notes!
Leave a comment in this ticket!