Update cid and multi hash

[jennijuju]

#1211 reverted the pkg update, we should introduce them back.

however, given the original committer, forest team has confirmed this update is not too urgent - we will do this in a later release, i.e: post nv18 release

[lemmih]

@jennijuju @Stebalien @shawnrader This is becoming an increasingly urgent issue for Forest as we cannot work on NV18 before this can been resolved. Are there any blockers for completing this task by next week? If there are any blockers, let's schedule a meeting to discuss a way forward.

[vmx]

It's in the works: filecoin-project/filecoin-ffi#355

[lemmih]

It's in the works: filecoin-project/filecoin-ffi#355

That won't work for Forest. We need FVM2 to be updated.

[lemmih]

however, given the original committer, forest team has confirmed this update is not too urgent - we will do this in a later release, i.e: post nv18 release

Oops, I think there's been a miscommunication here. When we talked in early December, I meant it wasn't so urgent that it had to be done before the Christmas break. It definitely has to happen before the nv18 release.

[lemmih]

To add some context for those who weren't part of the discussion(s) in December:

• The CID and multihash dependencies have to be updated in FVM2.
• It is a show-stopper for Forest if this doesn't happen.
• Updating FVM2 is trivial (Forest already submitted a patch for doing this) but, due to an unfortunately versioning scheme, it will break a lot of downstream projects (including filecoin-ffi).
• It was agreed that FVM2 would get a new semver-violating minor release with updated CID/multihash dependencies.

[shawnrader]

Filecoin-ffi as it is now should not have any issues with updating cid and multihash crates as long as FVM3 and FVM2 are using the same version of those crates.

[lemmih]

Filecoin-ffi as it is now should not have any issues with updating cid and multihash crates as long as FVM3 and FVM2 are using the same version of those crates.

Excellent! This means we're ready to bump the CID/multihash dependencies in FVM2?

[jennijuju]

Filecoin-ffi as it is now should not have any issues with updating cid and multihash crates as long as FVM3 and FVM2 are using the same version of those crates.

Excellent! This means we're ready to bump the CID/multihash dependencies in FVM2?

This is being worked on here filecoin-project/filecoin-ffi#355 - but IIUC the dependency mentioned here is out of scope for nv18 and forest was okay with that? Source https://filecoinproject.slack.com/archives/C029MT4PQB1/p1670481960248989?thread_ts=1670435116.931999&channel=C029MT4PQB1&message_ts=1670481960.248989
& according to this What changed since the for this to be a blocker for forest on nv18?

[lemmih]

@jennijuju I think we must have had a different interpretation of "nv18 code freeze". I thought that meant "nv18 feature freeze" (ie January) rather than "nv18 release" (ie March or later). When I discussed the matter with Shawn Rader, I told him we didn't need to resolve it in December and that resolving it in January would be fine.

On a side note, I don't understand the need for filecoin-project/filecoin-ffi#355. In the future, FVM2 and FVM3 will always use the same versions of cid and multihash.

[lemmih]

Miscommunications aside, what matters is that this is a blocker for Forest. We both agree that this work needs to be done quite soon (I would like it done this month, you thought it was gonna be done in March). Let's bite the bullet and just do the work now rather than later. The Forest team is more than willing to provide engineers to handle the Rust side of things. You'll then have to update the Lotus-related projects that are downstream of the FVM.

Let's have a call early next week to make sure we're on the same page.

[jennijuju]

Update: the current cid/multihash version is aligned between fvm v2.2.0 and fvm v3 and that unblocks forest for nv18.
more details see here

Forest needs cid 0.9 for a QoL improvement, thus would be nice to get this done post nv18 soon.

[lemmih]

Can Forest assist with this upgrade? It's becoming a pressing issue for us. Because of this, we cannot upgrade several other dependencies (e.g., libipld-core`). If upgrading FVM2 and FVM3 isn't possible in the next quarter or two, Forest will have to fork the FVM.