Skip to content

Commit 8d1c225

Browse files
committed
docs(sra): sync stale test counts and MIN_LOT constant in design docs
1 parent dee2ab5 commit 8d1c225

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

docs/decisions/001-sra-decision-record.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
> Scope: all key decisions for Issue #4 Service Rewards Actor (FIP-0118), from design to PR.
44
> Decision groups: **D** design decisions (settled) | **S** structural decisions (approval) | **C** conflict rulings (found test-first) | **T** test decisions (defect fixes) | **G** coverage-gap closures | **I/R** implementation-layer risks and mitigations.
5-
> Status: all landed (design approved and converged; implementation 219/219 tests Green; SRA line coverage 100%).
5+
> Status: all landed (design approved and converged; implementation 237/237 tests Green; SRA line coverage 100%).
66
77
## Related Documents
88

docs/design/002-sra-tests.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ PRICE_BAND cross-multiplication determination all consistent with the independen
208208
| `VERIFICATION_WINDOW` | 400 ||
209209
| `SRA_CANCEL_HOLD` | 100 ||
210210
| `ACTIVATION_EPOCH` | 100_000 | far past the block after "registering stream 2 requires advancing SWA_TIMELOCK(20160)", quarter-0 window is clean |
211-
| `MIN_LOT` | 1e18 | test threshold (design §11 proposes a few hundred USD) |
211+
| `MIN_LOT` | 100 | 100 USD (lot face value; design §11 proposes "a few hundred USD"; a small test value keeps all existing prints qualifying) |
212212
| `PRICE_BAND` | 2000 | **basis points** (2000 = allows ±20% deviation), test assumption H-band |
213213
| `MAX_PRICE_PERIODS` | 32 | design §11 proposed value |
214214

@@ -243,7 +243,7 @@ PRICE_BAND cross-multiplication determination all consistent with the independen
243243

244244
```bash
245245
# current environment (forge upgraded to 1.7.1; project foundry.toml usable directly; P0 fixed fmt/lint)
246-
forge test --match-contract SRA # SRA tests (74 deterministic + 3 invariant)
246+
forge test --match-contract SRA # SRA tests (104 deterministic + 5 invariant)
247247
forge test --match-contract SRAInvariant # invariant only (~3 minutes)
248248
forge test # full suite
249249
```

docs/spec/001-sra-security-review.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ All residual risks are **theoretical boundaries** or **protocol-layer premises**
218218
### Coverage and statistics notes
219219

220220
- SRA line coverage **100%**, statements 99.45%, functions 100%; branch 67.16% (`forge coverage`) is the **tool's statistical ceiling** — require branches of governance function bodies with the `unanimous`/`unanimousNoHold` modifier are all recorded as 0 in lcov (including remove NotAdmitted / reassignBinding NotAdmitted / replace AlreadyAdmitted / setPricingParams InvalidParameter, which G6 explicitly tests); an lcov quirk for modifier-inlined function bodies, **not a real gap** (detailed in tests doc §2.3).
221-
- Full suite **224/224 Green** (91 SRA deterministic + 5 invariant + 128 existing); 5 invariants (share conservation / binding uniqueness / governance consistency / A2 freeze snapshot / A3 all-zero burn); `.gas-snapshot` gas baseline committed (E1).
221+
- Full suite **237/237 Green** (104 SRA deterministic + 5 invariant + 128 existing); 5 invariants (share conservation / binding uniqueness / governance consistency / A2 freeze snapshot / A3 all-zero burn); `.gas-snapshot` gas baseline committed (E1).
222222

223223
---
224224

@@ -237,7 +237,7 @@ All residual risks are **theoretical boundaries** or **protocol-layer premises**
237237
## References
238238

239239
- 📄 `docs/design/001-sra-design.md` (design: D1-D5/S1-S12, §2.5 core logic, §4 approval list)
240-
- 📄 `docs/design/002-sra-tests.md` (tests: C1-C8/T1-T6/G1-G7, §2.2-2.5 assurance registries, 224/224 Green)
240+
- 📄 `docs/design/002-sra-tests.md` (tests: C1-C8/T1-T6/G1-G7, §2.2-2.5 assurance registries, 237/237 Green)
241241
- 📄 `docs/decisions/001-sra-decision-record.md` (decisions: T6/T10 defect dispositions, S5/S7, I/R risk mitigations)
242242
- 📘 `src/ServiceRewardsActor.sol` (review target, 721 lines)
243243
- 📘 `src/lib/UnanimousGovernance.sol` / `Owners.sol` / `Epoch.sol` / `IsASafe.sol` / `FVMRewards.sol` (dependency libraries)

0 commit comments

Comments
 (0)