Skip to content

Feature: Always show file extensions when renaming items - #18607

Merged
yair100 merged 2 commits into
mainfrom
ya/FileExts
Jun 18, 2026
Merged

Feature: Always show file extensions when renaming items#18607
yair100 merged 2 commits into
mainfrom
ya/FileExts

Conversation

@yair100

@yair100 yair100 commented Jun 17, 2026

Copy link
Copy Markdown
Member

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Confirmed file extensions are displayed when renaming files even when file extensions are turned off
  2. Tested in each layout

@yair100
yair100 requested a review from Josh65-2201 June 17, 2026 23:07
@yair100 yair100 added the ready for review Pull requests that are ready for review label Jun 17, 2026
Josh65-2201
Josh65-2201 previously approved these changes Jun 17, 2026

@Josh65-2201 Josh65-2201 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized what I test is how 4.1.3 already works. Where is the settings for always showing it?

@yair100

yair100 commented Jun 17, 2026

Copy link
Copy Markdown
Member Author

@Josh65-2201 this PR changes the behavior so that file extensions are always displayed when renaming items.

@Josh65-2201

Josh65-2201 commented Jun 17, 2026

Copy link
Copy Markdown
Member

From commit a59b888 it's not showing in any layouts rename with Files settings > Files & folders > Show extensions for known file types off, does with it on

@Josh65-2201

Copy link
Copy Markdown
Member

Still the same as above on commit 0f8c1636

@yair100

yair100 commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

@Josh65-2201 can you send a screen recording?

@Josh65-2201

Copy link
Copy Markdown
Member

I found it an issue with archive types .7z, jar and zip. On a jpg it working as expected

@yair100

yair100 commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

Can you please test with the latest commit?

@Josh65-2201 Josh65-2201 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now

@yair100

yair100 commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

Thanks for checking.

@yair100 yair100 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jun 18, 2026
@yair100
yair100 merged commit 3217ee2 into main Jun 18, 2026
8 checks passed
@yair100
yair100 deleted the ya/FileExts branch June 18, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add option to display file extensions only when renaming files

2 participants