Skip to content

Commit 3c5d6bd

Browse files
committed
Minor editorial touchup
1 parent 38dd345 commit 3c5d6bd

File tree

3 files changed

+9
-11
lines changed

3 files changed

+9
-11
lines changed

include/cpp2util.h

+5-7
Original file line numberDiff line numberDiff line change
@@ -747,9 +747,9 @@ auto pointer_eq(T const* a, T const* b) {
747747
//
748748
// A type_find_if for iterating over types in parameter packs
749749
//
750-
// Note: the current implementation is a workaround for clang-12 internal error.
751-
// Original implementation does not need type_it and is implemented
752-
// using lambda with explicit parameter type list in the following way:
750+
// Note: This implementation works around limitations in gcc <12.1,
751+
// Clang <13, and MSVC <19.29. Otherwise we could avoid type_it and use
752+
// a lambda with an explicit parameter type list like this:
753753
//
754754
// template <typename... Ts, typename F>
755755
// constexpr auto type_find_if(F&& fun)
@@ -763,10 +763,8 @@ auto pointer_eq(T const* a, T const* b) {
763763
// return found;
764764
// }
765765
//
766-
// The workaround is not needed in gcc-12.1+, clang-13+, msvc 19.29+
767-
//
768-
// Note2: the internal if constexpr could have else with static_assert.
769-
// Unfortunatelly I cannot make it work on MSVC.
766+
// Note: The internal if constexpr could have else with static_assert.
767+
// Unfortunately there doesn't seem to be a way to make it work on MSVC.
770768
//
771769
//-----------------------------------------------------------------------
772770
//

regression-tests/mixed-is-as-variant.cpp2

+2-2
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ auto expect_no_throw(auto&& l) -> std::string try {
7474
} catch (std::exception const& e) {
7575
return e.what();
7676
} catch (...) {
77-
return "unknow exception!";
77+
return "unknown exception!";
7878
}
7979

8080
auto expect_no_throw(auto&& v, auto&& l) -> std::string try {
@@ -87,5 +87,5 @@ auto expect_no_throw(auto&& v, auto&& l) -> std::string try {
8787
} catch (std::exception const& e) {
8888
return e.what();
8989
} catch (...) {
90-
return "unknow exception!";
90+
return "unknown exception!";
9191
}

regression-tests/test-results/mixed-is-as-variant.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ auto expect_no_throw(auto&& l) -> std::string try {
4646
} catch (std::exception const& e) {
4747
return e.what();
4848
} catch (...) {
49-
return "unknow exception!";
49+
return "unknown exception!";
5050
}
5151

5252
auto expect_no_throw(auto&& v, auto&& l) -> std::string try {
@@ -59,7 +59,7 @@ auto expect_no_throw(auto&& v, auto&& l) -> std::string try {
5959
} catch (std::exception const& e) {
6060
return e.what();
6161
} catch (...) {
62-
return "unknow exception!";
62+
return "unknown exception!";
6363
}
6464

6565

0 commit comments

Comments
 (0)