Merge pull request #193 from bingenito/improved-coverage

Increase test overage of core Fdc3 and AppDirectory packages

Author: bingenito

src/Tests/Finos.Fdc3.AppDirectory.Tests/AppChannelTests.cs

@@ -0,0 +1,43 @@
+/*
+ * Morgan Stanley makes this available to you under the Apache License, 
+ * Version 2.0 (the "License"). You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * See the NOTICE file distributed with this work for additional information
+ * regarding copyright ownership. Unless required by applicable law or agreed
+ * to in writing, software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions
+ * and limitations under the License.
+ */
+
+using System;
+using Xunit;
+
+namespace Finos.Fdc3.AppDirectory.Tests;
+
+public class AppChannelTests
+{
+    [Fact]
+    public void AppChannel_Constructor_SetsProperties()
+    {
+        // Arrange
+        var id = "testChannel";
+
+        // Act
+        var channel = new AppChannel(id);
+
+        // Assert
+        Assert.Equal(id, channel.ID);
+        Assert.Null(channel.Description);
+        Assert.Null(channel.Broadcasts);
+    }
+
+    [Fact]
+    public void AppChannel_Constructor_WithNullId_ThrowsArgumentNullException()
+    {
+        // Act & Assert
+        Assert.Throws<ArgumentNullException>(() => new AppChannel(null!));
+    }
+}

src/Tests/Finos.Fdc3.AppDirectory.Tests/AppDetailsTests.cs

@@ -0,0 +1,98 @@
+/*
+ * Morgan Stanley makes this available to you under the Apache License,
+ * Version 2.0 (the "License"). You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * See the NOTICE file distributed with this work for additional information
+ * regarding copyright ownership. Unless required by applicable law or agreed
+ * to in writing, software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions
+ * and limitations under the License.
+ */
+
+using System;
+using Xunit;
+
+namespace Finos.Fdc3.AppDirectory.Tests;
+
+public class AppDetailsTests
+{
+    [Fact]
+    public void WebAppDetails_Constructor_SetsProperties()
+    {
+        // Arrange
+        var url = "https://example.com";
+
+        // Act
+        var details = new WebAppDetails(url);
+
+        // Assert
+        Assert.Equal(url, details.Url);
+    }
+
+    [Fact]
+    public void NativeAppDetails_Constructor_SetsProperties()
+    {
+        // Arrange
+        var path = @"C:\Program Files\App\app.exe";
+        var arguments = "--start";
+
+        // Act
+        var details = new NativeAppDetails(path, arguments);
+
+        // Assert
+        Assert.Equal(path, details.Path);
+        Assert.Equal(arguments, details.Arguments);
+    }
+
+    [Fact]
+    public void OnlineNativeAppDetails_Constructor_SetsProperties()
+    {
+        // Arrange
+        var url = "https://example.com";
+
+        // Act
+        var details = new OnlineNativeAppDetails(url);
+
+        // Assert
+        Assert.Equal(url, details.Url);
+    }
+
+    [Fact]
+    public void CitrixAppDetails_Constructor_SetsProperties()
+    {
+        // Arrange
+        var alias = "citrix-app-alias";
+        var arguments = "--start";
+
+        // Act
+        var details = new CitrixAppDetails(alias, arguments);
+
+        // Assert
+        Assert.Equal(alias, details.Alias);
+        Assert.Equal(arguments, details.Arguments);
+    }
+
+    [Fact]
+    public void WebAppDetails_Constructor_WithNullUrl_ThrowsArgumentNullException()
+    {
+        // Act & Assert
+        Assert.Throws<ArgumentNullException>(() => new WebAppDetails(null!));
+    }
+
+    [Fact]
+    public void NativeAppDetails_Constructor_WithNullPath_ThrowsArgumentNullException()
+    {
+        // Act & Assert
+        Assert.Throws<ArgumentNullException>(() => new NativeAppDetails(null!, null));
+    }
+
+    [Fact]
+    public void CitrixAppDetails_Constructor_WithNullAlias_ThrowsArgumentNullException()
+    {
+        // Act & Assert
+        Assert.Throws<ArgumentNullException>(() => new CitrixAppDetails(null!, null));
+    }
+}

src/Tests/Finos.Fdc3.AppDirectory.Tests/Fdc3AppTests.cs

@@ -0,0 +1,110 @@
+/*
+ * Morgan Stanley makes this available to you under the Apache License,
+ * Version 2.0 (the "License"). You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * See the NOTICE file distributed with this work for additional information
+ * regarding copyright ownership. Unless required by applicable law or agreed
+ * to in writing, software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions
+ * and limitations under the License.
+ */
+
+using System;
+using Xunit;
+
+namespace Finos.Fdc3.AppDirectory.Tests;
+
+public class Fdc3AppTests
+{
+    [Fact]
+    public void Fdc3App_Constructor_SetsProperties()
+    {
+        // Arrange
+        var appId = "test-app";
+        var name = "Test App";
+        var type = AppType.Web;
+        var details = new WebAppDetails("https://example.com");
+
+        // Act
+#pragma warning disable CS0618 // Type or member is obsolete
+        var app = new Fdc3App(appId, name, type, details);
+
+        // Assert
+        Assert.Equal(appId, app.AppId);
+        Assert.Equal(name, app.Name);
+#pragma warning restore CS0618 // Type or member is obsolete
+        Assert.Equal(type, app.Type);
+        Assert.Equal(details, app.Details);
+    }
+
+    [Fact]
+    public void Fdc3App_Constructor_WithNullAppId_ThrowsArgumentNullException()
+    {
+        // Act & Assert
+        Assert.Throws<ArgumentNullException>(() => new Fdc3App(
+            null!,
+            "Test App",
+            AppType.Web,
+            new WebAppDetails("https://example.com")));
+    }
+
+    [Fact]
+    public void Fdc3App_Constructor_WithNullName_ThrowsArgumentNullException()
+    {
+        // Act & Assert
+        Assert.Throws<ArgumentNullException>(() => new Fdc3App(
+            "test-app",
+            null!,
+            AppType.Web,
+            new WebAppDetails("https://example.com")));
+    }
+
+    [Fact]
+    public void Fdc3App_Constructor_WithNullDetails_ThrowsArgumentNullException()
+    {
+        // Act & Assert
+        Assert.Throws<ArgumentNullException>(() => new Fdc3App(
+            "test-app",
+            "Test App",
+            AppType.Web,
+            null!));
+    }
+
+    [Fact]
+    public void Fdc3App_GenericConstructor_SetsProperties()
+    {
+        // Arrange
+        var appId = "test-app";
+        var name = "Test App";
+        var type = AppType.Web;
+        var details = new WebAppDetails("https://example.com");
+
+        // Act
+#pragma warning disable CS0618 // Type or member is obsolete
+        var app = new Fdc3App<WebAppDetails>(appId, name, type, details);
+
+        // Assert
+        Assert.Equal(appId, app.AppId);
+        Assert.Equal(name, app.Name);
+#pragma warning restore CS0618 // Type or member is obsolete
+        Assert.Equal(type, app.Type);
+        Assert.Equal(details, app.Details);
+    }
+
+    [Fact]
+    public void Fdc3App_GenericConstructor_WithWrongDetailsType_ThrowsInvalidCastException()
+    {
+        // Arrange
+        var appId = "test-app";
+        var name = "Test App";
+        var type = AppType.Web;
+        var details = new NativeAppDetails(@"C:\app.exe", null);
+
+        // Act & Assert
+        var baseApp = new Fdc3App(appId, name, type, details);
+        Assert.Throws<InvalidCastException>(() => _ = (WebAppDetails)baseApp.Details);
+    }
+}

src/Tests/Finos.Fdc3.AppDirectory.Tests/IntentMetadataTests.cs

@@ -0,0 +1,59 @@
+/*
+ * Morgan Stanley makes this available to you under the Apache License,
+ * Version 2.0 (the "License"). You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * See the NOTICE file distributed with this work for additional information
+ * regarding copyright ownership. Unless required by applicable law or agreed
+ * to in writing, software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions
+ * and limitations under the License.
+ */
+
+using System;
+using System.Collections.Generic;
+using Xunit;
+
+namespace Finos.Fdc3.AppDirectory.Tests;
+
+public class IntentMetadataTests
+{
+    [Fact]
+    public void IntentMetadata_Constructor_SetsProperties()
+    {
+        // Arrange
+        var name = "ViewChart";
+        var displayName = "View Chart";
+        var contexts = new[] { "fdc3.instrument", "fdc3.position" };
+
+        // Act
+#pragma warning disable CS0618 // Type or member is obsolete
+        var metadata = new IntentMetadata(name, displayName, contexts);
+
+        // Assert
+        Assert.Equal(name, metadata.Name);
+        Assert.Equal(displayName, metadata.DisplayName);
+#pragma warning restore CS0618 // Type or member is obsolete
+        Assert.Equal(contexts, metadata.Contexts);
+    }
+
+    [Fact]
+    public void IntentMetadata_Constructor_WithNullContexts_ThrowsArgumentNullException()
+    {
+        // Act & Assert
+        Assert.Throws<ArgumentNullException>(() => new IntentMetadata("ViewChart", "View Chart", null!));
+    }
+
+    [Fact]
+    public void IntentMetadata_Constructor_WithEmptyContexts_Succeeds()
+    {
+        // Arrange & Act
+        var metadata = new IntentMetadata("ViewChart", "View Chart", Array.Empty<string>());
+
+        // Assert
+        Assert.NotNull(metadata.Contexts);
+        Assert.Empty(metadata.Contexts);
+    }
+}

src/Tests/Finos.Fdc3.AppDirectory.Tests/IntentsTests.cs

@@ -0,0 +1,74 @@
+/*
+ * Morgan Stanley makes this available to you under the Apache License,
+ * Version 2.0 (the "License"). You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * See the NOTICE file distributed with this work for additional information
+ * regarding copyright ownership. Unless required by applicable law or agreed
+ * to in writing, software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions
+ * and limitations under the License.
+ */
+
+using System.Collections.Generic;
+using Xunit;
+
+namespace Finos.Fdc3.AppDirectory.Tests;
+
+public class IntentsTests
+{
+    [Fact]
+    public void Intents_Properties_CanBeSetAndGet()
+    {
+        // Arrange
+        var intents = new Intents();
+        var listensFor = new Dictionary<string, IntentMetadata>
+        {
+            { "ViewChart", new IntentMetadata("ViewChart", "View Chart", new[] { "fdc3.instrument" }) },
+            { "ViewContact", new IntentMetadata("ViewContact", "View Contact", new[] { "fdc3.contact" }) }
+        };
+        var raises = new Dictionary<string, IEnumerable<string>>
+        {
+            { "StartChat", new[] { "fdc3.contact", "fdc3.organization" } },
+            { "ViewNews", new[] { "fdc3.instrument", "fdc3.organization" } }
+        };
+
+        // Act
+        intents.ListensFor = listensFor;
+        intents.Raises = raises;
+
+        // Assert
+        Assert.Equal(listensFor, intents.ListensFor);
+        Assert.Equal(raises, intents.Raises);
+    }
+
+    [Fact]
+    public void Intents_Properties_CanBeNull()
+    {
+        // Arrange & Act
+        var intents = new Intents();
+
+        // Assert
+        Assert.Null(intents.ListensFor);
+        Assert.Null(intents.Raises);
+    }
+
+    [Fact]
+    public void Intents_Properties_CanBeEmpty()
+    {
+        // Arrange
+        var intents = new Intents();
+        var emptyListensFor = new Dictionary<string, IntentMetadata>();
+        var emptyRaises = new Dictionary<string, IEnumerable<string>>();
+
+        // Act
+        intents.ListensFor = emptyListensFor;
+        intents.Raises = emptyRaises;
+
+        // Assert
+        Assert.Empty(intents.ListensFor);
+        Assert.Empty(intents.Raises);
+    }
+}