Skip to content

Commit 7bc6b77

Browse files
authored
Make compare and forName curried as expected by the library (#174)
1 parent 525148c commit 7bc6b77

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

morphir/sdk/core/jvm/src/morphir/sdk/UUID.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ object UUID {
2222
val oidNamespace = "6ba7b812-9dad-11d1-80b4-00c04fd430c8"
2323
val x500Namespace = "6ba7b814-9dad-11d1-80b4-00c04fd430c8"
2424

25-
def compare(uuid1: UUID, uuid2: UUID): Int = uuid1.compareTo(uuid2)
26-
def forName(s: String, uuid: UUID): UUID = MUUID.V5(uuid, s)
25+
def compare(uuid1: UUID)(uuid2: UUID): Int = uuid1.compareTo(uuid2)
26+
def forName(s: String)(uuid: UUID): UUID = MUUID.V5(uuid, s)
2727

2828
/** Creates a valid [[UUID]] from two [[_root_.scala.Long Long]] values representing the most/least significant bits.
2929
*

morphir/sdk/core/test/jvm/src/UUIDSpec.scala

+8-8
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ object UUIDSpec extends MorphirBaseSpec {
1111
suite("parse Tests")(
1212
test("Generate UUID from valid String using parse") {
1313
val namespace = MUUID.V4.random
14-
val uuid = UUID.forName("test", namespace)
14+
val uuid = UUID.forName("test")(namespace)
1515

1616
assert(UUID.parse(uuid.toString))(isRight(equalTo(uuid)))
1717
assertTrue(uuid.version == 5)
@@ -25,7 +25,7 @@ object UUIDSpec extends MorphirBaseSpec {
2525
suite("fromString Tests")(
2626
test("Generate UUID from valid String using fromString") {
2727
val namespace = MUUID.V4.random
28-
val uuid = UUID.forName("test", namespace)
28+
val uuid = UUID.forName("test")(namespace)
2929

3030
assert(UUID.fromString(uuid.toString))(isSome(equalTo(uuid)))
3131
assertTrue(uuid.version == 5)
@@ -49,24 +49,24 @@ object UUIDSpec extends MorphirBaseSpec {
4949
test("Generate same V5 UUID for same namespace and name") {
5050
val namespace = MUUID.V4.random
5151
val name = "Test Name!"
52-
val u1 = UUID.forName(name, namespace)
53-
val u2 = UUID.forName(name, namespace)
52+
val u1 = UUID.forName(name)(namespace)
53+
val u2 = UUID.forName(name)(namespace)
5454
assertEquals(u1, u2)
5555
},
5656
test("Generate unique V5 UUID for unique namespace") {
5757
val namespace1 = MUUID.V4.random
5858
val namespace2 = MUUID.V4.random
5959
val name = "Test Name!"
60-
val u1 = UUID.forName(name, namespace1)
61-
val u2 = UUID.forName(name, namespace2)
60+
val u1 = UUID.forName(name)(namespace1)
61+
val u2 = UUID.forName(name)(namespace2)
6262
assertTrue(u1 != u2)
6363
},
6464
test("Generate unique V5 UUID for unique names") {
6565
val namespace = MUUID.V4.random
6666
val name1 = "Test Name!"
6767
val name2 = "Test Name 2!"
68-
val u1 = UUID.forName(name1, namespace)
69-
val u2 = UUID.forName(name2, namespace)
68+
val u1 = UUID.forName(name1)(namespace)
69+
val u2 = UUID.forName(name2)(namespace)
7070
assertTrue(u1 != u2)
7171
}
7272
)

0 commit comments

Comments
 (0)