refactor: drop ProviderType enum, use str

ProviderType(str, Enum) carried hard-coded provider names (AWS,
PROVIDER1, Provider2) in the domain layer, forcing an edit there
for every new provider.  All usages in the codebase already only
needed the string value, so the enum added no safety benefit.

- domain/base/provider_interfaces.py: remove ProviderType enum;
  ProviderResourceIdentifier.provider_type, ProviderAdapter.provider_type
  and ProviderAdapterFactory signatures now use plain str.
- domain/base/events/provider_events.py: six event classes now carry
  provider_type: str; drop .value accesses in model_post_init bodies.
- providers/aws/strategy/aws_provider_adapter.py: provider_type property
  returns "aws" string; ProviderResourceIdentifier constructed with
  provider_type="aws".

Author: fgogolli

src/orb/domain/base/events/provider_events.py

@@ -6,13 +6,13 @@
 from pydantic import Field
 
 from orb.domain.base.events.base_events import DomainEvent
-from orb.domain.base.provider_interfaces import ProviderInstanceState, ProviderType
+from orb.domain.base.provider_interfaces import ProviderInstanceState
 
 
 class ProviderOperationEvent(DomainEvent):
     """Event raised for provider operations."""
 
-    provider_type: ProviderType
+    provider_type: str  # e.g. "aws"
     operation_type: str  # e.g., "create_instance", "terminate_instance"
     provider_resource_type: str  # e.g., "instance", "volume"
     provider_resource_id: Optional[str] = Field(default=None)
@@ -23,7 +23,7 @@ def model_post_init(self, __context: Any) -> None:
         """Initialize aggregate information after model creation."""
         # Set the base class fields
         object.__setattr__(self, "aggregate_id", self.provider_resource_id or str(uuid4()))
-        object.__setattr__(self, "aggregate_type", f"{self.provider_type.value}_resource")
+        object.__setattr__(self, "aggregate_type", f"{self.provider_type}_resource")
         super().model_post_init(__context)
         if not self.operation_type:
             raise ValueError("Operation type cannot be empty")
@@ -34,15 +34,15 @@ def model_post_init(self, __context: Any) -> None:
 class ProviderRateLimitEvent(DomainEvent):
     """Event raised when provider rate limiting occurs."""
 
-    provider_type: ProviderType
+    provider_type: str  # e.g. "aws"
     service_name: str
     operation_name: str
     retry_after: Optional[int] = Field(default=None)  # seconds
 
     def model_post_init(self, __context: Any) -> None:
         """Initialize aggregate information after model creation."""
-        object.__setattr__(self, "aggregate_id", f"{self.provider_type.value}_{self.service_name}")
-        object.__setattr__(self, "aggregate_type", f"{self.provider_type.value}_service")
+        object.__setattr__(self, "aggregate_id", f"{self.provider_type}_{self.service_name}")
+        object.__setattr__(self, "aggregate_type", f"{self.provider_type}_service")
         super().model_post_init(__context)
         if not self.service_name:
             raise ValueError("Service name cannot be empty")
@@ -53,16 +53,16 @@ def model_post_init(self, __context: Any) -> None:
 class ProviderCredentialsEvent(DomainEvent):
     """Event raised for provider credentials operations."""
 
-    provider_type: ProviderType
+    provider_type: str  # e.g. "aws"
     credential_type: str  # e.g., "access_key", "service_account", "managed_identity"
     operation: str  # e.g., "refresh", "validate", "expire"
     status: str  # success, failure, warning
     message: Optional[str] = Field(default=None)
 
     def model_post_init(self, __context: Any) -> None:
         """Initialize aggregate information after model creation."""
-        object.__setattr__(self, "aggregate_id", f"{self.provider_type.value}_credentials")
-        object.__setattr__(self, "aggregate_type", f"{self.provider_type.value}_auth")
+        object.__setattr__(self, "aggregate_id", f"{self.provider_type}_credentials")
+        object.__setattr__(self, "aggregate_type", f"{self.provider_type}_auth")
         super().model_post_init(__context)
         if not self.credential_type:
             raise ValueError("Credential type cannot be empty")
@@ -75,7 +75,7 @@ def model_post_init(self, __context: Any) -> None:
 class ProviderResourceStateChangedEvent(DomainEvent):
     """Event raised when provider resource state changes."""
 
-    provider_type: ProviderType
+    provider_type: str  # e.g. "aws"
     resource_type: str
     resource_id: str
     previous_state: Optional[ProviderInstanceState] = Field(default=None)
@@ -86,7 +86,7 @@ def model_post_init(self, __context: Any) -> None:
         """Initialize aggregate information after model creation."""
         object.__setattr__(self, "aggregate_id", self.resource_id)
         object.__setattr__(
-            self, "aggregate_type", f"{self.provider_type.value}_{self.resource_type}"
+            self, "aggregate_type", f"{self.provider_type}_{self.resource_type}"
         )
         super().model_post_init(__context)
         if not self.resource_type:
@@ -98,16 +98,16 @@ def model_post_init(self, __context: Any) -> None:
 class ProviderConfigurationEvent(DomainEvent):
     """Event raised for provider configuration changes."""
 
-    provider_type: ProviderType
+    provider_type: str  # e.g. "aws"
     configuration_type: str  # e.g., "region", "endpoint", "timeout"
     old_value: Optional[str] = Field(default=None)
     new_value: Optional[str] = Field(default=None)
     operation: str = Field(default="update")  # update, validate, reset
 
     def model_post_init(self, __context: Any) -> None:
         """Initialize aggregate information after model creation."""
-        object.__setattr__(self, "aggregate_id", f"{self.provider_type.value}_config")
-        object.__setattr__(self, "aggregate_type", f"{self.provider_type.value}_configuration")
+        object.__setattr__(self, "aggregate_id", f"{self.provider_type}_config")
+        object.__setattr__(self, "aggregate_type", f"{self.provider_type}_configuration")
         super().model_post_init(__context)
         if not self.configuration_type:
             raise ValueError("Configuration type cannot be empty")
@@ -116,16 +116,16 @@ def model_post_init(self, __context: Any) -> None:
 class ProviderHealthCheckEvent(DomainEvent):
     """Event raised for provider health checks."""
 
-    provider_type: ProviderType
+    provider_type: str  # e.g. "aws"
     service_name: str
     health_status: str  # healthy, unhealthy, degraded
     response_time_ms: Optional[int] = Field(default=None)
     error_message: Optional[str] = Field(default=None)
 
     def model_post_init(self, __context: Any) -> None:
         """Initialize aggregate information after model creation."""
-        object.__setattr__(self, "aggregate_id", f"{self.provider_type.value}_{self.service_name}")
-        object.__setattr__(self, "aggregate_type", f"{self.provider_type.value}_health")
+        object.__setattr__(self, "aggregate_id", f"{self.provider_type}_{self.service_name}")
+        object.__setattr__(self, "aggregate_type", f"{self.provider_type}_health")
         super().model_post_init(__context)
         if not self.service_name:
             raise ValueError("Service name cannot be empty")

src/orb/domain/base/provider_interfaces.py

@@ -1,18 +1,10 @@
 """Provider interfaces for domain layer - comprehensive provider abstraction."""
 
 from dataclasses import dataclass
-from enum import Enum
+from enum import Enum  # retained for ProviderInstanceState
 from typing import Optional, Protocol
 
 
-class ProviderType(str, Enum):
-    """Supported provider types."""
-
-    AWS = "aws"
-    PROVIDER1 = "provider1"
-    Provider2 = "provider2"
-
-
 class ProviderInstanceState(str, Enum):
     """Provider-agnostic instance states."""
 
@@ -51,7 +43,7 @@ def __post_init__(self) -> None:
 class ProviderResourceIdentifier:
     """Provider-agnostic resource identifier."""
 
-    provider_type: ProviderType
+    provider_type: str  # e.g. "aws"
     resource_type: str  # e.g., "instance", "volume", "network"
     identifier: str  # Provider-specific ID
     region: Optional[str] = None
@@ -109,8 +101,8 @@ class ProviderAdapter(Protocol):
     """Main provider adapter interface."""
 
     @property
-    def provider_type(self) -> ProviderType:
-        """Get the provider type."""
+    def provider_type(self) -> str:
+        """Get the provider type (e.g. ``"aws"``)."""
         ...
 
     @property
@@ -140,10 +132,10 @@ def create_launch_template(
 class ProviderAdapterFactory(Protocol):
     """Factory for creating provider adapters."""
 
-    def create_adapter(self, provider_type: ProviderType) -> ProviderAdapter:
-        """Create a provider adapter for the specified type."""
+    def create_adapter(self, provider_type: str) -> ProviderAdapter:
+        """Create a provider adapter for the specified type (e.g. ``"aws"``)."""
         ...
 
-    def get_supported_providers(self) -> list[ProviderType]:
-        """Get list of supported provider types."""
+    def get_supported_providers(self) -> list[str]:
+        """Get list of supported provider type names."""
         ...

src/orb/providers/aws/strategy/aws_provider_adapter.py

@@ -12,7 +12,6 @@
     ProviderResourceTag,
     ProviderResourceValidator,
     ProviderStateMapper,
-    ProviderType,
 )
 
 
@@ -120,9 +119,9 @@ def __init__(self, logger: LoggingPort) -> None:
         self._logger = logger
 
     @property
-    def provider_type(self) -> ProviderType:
+    def provider_type(self) -> str:
         """Get the provider type."""
-        return ProviderType.AWS
+        return "aws"
 
     @property
     def state_mapper(self) -> ProviderStateMapper:
@@ -143,7 +142,7 @@ def create_resource_identifier(
             raise ValueError(f"Invalid AWS {resource_type} identifier: {identifier}")
 
         return ProviderResourceIdentifier(
-            provider_type=ProviderType.AWS,
+            provider_type="aws",
             resource_type=resource_type,
             identifier=identifier,
             region=region,