Skip to content

Commit 1ecf022

Browse files
committed
refactor(ci): drop dead discover passthrough job in package-testing
package-testing.yml has no workflow_call trigger and no external callers, so the 'backwards-compat passthrough' justification in the discover job comment did not hold. The job consumed a full runner slot just to echo config.outputs.package-extras into its own output — pure overhead. Remove the discover job and have package-variants consume needs.config.outputs.package-extras directly. The matrix fromJSON expression and all downstream jobs are unaffected; they already referenced config for python-versions and default-python-version.
1 parent 0e8d438 commit 1ecf022

1 file changed

Lines changed: 3 additions & 20 deletions

File tree

.github/workflows/package-testing.yml

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -32,37 +32,20 @@ jobs:
3232
name: Get Configuration
3333
uses: ./.github/workflows/shared-config.yml
3434

35-
# Legacy discovery job kept for backwards-compat with any callers that may
36-
# reference this workflow's outputs directly. The package-extras value is
37-
# now sourced from config (shared-config) above; this job is a no-op passthrough.
38-
discover:
39-
name: Discover Package Extras
40-
runs-on: ubuntu-latest
41-
needs: [config]
42-
permissions:
43-
contents: read
44-
outputs:
45-
package-extras: ${{ steps.passthrough.outputs.package-extras }}
46-
steps:
47-
- name: Pass through package-extras from shared config
48-
id: passthrough
49-
run: |
50-
echo "package-extras=${{ needs.config.outputs.package-extras }}" >> "$GITHUB_OUTPUT"
51-
5235
package-variants:
5336
name: Test Package Variants
5437
runs-on: ubuntu-latest
55-
needs: [config, discover]
38+
needs: [config]
5639
permissions:
5740
contents: read
5841
strategy:
5942
fail-fast: false
6043
matrix:
61-
# Dynamic: fromJSON pulls the discovered extras list.
44+
# Dynamic: fromJSON pulls the discovered extras list from shared-config.
6245
# The 'minimal' base install (no extras) is always tested first via a
6346
# separate include entry so the matrix only needs extra names here.
6447
# Static fallback ['cli','api','monitoring'] preserves historical coverage.
65-
extra: ${{ fromJSON(needs.discover.outputs.package-extras || '["cli","api","monitoring"]') }}
48+
extra: ${{ fromJSON(needs.config.outputs.package-extras || '["cli","api","monitoring"]') }}
6649
# Python version axis driven from .project.yml via shared-config.
6750
# Static fallback keeps act/offline CI valid; update it when python.versions changes.
6851
python-version: ${{ fromJSON(needs.config.outputs.python-versions || '["3.10", "3.11", "3.12", "3.13", "3.14"]') }}

0 commit comments

Comments
 (0)