Skip to content

Commit 3cadf35

Browse files
committed
ci(make): drop duplicate container-health-check and test-docker recipes
Both targets were defined twice — once in deploy.mk and once in the file that ended up winning (Makefile for container-health-check, dev.mk for test-docker). Make printed the override warnings on every invocation: deploy.mk:27: warning: overriding commands for target `test-docker' dev.mk:94: warning: ignoring old commands for target `test-docker' Makefile:64: warning: overriding commands for target `container-health-check' deploy.mk:24: warning: ignoring old commands for target `container-health-check' The deploy.mk versions were the older / overridden copies. Drop them and leave a comment explaining where each canonical recipe lives.
1 parent 3498f73 commit 3cadf35

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

makefiles/deploy.mk

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,9 @@ container-show-version: dev-install ## Show container version info
2020
container-run: dev-install ## Run container build
2121
@./dev-tools/container/container_dispatcher.py run
2222

23-
container-health-check: ## Poll container health check endpoint
24-
@./dev-tools/container/container_health_check.py
25-
26-
test-docker: ## Run Docker test suite (build, startup, security, pytest tests/docker/)
27-
@./dev-tools/testing/test-docker.sh
23+
# container-health-check: defined in the top-level Makefile (uv-based variant).
24+
# test-docker: defined in dev.mk alongside the rest of the test targets.
25+
# Removing the duplicate recipes here clears `make: warning: overriding commands`.
2826

2927
# Dummy targets removed (consolidated in quality.mk)
3028

0 commit comments

Comments
 (0)