Skip to content

Commit 937a273

Browse files
committed
fix(ci): use coverage report --fail-under (not the pytest-cov --cov-fail-under)
The coverage-combine gate called 'coverage report --cov-fail-under=60', but --cov-fail-under is a pytest-cov flag; the coverage CLI uses --fail-under. 'coverage report' errored 'no such option'.
1 parent ff03cd8 commit 937a273

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

makefiles/ci.mk

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,10 +165,12 @@ ci-tests-infrastructure: ## Run infrastructure tests only (matches ci.yml infra
165165
@echo "Running infrastructure tests (parallel)..."
166166
$(call run-tool,pytest,$(TESTS_INFRASTRUCTURE) $(PYTEST_PARALLEL) $(PYTEST_ARGS) $(PYTEST_COV_ARGS) --cov-report=xml:coverage-infrastructure.xml --junitxml=junit-infrastructure.xml)
167167

168-
ci-tests-coverage-check: ## Local combined-coverage check (CI enforces the floor via codecov.yml project status)
168+
ci-tests-coverage-check: ## Combined-coverage gate: merge per-leg data + enforce threshold
169169
@echo "Combining per-leg coverage data and checking combined threshold ($(COVERAGE_THRESHOLD)%)..."
170170
$(call run-tool,coverage,combine)
171-
$(call run-tool,coverage,report $(PYTEST_COV_FAIL_UNDER))
171+
# `coverage report` uses --fail-under (the pytest-cov spelling
172+
# --cov-fail-under is not valid for the coverage CLI).
173+
$(call run-tool,coverage,report --fail-under=$(COVERAGE_THRESHOLD))
172174

173175
# @SECTION UI Build
174176

0 commit comments

Comments
 (0)