Skip to content

Commit 9c50049

Browse files
committed
test(e2e): patch args._container not the removed get_container
handle_provider_config / handle_reload_provider_config resolve the DI container from args._container (consistent with every other interface handler); the tests still patched a get_container symbol that no longer exists in the module. Set _container on the mock command instead.
1 parent 9939a65 commit 9c50049

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

tests/e2e/test_cli_integration.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ def create_config_file(self, config_data):
3131
return self.config_path
3232

3333
@pytest.mark.asyncio
34-
@patch("orb.interface.system_command_handlers.get_container")
35-
async def test_get_provider_config_cli_e2e(self, mock_get_container):
34+
async def test_get_provider_config_cli_e2e(self):
3635
"""Test getProviderConfig CLI operation end-to-end."""
3736
# Setup mocks
3837
mock_container = Mock()
@@ -50,12 +49,13 @@ async def mock_execute(_query):
5049
mock_orchestrator = Mock()
5150
mock_orchestrator.execute = mock_execute
5251
mock_container.get.return_value = mock_orchestrator
53-
mock_get_container.return_value = mock_container
5452

5553
# Test async function-based handler
5654
from orb.interface.command_handlers import handle_provider_config
5755

56+
# Handlers resolve the DI container from args._container.
5857
mock_command = Mock()
58+
mock_command._container = mock_container
5959

6060
result = await handle_provider_config(mock_command)
6161

@@ -96,8 +96,7 @@ async def test_validate_provider_config_cli_e2e(self, mock_register_services):
9696
assert "provider configuration" in result["message"].lower()
9797

9898
@pytest.mark.asyncio
99-
@patch("orb.interface.system_command_handlers.get_container")
100-
async def test_reload_provider_config_cli_e2e(self, mock_get_container):
99+
async def test_reload_provider_config_cli_e2e(self):
101100
"""Test reloadProviderConfig CLI operation end-to-end."""
102101
from orb.application.dto.interface_response import InterfaceResponse
103102
from orb.application.services.provider_registry_service import ProviderRegistryService
@@ -125,12 +124,13 @@ def container_get(cls):
125124
return Mock()
126125

127126
mock_container.get.side_effect = container_get
128-
mock_get_container.return_value = mock_container
129127

130128
# Test async function-based handler
131129
from orb.interface.command_handlers import handle_reload_provider_config
132130

131+
# Handlers resolve the DI container from args._container.
133132
mock_command = Mock()
133+
mock_command._container = mock_container
134134
mock_command.config_path = self.config_path
135135
mock_command.file = None
136136
mock_command.data = None

0 commit comments

Comments
 (0)