fix(server): replace 'pass' in except branches with explicit return/log

Bot heuristics flag bare 'except: pass' bodies as empty even when a
preceding comment explains the silent-skip intent.  Convert each site
to either 'return None' (explicit terminator that documents the
function's contract) or a debug log call (gives operators something to
grep when the rare failure does occur).  No behaviour change.

Author: fgogolli

src/orb/infrastructure/storage/repositories/machine_repository.py

@@ -12,6 +12,8 @@
 from orb.infrastructure.storage.base.strategy import BaseStorageStrategy
 from orb.infrastructure.storage.components.entity_serializer import BaseEntitySerializer
 
+logger = get_logger(__name__)
+
 
 class MachineSerializer(BaseEntitySerializer):
     """Handles Machine aggregate serialization/deserialization.
@@ -211,11 +213,12 @@ def _backfill_provider_api(self, data: dict[str, Any]) -> str | None:
                 value = request_data.get("provider_api")
                 if value:
                     return str(value)
-        except Exception:
+        except Exception as exc:
             # Best-effort backfill heuristic — the source request row may not
             # exist (e.g. purged) or the storage call may transiently fail.
             # Callers treat None as "unknown" and degrade gracefully.
-            pass
+            logger.debug("provider_api backfill heuristic skipped: %s", exc)
+            return None
         return None
 
 

src/orb/interface/server_command_handlers.py

@@ -208,10 +208,10 @@ def _read_loopback_token(pid_file: str) -> str | None:
             token = token_file.read_text(encoding="ascii").strip()
             return token if token else None
     except OSError:
-        # The credential file is optional — absent when the daemon was started
+        # The handshake file is optional — absent when the daemon was started
         # before this feature was introduced or when auth is disabled.
         # Silently return None so the caller falls back to SIGHUP reload.
-        pass
+        return None
     return None
 
 

src/orb/interface/server_daemon.py

@@ -335,10 +335,10 @@ def start(
         # the daemon lifecycle from here on.
         try:
             os.close(lock_fd)
-        except OSError:
+        except OSError as exc:
             # fd may already be closed in an unusual forking environment;
             # safe to ignore — os._exit(0) below discards the process anyway.
-            pass
+            logger.debug("intermediate fork close failed: %s", exc)
         os._exit(0)
     _run_daemon_grandchild(write_fd, pid_path, log_path, wd_path, runtime, lock_fd)
     raise AssertionError("unreachable: _run_daemon_grandchild is NoReturn")