NodeJS apps: reference-data and trade-feed: decrease container size and improve security posture (#258)

* Optimized Dockerfile for reference-data

Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>

* Optimized Dockerfile for trade-feed

Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>

---------

Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>

Author: mathieu-benoit

reference-data/Dockerfile

@@ -1,20 +1,15 @@
-# [Choice] Node.js version (use -bullseye variants on local arm64/Apple Silicon): 18, 16, 14, 18-bullseye, 16-bullseye, 14-bullseye, 18-buster, 16-buster, 14-buster
-ARG VARIANT=16-bullseye
-FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}
+FROM --platform=$BUILDPLATFORM node:23 AS builder
+WORKDIR /usr/src/app
+COPY package*.json ./
+RUN npm install --only=production
+COPY . .
+RUN npm run build
 
-WORKDIR /reference-data
+FROM alpine:3.21
+RUN apk add --no-cache nodejs
+WORKDIR /usr/src/app
+COPY --from=builder /usr/src/app/dist ./dist
+COPY --from=builder /usr/src/app/node_modules ./node_modules
 COPY . .
 EXPOSE 18085
-
-# [Optional] Uncomment this section to install additional OS packages.
-# RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
-#     && apt-get -y install --no-install-recommends <your-package-list-here>
-
-# [Optional] Uncomment if you want to install an additional version of node using nvm
-ARG EXTRA_NODE_VERSION=18
-RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}"
-
-# [Optional] Uncomment if you want to install more global node modules
-# RUN su node -c "npm install -g <your-package-list-here>"
-RUN npm install
-ENTRYPOINT npm run start
+CMD [ "node", "dist/main"]

reference-data/base.Dockerfile

@@ -1,20 +1,12 @@
-# [Choice] Node.js version (use -bullseye variants on local arm64/Apple Silicon): 18, 16, 14, 18-bullseye, 16-bullseye, 14-bullseye, 18-buster, 16-buster, 14-buster
-ARG VARIANT=16-bullseye
-FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}
-
-WORKDIR /trade-feed
+FROM --platform=$BUILDPLATFORM node:23 AS builder
+WORKDIR /usr/src/app
+COPY package*.json ./
+RUN npm install --only=production
+
+FROM alpine:3.21
+RUN apk add --no-cache nodejs
+WORKDIR /usr/src/app
+COPY --from=builder /usr/src/app/node_modules ./node_modules
 COPY . .
 EXPOSE 18086
-
-# [Optional] Uncomment this section to install additional OS packages.
-# RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
-#     && apt-get -y install --no-install-recommends <your-package-list-here>
-
-# [Optional] Uncomment if you want to install an additional version of node using nvm
-ARG EXTRA_NODE_VERSION=18
-RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}"
-
-# [Optional] Uncomment if you want to install more global node modules
-# RUN su node -c "npm install -g <your-package-list-here>"
-RUN npm install
-ENTRYPOINT npm run start
+ENTRYPOINT [ "node", "index.js" ]