Skip to content

Commit 27125f8

Browse files
authored
remove deprecated react methods (#1569)
1 parent 3b194f6 commit 27125f8

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

vuu-ui/tools/vuu-showcase/scripts/html-template.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,16 @@ export default `<!doctype html>
66
<title>Vuu Showcase</title>
77
<script type="module">
88
import React from "react";
9-
import ReactDOM from "react-dom";
9+
import {createRoot} from "react-dom/client";
1010
import { Showcase, ShowcaseStandalone } from "@finos/vuu-showcase";
1111
import { hasUrlParameter } from "@finos/vuu-utils";
1212
const { default: treeSource } = await import("/treeSourceJson.js");
13-
const root = document.getElementById("root");
13+
const container = document.getElementById("root");
14+
const root = createRoot(container);
1415
if (hasUrlParameter("standalone")) {
15-
ReactDOM.render(React.createElement(ShowcaseStandalone, { treeSource }), root);
16+
root.render(React.createElement(ShowcaseStandalone, { treeSource }));
1617
} else {
17-
ReactDOM.render(React.createElement(Showcase, { treeSource }), root);
18+
root.render(React.createElement(Showcase, { treeSource }));
1819
}
1920
</script>
2021
</head>

vuu-ui/tools/vuu-showcase/src/root.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,19 @@
11
import React from "react";
2-
import ReactDOM from "react-dom";
2+
import { createRoot } from "react-dom/client";
33
import { Showcase, ShowcaseStandalone } from "@finos/vuu-showcase";
44
import { hasUrlParameter, TreeSourceNode } from "@finos/vuu-utils";
55

66
function start(treeSource: TreeSourceNode[]) {
7-
const root = document.getElementById("root");
8-
if (hasUrlParameter("standalone")) {
9-
ReactDOM.render(
10-
React.createElement(ShowcaseStandalone, { treeSource }),
11-
root,
12-
);
7+
const container = document.getElementById("root");
8+
if (container) {
9+
const root = createRoot(container);
10+
if (hasUrlParameter("standalone")) {
11+
root.render(React.createElement(ShowcaseStandalone, { treeSource }));
12+
} else {
13+
root.render(React.createElement(Showcase, { treeSource }));
14+
}
1315
} else {
14-
ReactDOM.render(React.createElement(Showcase, { treeSource }), root);
16+
throw Error("document does not contain #root wlwmwnt");
1517
}
1618
}
1719

0 commit comments

Comments
 (0)