Add the ability to specify a default sort behaviour on a Table (#1922)

* WiP

* Tests

* Tests

* Tests

* Implement default sort

* Added more constructors for table defs

* Added more constructors for table defs

* Added an integ test

Author: stonesmi

benchmark/src/main/java/org/finos/vuu/benchmark/sort/SortBenchmark.java

@@ -7,7 +7,6 @@
 import org.finos.vuu.net.SortDef;
 import org.finos.vuu.net.SortSpec;
 
-import java.util.Arrays;
 import java.util.List;
 
 import static org.finos.vuu.util.ScalaCollectionConverter.toScala;
@@ -23,9 +22,7 @@ public SortBenchmark(BenchmarkHelper benchmarkHelper, int size) {
     void sortLargeTable() {
         var sort = new GenericSort2(
                 SortSpec.apply(toScala(List.of(SortDef.apply("exchange", 'A')))),
-                toScala(Arrays.stream(inMemDataTable.getTableDef().columns())
-                        .filter(f -> f.name().equals("exchange"))
-                        .toList()));
+                toScala(List.of(inMemDataTable.getTableDef().columnForName("exchange"))));
         var viewPortColumns = ViewPortColumnCreator.create(inMemDataTable, toScala(List.of("exchange")));
         sort.doSort(inMemDataTable, inMemDataTable.primaryKeys(), viewPortColumns);
     }

example/apache-ignite/src/main/scala/org/finos/vuu/example/ignite/module/IgniteOrderDataModule.scala

@@ -25,7 +25,7 @@ object IgniteOrderDataModule extends DefaultModule {
         ),
         (_, _) => new IgniteOrderDataProvider(igniteOrderStore),
         (table, _, _, _) => ViewPortDef(
-          columns = table.getTableDef.columns,
+          columns = table.getTableDef.getColumns,
           service = new NoOpIgniteService()
         )
       ).asModule()

example/basket/src/main/scala/org/finos/vuu/core/module/basket/BasketModule.scala

@@ -36,7 +36,7 @@ object BasketModule extends DefaultModule {
         ),
         (table, _) => new BasketProvider(table),
         (table, _, _, tableContainer) => ViewPortDef(
-          columns = table.getTableDef.columns,
+          columns = table.getTableDef.getColumns,
           service = new BasketService(table, omsApi)(clock, tableContainer)
         )
       )
@@ -70,7 +70,7 @@ object BasketModule extends DefaultModule {
         ),
         (table, vs) => new BasketTradingProvider(table, vs.tableContainer),
         (table, _, _, tableContainer) => ViewPortDef(
-          columns = table.getTableDef.columns,
+          columns = table.getTableDef.getColumns,
           service = new BasketTradingService(table, omsApi)(clock, tableContainer)
         )
       )
@@ -101,7 +101,7 @@ object BasketModule extends DefaultModule {
         ),
         (table, vs) => new BasketTradingConstituentProvider(table, omsApi),
         (table, _, _, tableContainer) => ViewPortDef(
-          columns = table.getTableDef.columns,
+          columns = table.getTableDef.getColumns,
           service = new BasketTradingConstituentService(table)(clock, tableContainer)
         )
       )
@@ -143,7 +143,7 @@ object BasketModule extends DefaultModule {
           joinFields = Seq(),
         ),
         (table, _, _, tableContainer) => ViewPortDef(
-          columns = table.getTableDef.columns,
+          columns = table.getTableDef.getColumns,
           service = new BasketTradingConstituentJoinService(table)(clock, tableContainer)
         )
       )

example/basket/src/test/scala/org/finos/vuu/core/module/basket/BasketCreateTest.scala

@@ -35,7 +35,7 @@ class BasketCreateTest extends VuuServerTestCase {
           vuuServer.login("testUser")
           val basketId = ".FTSE"
 
-          vuuServer.overrideViewPortDef("prices", (table, _, _, _) => ViewPortDef(table.getTableDef.columns, null))
+          vuuServer.overrideViewPortDef("prices", (table, _, _, _) => ViewPortDef(table.getTableDef.getColumns, null))
 
           val pricesProvider = vuuServer.getProvider(PriceModule.NAME, PriceModule.PriceTable)
           val basketProvider = vuuServer.getProvider(BasketModule.NAME, BasketModule.BasketTable)

example/basket/src/test/scala/org/finos/vuu/core/module/basket/BasketMutateOffMarketTest.scala

@@ -30,7 +30,7 @@ class BasketMutateOffMarketTest extends VuuServerTestCase {
 
           vuuServer.login("testUser")
 
-          vuuServer.overrideViewPortDef("prices", (table, _, _, _) => ViewPortDef(table.getTableDef.columns, null))
+          vuuServer.overrideViewPortDef("prices", (table, _, _, _) => ViewPortDef(table.getTableDef.getColumns, null))
 
           val pricesProvider = vuuServer.getProvider(PriceModule.NAME, "prices")
           val basketProvider = vuuServer.getProvider(BasketModule.NAME, BasketTable)

example/basket/src/test/scala/org/finos/vuu/core/module/basket/BasketSendToMarketTest.scala

@@ -33,7 +33,7 @@ class BasketSendToMarketTest extends VuuServerTestCase {
 
           vuuServer.login("testUser")
 
-          vuuServer.overrideViewPortDef("prices", (table, _, _, _) => ViewPortDef(table.getTableDef.columns, null))
+          vuuServer.overrideViewPortDef("prices", (table, _, _, _) => ViewPortDef(table.getTableDef.getColumns, null))
 
           val pricesProvider = vuuServer.getProvider(PriceModule.NAME, "prices")
           val basketProvider = vuuServer.getProvider(BasketModule.NAME, BasketTable)

example/basket/src/test/scala/org/finos/vuu/provider/BasketConstituentProviderTest.scala

@@ -34,7 +34,7 @@
 //  )
 //  val table = new InMemDataTable(tableDef, joinProvider)
 //  val provider = new BasketConstituentProvider(table)
-//  val columns: Array[Column] = provider.table.getTableDef.columns
+//  val columns: Array[Column] = provider.table.getTableDef.getColumns
 //  val headers: Array[String] = columns.map(_.name)
 //
 //  before {

example/basket/src/test/scala/org/finos/vuu/provider/BasketProviderTest.scala

@@ -32,7 +32,7 @@
 //  )
 //  val table = new InMemDataTable(tableDef, joinProvider)
 //  val provider = new BasketProvider(table)
-//  val columns: Array[Column] = provider.table.getTableDef.columns
+//  val columns: Array[Column] = provider.table.getTableDef.getColumns
 //  val headers: Array[String] = columns.map(_.name)
 //
 //  before {

example/editable/src/main/scala/org/finos/vuu/core/module/editable/EditableModule.scala

@@ -23,7 +23,7 @@ object EditableModule extends DefaultModule {
         ),
         (table, vs) => new ProcessProvider(table),
         (table, _, _, tableContainer) => ViewPortDef(
-          columns = table.getTableDef.columns,
+          columns = table.getTableDef.getColumns,
           service = new ProcessRpcService()(tableContainer)
         )
       ).addSessionTable(
@@ -33,7 +33,7 @@ object EditableModule extends DefaultModule {
         columns = Columns.fromNames("process-id:String", "sequenceNumber:Int")
       ),
       (table, _, _, tableContainer) => ViewPortDef(
-        columns = table.getTableDef.columns,
+        columns = table.getTableDef.getColumns,
         service = new FixSequenceRpcService()(clock, tableContainer)
       )
     ).asModule()

example/editable/src/test/scala/org/finos/vuu/core/module/editable/EditableTestModule.scala

@@ -152,7 +152,7 @@ object EditableTestModule {
         ),
         (table, _) => new NullProvider(),
         (table, _, _, tableContainer) => ViewPortDef(
-          columns = table.getTableDef.columns,
+          columns = table.getTableDef.getColumns,
           service = new TestEditableService(table, tableContainer)
         )
       ).asModule()
@@ -179,7 +179,7 @@ object EditTableTestModule {
         ),
         (table, _) => new NullProvider(),
         (table, _, _, tableContainer) => ViewPortDef(
-          columns = table.getTableDef.columns,
+          columns = table.getTableDef.getColumns,
           service = new EditTableTestService()(using tableContainer)
         )
       ).asModule()