FIX: org view rating explorer (was working from a limited set of capabilities)

FIX: rating explorer tree sorts on 'name'

#206

Author: davidwatkins73

waltz-ng/client/org-units/services/org-unit-view-data.js

@@ -92,7 +92,7 @@ function service($q,
         const bulkPromise = $q.all([
             ratingStore.findByAppIds(appIds),
             appCapabilityStore.findApplicationCapabilitiesByAppIdSelector(appIdSelector),
-            capabilityStore.findByAppIds(appIds),
+            capabilityStore.findAll(),
             ratedDataFlowDataService.findByOrgUnitTree(orgUnitId),  // use orgIds (ASC + DESC)
             authSourceCalculator.findByOrgUnit(orgUnitId),  // use orgIds(ASC)
             endUserAppStore.findByOrgUnitTree(orgUnitId),   // use orgIds(DESC)

waltz-ng/client/ratings/directives/rating-explorer/rating-explorer-section.html

@@ -31,7 +31,7 @@
             <div class="col-md-4">
                 <treecontrol class="tree-light"
                              tree-model="ctrl.capabilityTree.data"
-                             order-by="name"
+                             order-by="'-name'"
                              on-selection="ctrl.selectCapability(node)"
                              options="ctrl.capabilityTree.options">
                         <span ng-class="{ 'waltz-inherited-value' : node.implied }">

waltz-ng/client/ratings/directives/rating-explorer/rating-explorer-section.js

@@ -46,7 +46,14 @@ function calculateRequiredCapabilities(directCaps = [],
             cap.level5]))
         .filter(id => id != null)
         .uniq()
-        .map(id => capsById[id])
+        .map(id => {
+            const cap = capsById[id];
+            if (!cap) {
+                console.log("Capability Id referenced but does not exist", id);
+            }
+            return cap;
+        })
+        .filter(cap => cap != null)
         .value()
 }