AND NOT - unexpected results

[LittleUmbrella]

The following were run against the example:

console.log(data.filter(luceneFilter('species: droid AND NOT name:"Moon Moon"')));

-> []

console.log(data.filter(luceneFilter('species: droid AND NOT name:R2-D2')));

-> [Object]
0: Object
name: "R2-D2"
description: "Astromech droid built on Naboo."
species: "Droid"
!

[finwo]

This bug is probably related to #49
Further investigation will be required on both.

[paulcanning]

@finwo any update on this bug? Just stumbled on it myself, wondering if it's an easy fix?

[finwo]

Sorry, I haven't looked into it yet (life happened and I forgot 😅)

[paulcanning]

@finwo no worries.

I'm trying to decipher the tests for the operators, but having trouble 😂

If there are any pointers you can give me that would help, it'd be much appreciated!

[finwo]

The rough idea for the operator itself

Receive a left and right matcher, perform the operation (and, not, nand, or, nor, etc) on the results of those and return the result of that operation. Essentially, like their name suggests, they're a definition on how to mix 2 filters/matchers.

Some pointers from re-reading my code

The numeric named methods in the tests are therefor an emulation of a previous matcher, removing dependencies on any query parsing.

In the test for the AND, it returns the result of the matcher closest to zero, which at the time seemed to work for my use-case (but very well may be invalid for other use-cases).

During the AND NOT, I must've had a brainfart, as for positive numbers it returns the exact same as the AND operator, but the negative number handling is inverted.