Skip to content

Commit bd1e9fd

Browse files
Apply suggestions from code review
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent eb03072 commit bd1e9fd

File tree

5 files changed

+5
-1
lines changed

5 files changed

+5
-1
lines changed

FirebaseSwiftUI/FirebaseAppleSwiftUI/Sources/Views/SignInWithAppleButton.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ extension SignInWithAppleButton: View {
5454
}
5555

5656
reportError?(error)
57-
throw error
5857
}
5958
}
6059
}

FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Services/AuthService.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,7 @@ public final class AuthService {
218218
}
219219
)
220220
}
221+
}
221222

222223
public func signIn(_ provider: CredentialAuthProviderSwift) async throws -> SignInOutcome {
223224
let credential = try await provider.createAuthCredential()

FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/ErrorAlertView.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ struct ErrorAlertModifier: ViewModifier {
4040
case .legacySignInRecoveryPresented = authError {
4141
return false
4242
}
43+
}
4344

4445
return true
4546
}

e2eTest/FirebaseSwiftUIExample/FirebaseSwiftUIExample/TestView.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ struct TestView: View {
9898
]
9999
)
100100
}
101+
}
101102
authService.isPresented = true
102103
}
103104

e2eTest/FirebaseSwiftUIExample/FirebaseSwiftUIExampleUITests/TestUtils.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ func createEmail() -> String {
2828
}
2929
return app
3030
}
31+
return app
32+
}
3133

3234
// MARK: - Alert Handling
3335

0 commit comments

Comments
 (0)