Skip to content

Commit b1d304a

Browse files
authored
Increase upload timeout to 5 minutes. (#281)
* Increase upload timeout to 5 minutes. * Bump version to 0.3.6. * Add comment for generic config parameters.
1 parent f9ff065 commit b1d304a

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb

+1
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,7 @@ def self.available_options
189189
verify_block: proc do |value|
190190
UI.user_error!("firebase_app_distribution: '#{value}' is not a valid value for android_artifact_type. Should be 'APK' or 'AAB'") unless ['APK', 'AAB'].include?(value)
191191
end),
192+
# Generic
192193
FastlaneCore::ConfigItem.new(key: :app,
193194
env_name: "FIREBASEAPPDISTRO_APP",
194195
description: "Your app's Firebase App ID. You can find the App ID in the Firebase console, on the General Settings page",

lib/fastlane/plugin/firebase_app_distribution/client/firebase_app_distribution_api_client.rb

+1
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ def get_aab_info(app_name)
110110
# Throws a user_error if the binary file does not exist
111111
def upload_binary(app_name, binary_path, platform)
112112
response = connection.post(binary_upload_url(app_name), read_binary(binary_path)) do |request|
113+
request.options.timeout = 300 # seconds
113114
request.headers[AUTHORIZATION] = "Bearer " + @auth_token
114115
request.headers[CONTENT_TYPE] = APPLICATION_OCTET_STREAM
115116
request.headers[CLIENT_VERSION] = client_version_header_value
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
module Fastlane
22
module FirebaseAppDistribution
3-
VERSION = "0.3.5"
3+
VERSION = "0.3.6"
44
end
55
end

0 commit comments

Comments
 (0)