Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: firebase/fastlane-plugin-firebase_app_distribution
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.8
Choose a base ref
...
head repository: firebase/fastlane-plugin-firebase_app_distribution
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref

Commits on Jan 17, 2023

  1. Print out release links

    * Firebase Console link: links to the release on the Firebase Console
    * Testing link: links to the tester experience (iOS web clip or Android app)
    * Binary Download link: link to download the IPA/APK/AAB (expires in 1 hr)
    rebehe committed Jan 17, 2023
    Copy the full SHA
    16fbcaa View commit details
  2. Merge pull request #288 from fastlane/add-release-links

    Print out release links
    rebehe authored Jan 17, 2023
    Copy the full SHA
    f836c68 View commit details
  3. Bump version to 0.4.0.pre.1

    rebehe committed Jan 17, 2023
    Copy the full SHA
    277963a View commit details
  4. Merge pull request #289 from fastlane/bump-version-0.4.0.pre.1

    Bump version to 0.4.0.pre.1
    rebehe authored Jan 17, 2023
    Copy the full SHA
    c7c4d72 View commit details

Commits on Jan 18, 2023

  1. Copy the full SHA
    19bfed8 View commit details
  2. Merge pull request #290 from fastlane/add-client-version

    Add client version request header to all requests
    rebehe authored Jan 18, 2023
    Copy the full SHA
    f4c7bea View commit details

Commits on Jan 19, 2023

  1. Bump version to 0.4.0.pre.2

    rebehe committed Jan 19, 2023
    Copy the full SHA
    15ef5f8 View commit details
  2. Merge pull request #291 from fastlane/bump-version-0.4.0.pre.2

    Bump version to 0.4.0.pre.2
    rebehe authored Jan 19, 2023
    Copy the full SHA
    ec6f1ef View commit details
  3. Bump version to 0.4.0

    rebehe committed Jan 19, 2023
    Copy the full SHA
    c700ca4 View commit details
  4. Merge pull request #292 from fastlane/bump-version-0.4.0

    Bump version to 0.4.0
    rebehe authored Jan 19, 2023
    Copy the full SHA
    67e717c View commit details

Commits on Jan 24, 2023

  1. Bump version to 0.4.1

    rebehe committed Jan 24, 2023
    Copy the full SHA
    ee194b8 View commit details
  2. Merge pull request #294 from fastlane/bump-version-0.4.1

    Bump version to 0.4.1
    rebehe authored Jan 24, 2023
    Copy the full SHA
    ed70797 View commit details
  3. Bump version to 0.4.2

    rebehe committed Jan 24, 2023
    Copy the full SHA
    ad4ce9c View commit details
  4. Merge pull request #295 from fastlane/bump-version-0.4.2

    Bump version to 0.4.2
    rebehe authored Jan 24, 2023
    Copy the full SHA
    f214169 View commit details

Commits on Jan 25, 2023

  1. Copy the full SHA
    ac4e11f View commit details

Commits on Jan 26, 2023

  1. Merge pull request #296 from fastlane/create-github-action

    Create GitHub Action for publishing to RubyGems
    rebehe authored Jan 26, 2023
    Copy the full SHA
    5dd4a76 View commit details
  2. Copy the full SHA
    4418b22 View commit details
  3. Merge pull request #297 from fastlane/bump-version-0.4.3.pre.1

    Update github action release flow
    rebehe authored Jan 26, 2023
    Copy the full SHA
    409f69c View commit details

Commits on Feb 14, 2023

  1. Remove login task (#298)

    * Remove login task
    
    * Add missing double quote
    
    * Add SCOPE variable to auth client and update comments
    tagboola authored Feb 14, 2023
    Copy the full SHA
    a0f97c6 View commit details
  2. Save release to shared lane variable (#299)

    * Save release to shared lane variable
    
    * Update emoji for when release notes are skipped
    
    * Change to UI.info
    
    * Change UI.info to UI.message
    
    * Add output function to action
    
    * Add output function to action
    
    * Address PR comments
    
    * Defined SharedVariables constant
    tagboola authored Feb 14, 2023
    Copy the full SHA
    b04e28a View commit details
  3. Copy the full SHA
    f0db15a View commit details
  4. Copy the full SHA
    c831f4f View commit details
  5. Copy the full SHA
    aeb3e01 View commit details

Commits on May 31, 2023

  1. Create ruby.yml

    kaibolay authored May 31, 2023
    Copy the full SHA
    20050fe View commit details
  2. Only test with ruby versions 2.7 and 3.0 (#311)

    Other versions fail with
    ```
    wrong number of arguments (given 5, expected 1)
    /opt/hostedtoolcache/Ruby/3.1.4/x64/lib/ruby/3.1.0/psych.rb:322:in `safe_load'
    ```
    kaibolay authored May 31, 2023
    Copy the full SHA
    8f3babc View commit details

Commits on Jun 5, 2023

  1. Add functionality for creation of tester groups (#309)

    * Add tester group functions to API client
    * Add add_tester_groups action: Enable users to create tester groups. 
    * Modify add_testers action to allow specifying group alias
    
    Add basic tester group creation and deletion functions, as documented at https://firebase.google.com/docs/reference/app-distribution/rest/v1/projects.groups.
    
    The functionality here is in line with what we already have for adding and removing testers;  there's no sync logic, just creations and deletion.
    garry-jeromson authored Jun 5, 2023
    Copy the full SHA
    89557e7 View commit details
  2. Remove CircleCI config

    kaibolay committed Jun 5, 2023
    Copy the full SHA
    e4396fa View commit details
  3. Remove .DS_Store file

    kaibolay committed Jun 5, 2023
    Copy the full SHA
    6c28f0c View commit details
  4. Copy the full SHA
    3443307 View commit details

Commits on Jun 7, 2023

  1. Support group_alias parameter for remove_testers_action. (#313)

    This removes the testers from only the specified group, but doesn't
    delete them from the project.
    kaibolay authored Jun 7, 2023
    Copy the full SHA
    a99305e View commit details
  2. bump version

    kaibolay authored Jun 7, 2023
    Copy the full SHA
    23baf03 View commit details

Commits on Jul 18, 2023

  1. Prefer Google auth library and generated API client for list releases…

    … action (#307)
    
    * WIP - use generated API client
    
    * Fix failing tests
    
    * Fix failing tests
    
    * Handle nil release notes
    
    ---------
    
    Co-authored-by: Tunde Agboola <tun.agboola@gmail.com>
    lfkellogg and tagboola authored Jul 18, 2023
    Copy the full SHA
    a1c8d42 View commit details

Commits on Jul 19, 2023

  1. Prefer generated API client for create and delete group actions (#314)

    * Prefer generated API client for create and delete group actions
    
    * Remove unused API client methods
    tagboola authored Jul 19, 2023
    Copy the full SHA
    67a391f View commit details
  2. Copy the full SHA
    b5ef998 View commit details
  3. Update add and remove testers to use generated API client (#316)

    * Support debug mode and client headers with generated API client
    
    * Update add and remove testers to use generated API client
    
    * Update upload action to use generated api client to get AAB info
    
    * Revert "Update upload action to use generated api client to get AAB info"
    
    This reverts commit c04aeae.
    tagboola authored Jul 19, 2023
    Copy the full SHA
    40655af View commit details
  4. Update upload action to use generated api client to get AAB info (#317)

    * Support debug mode and client headers with generated API client
    
    * Update add and remove testers to use generated API client
    
    * Update upload action to use generated api client to get AAB info
    
    * Update upload action to use generated api client to get AAB info
    
    * Fix test certificate code
    
    * Revert ruby version back to 2.7.6
    
    * More fixes to test certificate code
    
    * Put back code that was removed by mistake
    
    * Properly stub authorization
    
    * Fix aab specs
    tagboola authored Jul 19, 2023
    Copy the full SHA
    ed907b7 View commit details

Commits on Jul 21, 2023

  1. Update upload and update release note methods to use generated API cl…

    …ient (#318)
    
    * Update upload and update release note methods to use generated API client
    
    * Remove update release note method from API client
    
    * Remove FirebaseappdistributionV1 variable
    
    * Remove FirebaseappdistributionV1 variable
    tagboola authored Jul 21, 2023
    Copy the full SHA
    d7606de View commit details

Commits on Jul 22, 2023

  1. Copy the full SHA
    6adcb89 View commit details
  2. Fix get UDID action (#320)

    tagboola authored Jul 22, 2023
    Copy the full SHA
    37e7b20 View commit details

Commits on Jul 24, 2023

  1. Copy the full SHA
    dca5959 View commit details

Commits on Jul 25, 2023

  1. Copy the full SHA
    23097df View commit details
  2. Fix bug when nil groups or testers causes distribution to fail (#322)

    * Fix bug when nil groups or testers causes distribution to fail
    
    * Fix if statement
    
    * Refactor and add more tests
    
    * Clean up action class
    
    * Remove logging changes
    tagboola authored Jul 25, 2023
    Copy the full SHA
    78598c0 View commit details
  3. Handle user errors for tester and group actions (#324)

    * Handle user errors for tester and group actions
    
    * Handle tester limit violation error for adding testers to groups
    tagboola authored Jul 25, 2023
    Copy the full SHA
    fd6beeb View commit details
  4. Handle user errors when uploading releases (#325)

    * Handle user errors when uploading releases
    
    * Disable class length too long rubocop offense for now
    
    * Update invalid release notes error message
    
    * Remove pending spec for now
    tagboola authored Jul 25, 2023
    Copy the full SHA
    b0fd460 View commit details

Commits on Jul 26, 2023

  1. Copy the full SHA
    f3fa2f1 View commit details
  2. Copy the full SHA
    3312755 View commit details
  3. Copy the full SHA
    89eab0b View commit details

Commits on Jul 31, 2023

  1. Bump version to 0.7.0

    rebehe committed Jul 31, 2023
    Copy the full SHA
    84fbc4a View commit details

Commits on Aug 1, 2023

  1. Merge pull request #329 from firebase/bump-version-to-0-7-0

    Bump version to 0.7.0
    rebehe authored Aug 1, 2023
    Copy the full SHA
    a62e57b View commit details

Commits on Aug 2, 2023

  1. Copy the full SHA
    30ea5a1 View commit details
Showing with 2,163 additions and 1,685 deletions.
  1. +0 −67 .circleci/config.yml
  2. +33 −0 .github/workflows/release.yml
  3. +35 −0 .github/workflows/ruby.yml
  4. +4 −5 .rubocop.yml
  5. +1 −1 .tool-versions
  6. +0 −1 Gemfile
  7. +3 −0 fastlane-plugin-firebase_app_distribution.gemspec
  8. BIN lib/.DS_Store
  9. +429 −78 lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb
  10. +68 −7 ...fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_add_testers_action.rb
  11. +113 −0 ...astlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_create_group_action.rb
  12. +93 −0 ...astlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_delete_group_action.rb
  13. +65 −12 ...fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_get_latest_release.rb
  14. +32 −10 lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_get_udids.rb
  15. +0 −121 lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_login.rb
  16. +67 −11 ...tlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_remove_testers_action.rb
  17. +0 −42 lib/fastlane/plugin/firebase_app_distribution/client/aab_info.rb
  18. +0 −16 lib/fastlane/plugin/firebase_app_distribution/client/error_response.rb
  19. +0 −339 lib/fastlane/plugin/firebase_app_distribution/client/firebase_app_distribution_api_client.rb
  20. +48 −0 lib/fastlane/plugin/firebase_app_distribution/helper/firebase_app_distribution_apis.rb
  21. +56 −30 lib/fastlane/plugin/firebase_app_distribution/helper/firebase_app_distribution_auth_client.rb
  22. +21 −18 lib/fastlane/plugin/firebase_app_distribution/helper/firebase_app_distribution_error_message.rb
  23. +82 −7 lib/fastlane/plugin/firebase_app_distribution/helper/firebase_app_distribution_helper.rb
  24. +0 −65 lib/fastlane/plugin/firebase_app_distribution/helper/upload_status_response.rb
  25. +1 −1 lib/fastlane/plugin/firebase_app_distribution/version.rb
  26. +369 −79 spec/firebase_app_distribution_action_spec.rb
  27. +121 −7 spec/firebase_app_distribution_add_testers_action_spec.rb
  28. +0 −644 spec/firebase_app_distribution_api_client_spec.rb
  29. +98 −61 spec/firebase_app_distribution_auth_client_spec.rb
  30. +72 −0 spec/firebase_app_distribution_create_group_action_spec.rb
  31. +47 −0 spec/firebase_app_distribution_delete_group_action_spec.rb
  32. +68 −7 spec/firebase_app_distribution_get_latest_release_spec.rb
  33. +44 −37 spec/firebase_app_distribution_get_udids_spec.rb
  34. +90 −4 spec/firebase_app_distribution_helper_spec.rb
  35. +103 −15 spec/firebase_app_distribution_remove_testers_action_spec.rb
67 changes: 0 additions & 67 deletions .circleci/config.yml

This file was deleted.

33 changes: 33 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Build and publish to RubyGems

on:
# Run this workflow manually from the Actions tab.
workflow_dispatch:
inputs:
rubygems_otp_token:
description: 'OTP token for RubyGems'
required: true

jobs:
build:
runs-on: ubuntu-latest
permissions:
contents: read
packages: write

steps:
- uses: actions/checkout@v3

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.0

- name: Publish to RubyGems
run: |
mkdir -p $HOME/.gem
touch $HOME/.gem/credentials
chmod 0600 $HOME/.gem/credentials
printf -- "---\n:rubygems_api_key: ${{ secrets.RUBYGEMS_API_KEY }}\n" > $HOME/.gem/credentials
gem build *.gemspec
gem push *.gem --otp ${{ inputs.rubygems_otp_token }}
35 changes: 35 additions & 0 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# This workflow uses actions that are not certified by GitHub.
# They are provided by a third-party and are governed by
# separate terms of service, privacy policy, and support
# documentation.
# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby

name: Ruby

on:
push:
branches: [ "master" ]
pull_request:
branches: [ "master" ]

permissions:
contents: read

jobs:
test:

runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['2.7', '3.0']

steps:
- uses: actions/checkout@v3
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- name: Run tests
run: bundle exec rake
9 changes: 4 additions & 5 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
---
require:
- rubocop/require_tools
Style/MultipleComparison:
Enabled: false
Style/PercentLiteralDelimiters:
@@ -99,7 +101,7 @@ Metrics/LineLength:
Metrics/ParameterLists:
Max: 17
Metrics/PerceivedComplexity:
Max: 18
Max: 20
Style/GuardClause:
Enabled: false
Style/StringLiterals:
@@ -121,7 +123,7 @@ Layout/SpaceAroundOperators:
Exclude:
- "**/spec/actions_specs/xcodebuild_spec.rb"
AllCops:
TargetRubyVersion: 2.0
TargetRubyVersion: 2.3
Include:
- "*/lib/assets/*Template"
- "*/lib/assets/*TemplateAndroid"
@@ -152,9 +154,6 @@ Style/IfInsideElse:
Enabled: false
Style/CollectionMethods:
Enabled: false
CrossPlatform/ForkUsage:
Exclude:
- "**/plugins/template/**/*"
Style/MethodCallWithArgsParentheses:
Enabled: true
IgnoredMethods:
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ruby 2.7.6
ruby 3.0.6
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
source('https://rubygems.org')

gemspec
gem 'google-api-client', '~> 0.38'

plugins_path = File.join(File.dirname(__FILE__), 'fastlane', 'Pluginfile')
eval_gemfile(plugins_path) if File.exist?(plugins_path)
3 changes: 3 additions & 0 deletions fastlane-plugin-firebase_app_distribution.gemspec
Original file line number Diff line number Diff line change
@@ -18,6 +18,9 @@ Gem::Specification.new do |spec|
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ['lib']

spec.add_dependency('google-apis-firebaseappdistribution_v1', '~> 0.3.0')
spec.add_dependency('google-apis-firebaseappdistribution_v1alpha', '~> 0.2.0')

spec.add_development_dependency('pry')
spec.add_development_dependency('bundler')
spec.add_development_dependency('rspec')
Binary file removed lib/.DS_Store
Binary file not shown.
Loading