FirebaseException "unable to resolve host" should be a FirebaseNetworkException

[edenman]

Step 2: Describe your environment

• Android Studio version: Android Studio Arctic Fox | 2020.3.1 Canary 2
• Firebase Component: Auth
• Component version: 20.0.0

Step 3: Describe the problem

getIdToken is passing this FirebaseException to the failure listener of getIdToken. The message clearly indicates it's a network issue, it would be better if the exception were a FirebaseNetworkException (I auto-retry on FirebaseNetworkException)

Steps to reproduce:

Not sure, I got this stacktrace report via Sentry.

Relevant Code:

com.google.firebase.FirebaseException: An internal error has occurred. [ Unable to resolve host "securetoken.googleapis.com":No address associated with hostname ]
	at com.google.firebase.auth.api.internal.zzem.zza(com.google.firebase:firebase-auth@@20.0.0:18)
	at com.google.firebase.auth.api.internal.zzfx.zza(com.google.firebase:firebase-auth@@20.0.0:21)
	at com.google.firebase.auth.api.internal.zzfq.zza(com.google.firebase:firebase-auth@@20.0.0:35)
	at com.google.firebase.auth.api.internal.zzfs.zza(com.google.firebase:firebase-auth@@20.0.0:74)
	at com.google.firebase.auth.api.internal.zzel.zza(com.google.firebase:firebase-auth@@20.0.0:61)
	at com.google.firebase.auth.api.internal.zzc.zza(com.google.firebase:firebase-auth@@20.0.0:3)
	at com.google.firebase.auth.api.internal.zzgb.zza(com.google.firebase:firebase-auth@@20.0.0:37)
	at com.google.firebase.auth.api.internal.zzfn.zza(com.google.firebase:firebase-auth@@20.0.0:41)
	at com.google.firebase.auth.api.internal.zza.zza(com.google.firebase:firebase-auth@@20.0.0:8)
	at com.google.firebase.auth.api.internal.zzep.zza(com.google.firebase:firebase-auth@@20.0.0:76)
	at com.google.firebase.auth.api.internal.zzbr.zza(com.google.firebase:firebase-auth@@20.0.0:24)
	at com.google.firebase.auth.api.internal.zzbq.accept(Unknown Source:6)
	at com.google.android.gms.common.api.internal.zacj.doExecute(com.google.android.gms:play-services-base@@17.1.0:2)
	at com.google.android.gms.common.api.internal.zaf.zac(com.google.android.gms:play-services-base@@17.1.0:6)
	at com.google.android.gms.common.api.internal.GoogleApiManager$zaa.zac(com.google.android.gms:play-services-base@@17.1.0:167)
	at com.google.android.gms.common.api.internal.GoogleApiManager$zaa.zab(com.google.android.gms:play-services-base@@17.1.0:139)
	at com.google.android.gms.common.api.internal.GoogleApiManager$zaa.zabg(com.google.android.gms:play-services-base@@17.1.0:99)
	at com.google.android.gms.common.api.internal.GoogleApiManager$zaa.zabe(com.google.android.gms:play-services-base@@17.1.0:40)
	at com.google.android.gms.common.api.internal.GoogleApiManager$zaa.onConnected(com.google.android.gms:play-services-base@@17.1.0:19)
	at com.google.android.gms.common.internal.zaf.onConnected(com.google.android.gms:play-services-base@@17.1.0:2)
	at com.google.android.gms.common.internal.BaseGmsClient$zzg.zzj(com.google.android.gms:play-services-basement@@17.1.1:24)
	at com.google.android.gms.common.internal.BaseGmsClient$zza.zza(com.google.android.gms:play-services-basement@@17.1.1:12)
	at com.google.android.gms.common.internal.BaseGmsClient$zzb.zzo(com.google.android.gms:play-services-basement@@17.1.1:11)
	at com.google.android.gms.common.internal.BaseGmsClient$zzc.handleMessage(com.google.android.gms:play-services-basement@@17.1.1:49)
	at android.os.Handler.dispatchMessage(Handler.java:107)
	at com.google.android.gms.internal.common.zzi.dispatchMessage(com.google.android.gms:play-services-basement@@17.1.1:8)
	at android.os.Looper.loop(Looper.java:237)
	at android.os.HandlerThread.run(HandlerThread.java:67)

[google-oss-bot]

I found a few problems with this issue:

• I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
• This issue does not seem to follow the issue template. Make sure you provide all the required information.

[sdelaysam]

Same happens in Airplane mode (not my link)
https://stackoverflow.com/questions/57780604/firebase-throwing-firebaseexception-instead-of-firebasenetworkexception-when-the
Support is trying to convince me that this is ok 👎

[malcolmdeck]

I've filed b/176825910 to track work on this internally - you're right, this should be a network exception. I'm hoping that this will be a quick fix :)

[savv]

The following are all error substrings that I get from firebase auth. If I understand correctly, they should all be mapped to an error code of 'auth/network-request-failed'. (Some of them might be from iOS.)

'A network error (such as timeout, interrupted connection or unreachable host) has occurred.'
'No address associated with hostname'
'Connection reset by peer'
'Software caused connection abort'
'Failed to connect to'

[mikehardy]

registering other direction of cross-link where we're watching invertase/react-native-firebase#4690

[malcolmdeck]

This fix was released in 20.0.3 - are we still seeing issues for this or similar stack traces? Otherwise I'll close it

[mikehardy]

Oh interesting - that's BoM 26.6.0 and the release notes don't indicate this was in there at all https://firebase.google.com/support/release-notes/android#bom_v26-6-0 ? So I had no reason to ask for reproduction again - I released react-native-firebase v11.0.0 which defaulted to BoM 26.6.0 on March 3rd though https://github.com/invertase/react-native-firebase/blob/master/CHANGELOG.md#1100-2021-03-03 right after your release so it should be "out there" amongst a large enough population of users to know

I'll ask - thanks