Skip to content

Commit 1e1b419

Browse files
LyokoneLyokone
committed
format
1 parent ff07e15 commit 1e1b419

File tree

5 files changed

+56
-117
lines changed

5 files changed

+56
-117
lines changed

‎analysis_options.yaml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ analyzer:
99
missing_required_param: error
1010
missing_return: error
1111
todo: ignore
12+
use_null_aware_elements: ignore
1213

1314
linter:
1415
rules:

‎example/basic/lib/main.dart‎

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -449,15 +449,14 @@ void main(List<String> args) async {
449449
});
450450

451451
// Storage onObjectMetadataUpdated - triggers when object metadata changes
452-
firebase.storage.onObjectMetadataUpdated(
453-
bucket: 'my-bucket',
454-
(event) async {
455-
final data = event.data;
456-
print('Object metadata updated in bucket: ${event.bucket}');
457-
print(' Name: ${data?.name}');
458-
print(' Metadata: ${data?.metadata}');
459-
},
460-
);
452+
firebase.storage.onObjectMetadataUpdated(bucket: 'my-bucket', (
453+
event,
454+
) async {
455+
final data = event.data;
456+
print('Object metadata updated in bucket: ${event.bucket}');
457+
print(' Name: ${data?.name}');
458+
print(' Metadata: ${data?.metadata}');
459+
});
461460

462461
// ==========================================================================
463462
// Scheduler trigger examples

‎lib/src/storage/storage_namespace.dart‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,7 @@ class StorageNamespace extends FunctionsNamespace {
168168
type.startsWith('google.cloud.storage.object.v1.');
169169

170170
static const _eventTypeArchived = 'google.cloud.storage.object.v1.archived';
171-
static const _eventTypeFinalized =
172-
'google.cloud.storage.object.v1.finalized';
171+
static const _eventTypeFinalized = 'google.cloud.storage.object.v1.finalized';
173172
static const _eventTypeDeleted = 'google.cloud.storage.object.v1.deleted';
174173
static const _eventTypeMetadataUpdated =
175174
'google.cloud.storage.object.v1.metadataUpdated';

‎test/snapshots/manifest_snapshot_test.dart‎

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1075,10 +1075,7 @@ void main() {
10751075
// =========================================================================
10761076

10771077
test('should have Storage onObjectFinalized trigger', () {
1078-
final dartFunc = _getEndpoint(
1079-
dartManifest,
1080-
'onObjectFinalized_mybucket',
1081-
);
1078+
final dartFunc = _getEndpoint(dartManifest, 'onObjectFinalized_mybucket');
10821079
final nodejsFunc = _getEndpoint(
10831080
nodejsManifest,
10841081
'onObjectFinalized_mybucket',
@@ -1117,10 +1114,7 @@ void main() {
11171114
});
11181115

11191116
test('should have Storage onObjectArchived trigger', () {
1120-
final dartFunc = _getEndpoint(
1121-
dartManifest,
1122-
'onObjectArchived_mybucket',
1123-
);
1117+
final dartFunc = _getEndpoint(dartManifest, 'onObjectArchived_mybucket');
11241118
final nodejsFunc = _getEndpoint(
11251119
nodejsManifest,
11261120
'onObjectArchived_mybucket',
@@ -1149,10 +1143,7 @@ void main() {
11491143
});
11501144

11511145
test('should have Storage onObjectDeleted trigger', () {
1152-
final dartFunc = _getEndpoint(
1153-
dartManifest,
1154-
'onObjectDeleted_mybucket',
1155-
);
1146+
final dartFunc = _getEndpoint(dartManifest, 'onObjectDeleted_mybucket');
11561147
final nodejsFunc = _getEndpoint(
11571148
nodejsManifest,
11581149
'onObjectDeleted_mybucket',

‎test/unit/storage_test.dart‎

Lines changed: 43 additions & 94 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,7 @@ void main() {
6969

7070
group('onObjectFinalized', () {
7171
test('registers function with firebase', () {
72-
storage.onObjectFinalized(
73-
bucket: 'my-bucket',
74-
(event) async {},
75-
);
72+
storage.onObjectFinalized(bucket: 'my-bucket', (event) async {});
7673

7774
expect(
7875
_findFunction(firebase, 'onObjectFinalized_mybucket'),
@@ -81,10 +78,7 @@ void main() {
8178
});
8279

8380
test('registered function is not external', () {
84-
storage.onObjectFinalized(
85-
bucket: 'my-bucket',
86-
(event) async {},
87-
);
81+
storage.onObjectFinalized(bucket: 'my-bucket', (event) async {});
8882

8983
final func = _findFunction(firebase, 'onObjectFinalized_mybucket')!;
9084
expect(func.external, isFalse);
@@ -93,12 +87,9 @@ void main() {
9387
test('handler receives StorageEvent with StorageObjectData', () async {
9488
StorageEvent? receivedEvent;
9589

96-
storage.onObjectFinalized(
97-
bucket: 'my-bucket',
98-
(event) async {
99-
receivedEvent = event;
100-
},
101-
);
90+
storage.onObjectFinalized(bucket: 'my-bucket', (event) async {
91+
receivedEvent = event;
92+
});
10293

10394
final func = _findFunction(firebase, 'onObjectFinalized_mybucket')!;
10495
final request = _createStorageRequest(
@@ -120,12 +111,9 @@ void main() {
120111
test('handler receives correct CloudEvent metadata', () async {
121112
StorageEvent? receivedEvent;
122113

123-
storage.onObjectFinalized(
124-
bucket: 'my-bucket',
125-
(event) async {
126-
receivedEvent = event;
127-
},
128-
);
114+
storage.onObjectFinalized(bucket: 'my-bucket', (event) async {
115+
receivedEvent = event;
116+
});
129117

130118
final func = _findFunction(firebase, 'onObjectFinalized_mybucket')!;
131119
final response = await func.handler(_createStorageRequest());
@@ -137,23 +125,17 @@ void main() {
137125
receivedEvent!.source,
138126
'//storage.googleapis.com/projects/_/buckets/my-bucket',
139127
);
140-
expect(
141-
receivedEvent!.type,
142-
'google.cloud.storage.object.v1.finalized',
143-
);
128+
expect(receivedEvent!.type, 'google.cloud.storage.object.v1.finalized');
144129
expect(receivedEvent!.specversion, '1.0');
145130
expect(receivedEvent!.subject, 'objects/path/to/file.txt');
146131
});
147132

148133
test('bucket getter returns correct bucket', () async {
149134
StorageEvent? receivedEvent;
150135

151-
storage.onObjectFinalized(
152-
bucket: 'my-bucket',
153-
(event) async {
154-
receivedEvent = event;
155-
},
156-
);
136+
storage.onObjectFinalized(bucket: 'my-bucket', (event) async {
137+
receivedEvent = event;
138+
});
157139

158140
final func = _findFunction(firebase, 'onObjectFinalized_mybucket')!;
159141
await func.handler(_createStorageRequest());
@@ -164,26 +146,17 @@ void main() {
164146

165147
group('onObjectArchived', () {
166148
test('registers function with firebase', () {
167-
storage.onObjectArchived(
168-
bucket: 'my-bucket',
169-
(event) async {},
170-
);
149+
storage.onObjectArchived(bucket: 'my-bucket', (event) async {});
171150

172-
expect(
173-
_findFunction(firebase, 'onObjectArchived_mybucket'),
174-
isNotNull,
175-
);
151+
expect(_findFunction(firebase, 'onObjectArchived_mybucket'), isNotNull);
176152
});
177153

178154
test('handler receives StorageEvent', () async {
179155
StorageEvent? receivedEvent;
180156

181-
storage.onObjectArchived(
182-
bucket: 'my-bucket',
183-
(event) async {
184-
receivedEvent = event;
185-
},
186-
);
157+
storage.onObjectArchived(bucket: 'my-bucket', (event) async {
158+
receivedEvent = event;
159+
});
187160

188161
final func = _findFunction(firebase, 'onObjectArchived_mybucket')!;
189162
final request = _createStorageRequest(
@@ -199,26 +172,17 @@ void main() {
199172

200173
group('onObjectDeleted', () {
201174
test('registers function with firebase', () {
202-
storage.onObjectDeleted(
203-
bucket: 'my-bucket',
204-
(event) async {},
205-
);
175+
storage.onObjectDeleted(bucket: 'my-bucket', (event) async {});
206176

207-
expect(
208-
_findFunction(firebase, 'onObjectDeleted_mybucket'),
209-
isNotNull,
210-
);
177+
expect(_findFunction(firebase, 'onObjectDeleted_mybucket'), isNotNull);
211178
});
212179

213180
test('handler receives StorageEvent', () async {
214181
StorageEvent? receivedEvent;
215182

216-
storage.onObjectDeleted(
217-
bucket: 'my-bucket',
218-
(event) async {
219-
receivedEvent = event;
220-
},
221-
);
183+
storage.onObjectDeleted(bucket: 'my-bucket', (event) async {
184+
receivedEvent = event;
185+
});
222186

223187
final func = _findFunction(firebase, 'onObjectDeleted_mybucket')!;
224188
final request = _createStorageRequest(
@@ -234,10 +198,7 @@ void main() {
234198

235199
group('onObjectMetadataUpdated', () {
236200
test('registers function with firebase', () {
237-
storage.onObjectMetadataUpdated(
238-
bucket: 'my-bucket',
239-
(event) async {},
240-
);
201+
storage.onObjectMetadataUpdated(bucket: 'my-bucket', (event) async {});
241202

242203
expect(
243204
_findFunction(firebase, 'onObjectMetadataUpdated_mybucket'),
@@ -248,15 +209,14 @@ void main() {
248209
test('handler receives StorageEvent with metadata', () async {
249210
StorageEvent? receivedEvent;
250211

251-
storage.onObjectMetadataUpdated(
252-
bucket: 'my-bucket',
253-
(event) async {
254-
receivedEvent = event;
255-
},
256-
);
212+
storage.onObjectMetadataUpdated(bucket: 'my-bucket', (event) async {
213+
receivedEvent = event;
214+
});
257215

258-
final func =
259-
_findFunction(firebase, 'onObjectMetadataUpdated_mybucket')!;
216+
final func = _findFunction(
217+
firebase,
218+
'onObjectMetadataUpdated_mybucket',
219+
)!;
260220
final request = _createStorageRequest(
261221
eventType: 'google.cloud.storage.object.v1.metadataUpdated',
262222
metadata: {'key1': 'value1', 'key2': 'value2'},
@@ -265,16 +225,16 @@ void main() {
265225

266226
expect(response.statusCode, 200);
267227
expect(receivedEvent, isNotNull);
268-
expect(receivedEvent!.data!.metadata, {'key1': 'value1', 'key2': 'value2'});
228+
expect(receivedEvent!.data!.metadata, {
229+
'key1': 'value1',
230+
'key2': 'value2',
231+
});
269232
});
270233
});
271234

272235
group('function naming', () {
273236
test('sanitizes bucket name by removing hyphens', () {
274-
storage.onObjectFinalized(
275-
bucket: 'my-test-bucket',
276-
(event) async {},
277-
);
237+
storage.onObjectFinalized(bucket: 'my-test-bucket', (event) async {});
278238

279239
expect(
280240
_findFunction(firebase, 'onObjectFinalized_mytestbucket'),
@@ -285,10 +245,7 @@ void main() {
285245

286246
group('error handling', () {
287247
test('returns 200 on success', () async {
288-
storage.onObjectFinalized(
289-
bucket: 'my-bucket',
290-
(event) async {},
291-
);
248+
storage.onObjectFinalized(bucket: 'my-bucket', (event) async {});
292249

293250
final func = _findFunction(firebase, 'onObjectFinalized_mybucket')!;
294251
final response = await func.handler(_createStorageRequest());
@@ -297,12 +254,9 @@ void main() {
297254
});
298255

299256
test('returns 500 on handler error', () async {
300-
storage.onObjectFinalized(
301-
bucket: 'my-bucket',
302-
(event) async {
303-
throw Exception('Handler error');
304-
},
305-
);
257+
storage.onObjectFinalized(bucket: 'my-bucket', (event) async {
258+
throw Exception('Handler error');
259+
});
306260

307261
final func = _findFunction(firebase, 'onObjectFinalized_mybucket')!;
308262
final response = await func.handler(_createStorageRequest());
@@ -313,10 +267,7 @@ void main() {
313267
});
314268

315269
test('returns 400 for invalid CloudEvent', () async {
316-
storage.onObjectFinalized(
317-
bucket: 'my-bucket',
318-
(event) async {},
319-
);
270+
storage.onObjectFinalized(bucket: 'my-bucket', (event) async {});
320271

321272
final func = _findFunction(firebase, 'onObjectFinalized_mybucket')!;
322273
final request = Request(
@@ -331,10 +282,7 @@ void main() {
331282
});
332283

333284
test('returns 400 for wrong event type', () async {
334-
storage.onObjectFinalized(
335-
bucket: 'my-bucket',
336-
(event) async {},
337-
);
285+
storage.onObjectFinalized(bucket: 'my-bucket', (event) async {});
338286

339287
final func = _findFunction(firebase, 'onObjectFinalized_mybucket')!;
340288
final request = Request(
@@ -388,7 +336,8 @@ void main() {
388336
'md5Hash': 'rL0Y20zC+Fzt72VPzMSk2A==',
389337
'mediaLink': 'https://storage.googleapis.com/download',
390338
'metadata': {'key1': 'value1'},
391-
'selfLink': 'https://storage.googleapis.com/storage/v1/b/test-bucket/o/file',
339+
'selfLink':
340+
'https://storage.googleapis.com/storage/v1/b/test-bucket/o/file',
392341
'size': '1024',
393342
'storageClass': 'STANDARD',
394343
'timeCreated': '2024-01-01T12:00:00Z',

0 commit comments

Comments
 (0)