Merge branch 'firebase:main' into JesusRojass/#14478

Author: JesusRojass

.github/CODEOWNERS

@@ -1,6 +1,6 @@
 ReleaseTooling/ @firebase/firebase-ios-sdk-admin
 FirebaseCore/ @firebase/firebase-ios-sdk-admin
-Package.swift @firebase/firebase-ios-sdk-admin
+/Package.swift @firebase/firebase-ios-sdk-admin
 Dangerfile @firebase/firebase-ios-sdk-admin
 **/Public @firebase/firebase-ios-sdk-admin
 *.podspec @firebase/firebase-ios-sdk-admin

CONTRIBUTING.md

@@ -132,7 +132,7 @@ To develop Firebase software, **install**:
    To install [clang-format] and [mint] using [Homebrew]:
 
     ```console
-    brew install clang-format@21
+    brew install clang-format@22
     brew install mint
     ```
 

Crashlytics/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 12.11.0
+- [fixed] Fixed an issue where Crashlytics API calls were silently dropped if invoked immediately after Firebase initialization.
+
 # 12.10.0
 - [fixed] Fixed a deadlock in Firebase Sessions where the main thread could
   block waiting for a lock held by a background thread during settings

Crashlytics/Crashlytics/Components/FIRCLSApplication.m

@@ -156,8 +156,8 @@ id FIRCLSApplicationSharedInstance(void) {
 #endif
 
 id<NSObject> FIRCLSApplicationBeginActivity(NSActivityOptions options, NSString* reason) {
-  if ([[NSProcessInfo processInfo] respondsToSelector:@selector(beginActivityWithOptions:
-                                                                                  reason:)]) {
+  if ([[NSProcessInfo processInfo]
+          respondsToSelector:@selector(beginActivityWithOptions:reason:)]) {
     return [[NSProcessInfo processInfo] beginActivityWithOptions:options reason:reason];
   }
 

Crashlytics/Crashlytics/Components/FIRCLSUserLogging.m

@@ -241,6 +241,8 @@ void FIRCLSUserLoggingRecordKeysAndValues(NSDictionary *keysAndValues,
                                           FIRCLSUserLoggingKVStorage *storage,
                                           uint32_t *counter) {
   if (!FIRCLSContextIsInitialized()) {
+    FIRCLSSDKLogWarn(
+        "Failed to write key/value pairs. Crashlytics context has not initialized yet.\n");
     return;
   }
 
@@ -317,6 +319,8 @@ static void FIRCLSUserLoggingWriteKeysAndValues(NSDictionary *keysAndValues,
 
 NSArray *FIRCLSUserLoggingStoredKeyValues(const char *path) {
   if (!FIRCLSContextIsInitialized()) {
+    FIRCLSSDKLogWarn(
+        "Failed to read key/value pairs. Crashlytics context has not initialized yet.\n");
     return nil;
   }
 
@@ -394,6 +398,7 @@ void FIRCLSUserLoggingRecordError(NSError *error,
   }
 
   if (!FIRCLSContextIsInitialized()) {
+    FIRCLSSDKLogWarn("Failed to record error. Crashlytics context has not initialized yet.\n");
     return;
   }
 

Crashlytics/Crashlytics/FIRCrashlytics.m

@@ -311,7 +311,10 @@ - (void)processDidCrashDuringPreviousExecution {
 
 #pragma mark - API: Logging
 - (void)log:(NSString *)msg {
-  FIRCLSLog(@"%@", msg);
+  [self waitForContextInit:@"log"
+                  callback:^{
+                    FIRCLSLog(@"%@", msg);
+                  }];
 }
 
 - (void)logWithFormat:(NSString *)format, ... {
@@ -354,17 +357,26 @@ - (void)deleteUnsentReports {
 
 #pragma mark - API: setUserID
 - (void)setUserID:(nullable NSString *)userID {
-  FIRCLSUserLoggingRecordInternalKeyValue(FIRCLSUserIdentifierKey, userID);
+  [self waitForContextInit:@"setUserID"
+                  callback:^{
+                    FIRCLSUserLoggingRecordInternalKeyValue(FIRCLSUserIdentifierKey, userID);
+                  }];
 }
 
 #pragma mark - API: setCustomValue
 
 - (void)setCustomValue:(nullable id)value forKey:(NSString *)key {
-  FIRCLSUserLoggingRecordUserKeyValue(key, value);
+  [self waitForContextInit:@"setCustomValue"
+                  callback:^{
+                    FIRCLSUserLoggingRecordUserKeyValue(key, value);
+                  }];
 }
 
 - (void)setCustomKeysAndValues:(NSDictionary *)keysAndValues {
-  FIRCLSUserLoggingRecordUserKeysAndValues(keysAndValues);
+  [self waitForContextInit:@"setCustomKeysAndValues"
+                  callback:^{
+                    FIRCLSUserLoggingRecordUserKeysAndValues(keysAndValues);
+                  }];
 }
 
 #pragma mark - API: Development Platform
@@ -414,19 +426,29 @@ - (void)recordError:(NSError *)error {
 
 - (void)recordError:(NSError *)error userInfo:(NSDictionary<NSString *, id> *)userInfo {
   NSString *rolloutsInfoJSON = [_remoteConfigManager getRolloutAssignmentsEncodedJsonString];
-  FIRCLSUserLoggingRecordError(error, userInfo, rolloutsInfoJSON);
+  [self waitForContextInit:@"recordError"
+                  callback:^{
+                    FIRCLSUserLoggingRecordError(error, userInfo, rolloutsInfoJSON);
+                  }];
 }
 
 - (void)recordExceptionModel:(FIRExceptionModel *)exceptionModel {
   NSString *rolloutsInfoJSON = [_remoteConfigManager getRolloutAssignmentsEncodedJsonString];
-  FIRCLSExceptionRecordModel(exceptionModel, rolloutsInfoJSON);
+  [self waitForContextInit:@"recordExceptionModel"
+                  callback:^{
+                    FIRCLSExceptionRecordModel(exceptionModel, rolloutsInfoJSON);
+                  }];
 }
 
 - (void)recordOnDemandExceptionModel:(FIRExceptionModel *)exceptionModel {
-  [self.managerData.onDemandModel
-      recordOnDemandExceptionIfQuota:exceptionModel
-           withDataCollectionEnabled:[self.dataArbiter isCrashlyticsCollectionEnabled]
-          usingExistingReportManager:self.existingReportManager];
+  [self waitForContextInit:@"recordOnDemandExceptionModel"
+                  callback:^{
+                    [self.managerData.onDemandModel
+                        recordOnDemandExceptionIfQuota:exceptionModel
+                             withDataCollectionEnabled:[self.dataArbiter
+                                                               isCrashlyticsCollectionEnabled]
+                            usingExistingReportManager:self.existingReportManager];
+                  }];
 }
 
 #pragma mark - FIRSessionsSubscriber
@@ -456,7 +478,7 @@ - (void)rolloutsStateDidChange:(FIRRolloutsState *_Nonnull)rolloutsState {
                                                     reportID:currentReportID];
 }
 
-#pragma mark - Private Helpsers
+#pragma mark - Private Helpers
 - (void)waitForContextInit:(NSString *)contextLog callback:(void (^)(void))callback {
   if (!_contextInitPromise) {
     FIRCLSErrorLog(@"Crashlytics method called before SDK was initialized: %@", contextLog);

Crashlytics/UnitTests/FIRCLSCompactUnwindTests.m

@@ -46,7 +46,7 @@ - (NSString*)resourcePath {
   NSBundle* bundle = SWIFTPM_MODULE_BUNDLE;
   return [bundle.resourcePath stringByAppendingPathComponent:@"Data"];
 #else
-  NSBundle *bundle = [NSBundle bundleForClass:[self class]];
+  NSBundle* bundle = [NSBundle bundleForClass:[self class]];
   return bundle.resourcePath;
 #endif
 }

Crashlytics/UnitTests/FIRCLSDwarfTests.m

@@ -46,7 +46,7 @@ - (NSString*)resourcePath {
   NSBundle* bundle = SWIFTPM_MODULE_BUNDLE;
   return [bundle.resourcePath stringByAppendingPathComponent:@"Data"];
 #else
-  NSBundle *bundle = [NSBundle bundleForClass:[self class]];
+  NSBundle* bundle = [NSBundle bundleForClass:[self class]];
   return bundle.resourcePath;
 #endif
 }

Firebase.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name             = 'Firebase'
-  s.version          = '12.10.0'
+  s.version          = '12.11.0'
   s.summary          = 'Firebase'
 
   s.description      = <<-DESC
@@ -36,14 +36,14 @@ Simplify your app development, grow your user base, and monetize more effectivel
     ss.ios.deployment_target = '15.0'
     ss.osx.deployment_target = '10.15'
     ss.tvos.deployment_target = '15.0'
-    ss.ios.dependency 'FirebaseAnalytics', '~> 12.10.0'
-    ss.osx.dependency 'FirebaseAnalytics', '~> 12.10.0'
-    ss.tvos.dependency 'FirebaseAnalytics', '~> 12.10.0'
+    ss.ios.dependency 'FirebaseAnalytics', '~> 12.11.0'
+    ss.osx.dependency 'FirebaseAnalytics', '~> 12.11.0'
+    ss.tvos.dependency 'FirebaseAnalytics', '~> 12.11.0'
     ss.dependency 'Firebase/CoreOnly'
   end
 
   s.subspec 'CoreOnly' do |ss|
-    ss.dependency 'FirebaseCore', '~> 12.10.0'
+    ss.dependency 'FirebaseCore', '~> 12.11.0'
     ss.source_files = 'CoreOnly/Sources/Firebase.h'
     ss.preserve_paths = 'CoreOnly/Sources/module.modulemap'
     if ENV['FIREBASE_POD_REPO_FOR_DEV_POD'] then
@@ -70,7 +70,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
 
   s.subspec 'ABTesting' do |ss|
     ss.dependency 'Firebase/CoreOnly'
-    ss.dependency 'FirebaseABTesting', '~> 12.10.0'
+    ss.dependency 'FirebaseABTesting', '~> 12.11.0'
     # Standard platforms PLUS watchOS.
     ss.ios.deployment_target = '15.0'
     ss.osx.deployment_target = '10.15'
@@ -80,13 +80,13 @@ Simplify your app development, grow your user base, and monetize more effectivel
 
   s.subspec 'AppDistribution' do |ss|
     ss.dependency 'Firebase/CoreOnly'
-    ss.ios.dependency 'FirebaseAppDistribution', '~> 12.10.0-beta'
+    ss.ios.dependency 'FirebaseAppDistribution', '~> 12.11.0-beta'
     ss.ios.deployment_target = '15.0'
   end
 
   s.subspec 'AppCheck' do |ss|
     ss.dependency 'Firebase/CoreOnly'
-    ss.dependency 'FirebaseAppCheck', '~> 12.10.0'
+    ss.dependency 'FirebaseAppCheck', '~> 12.11.0'
     ss.ios.deployment_target = '15.0'
     ss.osx.deployment_target = '10.15'
     ss.tvos.deployment_target = '15.0'
@@ -95,7 +95,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
 
   s.subspec 'Auth' do |ss|
     ss.dependency 'Firebase/CoreOnly'
-    ss.dependency 'FirebaseAuth', '~> 12.10.0'
+    ss.dependency 'FirebaseAuth', '~> 12.11.0'
     # Standard platforms PLUS watchOS.
     ss.ios.deployment_target = '15.0'
     ss.osx.deployment_target = '10.15'
@@ -105,7 +105,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
 
   s.subspec 'Crashlytics' do |ss|
     ss.dependency 'Firebase/CoreOnly'
-    ss.dependency 'FirebaseCrashlytics', '~> 12.10.0'
+    ss.dependency 'FirebaseCrashlytics', '~> 12.11.0'
     # Standard platforms PLUS watchOS.
     ss.ios.deployment_target = '15.0'
     ss.osx.deployment_target = '10.15'
@@ -115,7 +115,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
 
   s.subspec 'Database' do |ss|
     ss.dependency 'Firebase/CoreOnly'
-    ss.dependency 'FirebaseDatabase', '~> 12.10.0'
+    ss.dependency 'FirebaseDatabase', '~> 12.11.0'
     # Standard platforms PLUS watchOS 7.
     ss.ios.deployment_target = '15.0'
     ss.osx.deployment_target = '10.15'
@@ -125,15 +125,15 @@ Simplify your app development, grow your user base, and monetize more effectivel
 
   s.subspec 'Firestore' do |ss|
     ss.dependency 'Firebase/CoreOnly'
-    ss.dependency 'FirebaseFirestore', '~> 12.10.0'
+    ss.dependency 'FirebaseFirestore', '~> 12.11.0'
     ss.ios.deployment_target = '15.0'
     ss.osx.deployment_target = '10.15'
     ss.tvos.deployment_target = '15.0'
   end
 
   s.subspec 'Functions' do |ss|
     ss.dependency 'Firebase/CoreOnly'
-    ss.dependency 'FirebaseFunctions', '~> 12.10.0'
+    ss.dependency 'FirebaseFunctions', '~> 12.11.0'
     # Standard platforms PLUS watchOS.
     ss.ios.deployment_target = '15.0'
     ss.osx.deployment_target = '10.15'
@@ -143,20 +143,20 @@ Simplify your app development, grow your user base, and monetize more effectivel
 
   s.subspec 'InAppMessaging' do |ss|
     ss.dependency 'Firebase/CoreOnly'
-    ss.ios.dependency 'FirebaseInAppMessaging', '~> 12.10.0-beta'
-    ss.tvos.dependency 'FirebaseInAppMessaging', '~> 12.10.0-beta'
+    ss.ios.dependency 'FirebaseInAppMessaging', '~> 12.11.0-beta'
+    ss.tvos.dependency 'FirebaseInAppMessaging', '~> 12.11.0-beta'
     ss.ios.deployment_target = '15.0'
     ss.tvos.deployment_target = '15.0'
   end
 
   s.subspec 'Installations' do |ss|
     ss.dependency 'Firebase/CoreOnly'
-    ss.dependency 'FirebaseInstallations', '~> 12.10.0'
+    ss.dependency 'FirebaseInstallations', '~> 12.11.0'
   end
 
   s.subspec 'Messaging' do |ss|
     ss.dependency 'Firebase/CoreOnly'
-    ss.dependency 'FirebaseMessaging', '~> 12.10.0'
+    ss.dependency 'FirebaseMessaging', '~> 12.11.0'
     # Standard platforms PLUS watchOS.
     ss.ios.deployment_target = '15.0'
     ss.osx.deployment_target = '10.15'
@@ -166,7 +166,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
 
   s.subspec 'MLModelDownloader' do |ss|
     ss.dependency 'Firebase/CoreOnly'
-    ss.dependency 'FirebaseMLModelDownloader', '~> 12.10.0-beta'
+    ss.dependency 'FirebaseMLModelDownloader', '~> 12.11.0-beta'
     # Standard platforms PLUS watchOS.
     ss.ios.deployment_target = '15.0'
     ss.osx.deployment_target = '10.15'
@@ -176,15 +176,15 @@ Simplify your app development, grow your user base, and monetize more effectivel
 
   s.subspec 'Performance' do |ss|
     ss.dependency 'Firebase/CoreOnly'
-    ss.ios.dependency 'FirebasePerformance', '~> 12.10.0'
-    ss.tvos.dependency 'FirebasePerformance', '~> 12.10.0'
+    ss.ios.dependency 'FirebasePerformance', '~> 12.11.0'
+    ss.tvos.dependency 'FirebasePerformance', '~> 12.11.0'
     ss.ios.deployment_target = '15.0'
     ss.tvos.deployment_target = '15.0'
   end
 
   s.subspec 'RemoteConfig' do |ss|
     ss.dependency 'Firebase/CoreOnly'
-    ss.dependency 'FirebaseRemoteConfig', '~> 12.10.0'
+    ss.dependency 'FirebaseRemoteConfig', '~> 12.11.0'
     # Standard platforms PLUS watchOS.
     ss.ios.deployment_target = '15.0'
     ss.osx.deployment_target = '10.15'
@@ -194,7 +194,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
 
   s.subspec 'Storage' do |ss|
     ss.dependency 'Firebase/CoreOnly'
-    ss.dependency 'FirebaseStorage', '~> 12.10.0'
+    ss.dependency 'FirebaseStorage', '~> 12.11.0'
     # Standard platforms PLUS watchOS.
     ss.ios.deployment_target = '15.0'
     ss.osx.deployment_target = '10.15'

FirebaseABTesting.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name             = 'FirebaseABTesting'
-  s.version          = '12.10.0'
+  s.version          = '12.11.0'
   s.summary          = 'Firebase ABTesting'
 
   s.description      = <<-DESC
@@ -51,7 +51,7 @@ Firebase Cloud Messaging and Firebase Remote Config in your app.
   s.pod_target_xcconfig = {
     'HEADER_SEARCH_PATHS' => '"${PODS_TARGET_SRCROOT}"'
   }
-  s.dependency 'FirebaseCore', '~> 12.10.0'
+  s.dependency 'FirebaseCore', '~> 12.11.0'
 
   s.test_spec 'unit' do |unit_tests|
     unit_tests.scheme = { :code_coverage => true }