Skip to content

Commit 09508e9

Browse files
MarkDuckworthMarkDuckworth
committed
Merge branch 'main' of github.com:firebase/firebase-js-sdk into feat/pipelines
2 parents fb5df42 + feb2c9d commit 09508e9

File tree

445 files changed

+19920
-15694
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

445 files changed

+19920
-15694
lines changed

‎.changeset/chilly-parrots-remember.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@firebase/vertexai': minor
3+
---
4+
5+
Add `systemInstruction`, `tools`, and `generationConfig` to `CountTokensRequest`.

‎.changeset/config.json

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
"baseBranch": "main",
1111
"updateInternalDependencies": "patch",
1212
"ignore": [
13-
"firebase-namespace-integration-test",
1413
"firebase-firestore-integration-test",
1514
"firebase-messaging-integration-test",
1615
"firebase-compat-interop-test",

‎.changeset/floppy-schools-battle.md

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@firebase/performance': patch
3+
'firebase': patch
4+
---
5+
6+
Modify the retry mechanism to stop when remaining tries is less than or equal to zero, improving the robustness of the retry handling.

‎.changeset/large-pants-hide.md

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@firebase/firestore': patch
3+
'firebase': patch
4+
---
5+
6+
Use lazy encoding in UTF-8 encoded byte comparison for strings.

‎.changeset/nervous-timers-call.md

-5
This file was deleted.

‎.changeset/silver-jeans-sell.md

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@firebase/database-compat': patch
3+
'@firebase/database-types': patch
4+
'@firebase/database': patch
5+
---
6+
7+
Added non-null parent properties to ThenableReference

‎.changeset/six-toys-chew.md

-5
This file was deleted.

‎.changeset/stupid-apples-shave.md

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@firebase/vertexai': minor
3+
'firebase': minor
4+
---
5+
6+
Added missing `BlockReason` and `FinishReason` enum values.

‎.changeset/tall-peas-tell.md

-5
This file was deleted.

‎.changeset/tame-paws-nail.md

-53
This file was deleted.

‎.changeset/tasty-boxes-brake.md

-5
This file was deleted.

‎.changeset/tricky-actors-exercise.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@firebase/data-connect': patch
3+
---
4+
5+
Update requests to point to v1 backend endpoints instead of v1beta

‎.github/CODEOWNERS

+8-8
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ packages/messaging-interop-types @zwu52 @firebase/jssdk-global-approvers
3737
integration/messaging @zwu52 @firebase/jssdk-global-approvers
3838

3939
# Auth Code
40-
packages/auth @lisajian @Xiaoshouzi-gh @sam-gc @firebase/jssdk-global-approvers
41-
packages/auth-compat @lisajian @Xiaoshouzi-gh @sam-gc @firebase/jssdk-global-approvers
42-
packages/auth-types @lisajian @Xiaoshouzi-gh @sam-gc @firebase/jssdk-global-approvers
43-
packages/auth-interop-types @lisajian @Xiaoshouzi-gh @sam-gc @firebase/jssdk-global-approvers
40+
packages/auth @lisajian @Xiaoshouzi-gh @sam-gc @pashanka @mansisampat @nhienlam @firebase/jssdk-global-approvers
41+
packages/auth-compat @lisajian @Xiaoshouzi-gh @sam-gc @pashanka @mansisampat @nhienlam @firebase/jssdk-global-approvers
42+
packages/auth-types @lisajian @Xiaoshouzi-gh @sam-gc @pashanka @mansisampat @nhienlam @firebase/jssdk-global-approvers
43+
packages/auth-interop-types @lisajian @Xiaoshouzi-gh @sam-gc @pashanka @mansisampat @nhienlam @firebase/jssdk-global-approvers
4444

4545
# Testing Code
4646
packages/rules-unit-testing @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
@@ -51,9 +51,9 @@ packages/installations-compat @avolkovi @yoyomyo @firebase/jssdk-global-approver
5151
packages/installations-types @avolkovi @yoyomyo @firebase/jssdk-global-approvers
5252

5353
# Performance Code
54-
packages/performance @jposuna @firebase/jssdk-global-approvers
55-
packages/performance-compat @jposuna @firebase/jssdk-global-approvers
56-
packages/performance-types @jposuna @firebase/jssdk-global-approvers
54+
packages/performance @visumickey @firebase/jssdk-global-approvers
55+
packages/performance-compat @visumickey @firebase/jssdk-global-approvers
56+
packages/performance-types @visumickey @firebase/jssdk-global-approvers
5757

5858
# Analytics Code
5959
packages/analytics @hsubox76 @firebase/jssdk-global-approvers
@@ -72,7 +72,7 @@ packages/app-check-types @hsubox76 @firebase/jssdk-global-approvers
7272
packages/app-check-interop-types @hsubox76 @firebase/jssdk-global-approvers
7373

7474
# Documentation Changes
75-
packages/firebase/index.d.ts @egilmorez @firebase/jssdk-global-approvers
75+
packages/firebase/compat/index.d.ts @egilmorez @firebase/jssdk-global-approvers
7676
scripts/docgen/content-sources/ @egilmorez @firebase/jssdk-global-approvers
7777
docs-devsite/ @firebase/firebase-techwriters
7878

‎.github/workflows/canary-deploy.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
# Canary release script requires git history and tags.
3333
fetch-depth: 0
3434
- name: Set up Node (20)
35-
uses: actions/setup-node@v3
35+
uses: actions/setup-node@v4
3636
with:
3737
node-version: 22.10.0
3838
- name: Yarn install

‎.github/workflows/check-changeset.yml

+5-2
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,17 @@ jobs:
2828
name: Check changeset vs changed files
2929
runs-on: ubuntu-latest
3030

31+
permissions:
32+
pull-requests: write
33+
3134
steps:
3235
- name: Checkout Repo
3336
uses: actions/checkout@v4
3437
with:
3538
# This makes Actions fetch all Git history so check_changeset script can diff properly.
3639
fetch-depth: 0
3740
- name: Set up Node (20)
38-
uses: actions/setup-node@v3
41+
uses: actions/setup-node@v4
3942
with:
4043
node-version: 22.10.0
4144
- name: Yarn install
@@ -89,4 +92,4 @@ jobs:
8992
# Don't want it to throw before editing the comment.
9093
- name: Fail if checker script logged a blocking failure
9194
if: ${{steps.check-changeset.outputs.BLOCKING_FAILURE == 'true'}}
92-
run: exit 1
95+
run: exit 1

‎.github/workflows/check-docs.yml

+31-23
Original file line numberDiff line numberDiff line change
@@ -22,26 +22,34 @@ jobs:
2222
runs-on: ubuntu-latest
2323

2424
steps:
25-
- name: Checkout Repo
26-
uses: actions/checkout@v4
27-
with:
28-
# get all history for the diff
29-
fetch-depth: 0
30-
- name: Set up Node (20)
31-
uses: actions/setup-node@v3
32-
with:
33-
node-version: 22.10.0
34-
- name: Yarn install
35-
run: yarn
36-
- name: Run doc generation
37-
run: yarn docgen:all
38-
- name: Check for changes in docs-devsite dir (fail if so)
39-
run: |
40-
if [[ -n "$(git status docs-devsite --porcelain)" ]]; then
41-
echo "Unstaged changes detected:"
42-
git status -s
43-
exit 1
44-
fi
45-
- name: Reference documentation needs to be updated. See message below.
46-
if: ${{ failure() }}
47-
run: echo "Changes in this PR affect the reference docs. Run \`yarn docgen:all\` locally to regenerate docs and add them to this PR."
25+
- name: Checkout Repo
26+
uses: actions/checkout@v4
27+
with:
28+
# get all history for the diff
29+
fetch-depth: 0
30+
- name: Set up Node (20)
31+
uses: actions/setup-node@v4
32+
with:
33+
node-version: 22.10.0
34+
- name: Yarn install
35+
run: yarn
36+
- name: Run doc generation
37+
run: yarn docgen:all
38+
# Fail first if there are docs-devsite changes since running yarn docgen:all
39+
# will also regenerate any API report changes.
40+
- name: Check for changes in docs-devsite dir (fail if so)
41+
run: |
42+
if [[ -n "$(git status docs-devsite --porcelain)" ]]; then
43+
echo "Unstaged changes detected in docs-devsite/:"
44+
git status -s
45+
echo "Changes in this PR affect the reference docs or API reports. Run \`yarn docgen:all\` locally to regenerate the changed files and add them to this PR."
46+
exit 1
47+
fi
48+
- name: Check for changes in common/api-review dir (fail if so)
49+
run: |
50+
if [[ -n "$(git status common/api-review --porcelain)" ]]; then
51+
echo "Unstaged changes detected in api-report(s):"
52+
git status -s
53+
echo "Changes in this PR affect the API reports. Run \`yarn build\` locally to regenerate the API reports and add them to this PR."
54+
exit 1
55+
fi

‎.github/workflows/check-pkg-paths.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
# This makes Actions fetch all Git history so run-changed script can diff properly.
2929
fetch-depth: 0
3030
- name: Set up Node (20)
31-
uses: actions/setup-node@v3
31+
uses: actions/setup-node@v4
3232
with:
3333
node-version: 22.10.0
3434
- name: Yarn install

‎.github/workflows/check-vertexai-responses.yml

+41-32
Original file line numberDiff line numberDiff line change
@@ -19,36 +19,45 @@ on: pull_request
1919
jobs:
2020
check-version:
2121
runs-on: ubuntu-latest
22+
# Allow GITHUB_TOKEN to have write permissions
23+
permissions:
24+
contents: write
25+
pull-requests: write
2226
steps:
23-
- uses: actions/checkout@v4
24-
- name: Clone mock responses
25-
run: scripts/update_vertexai_responses.sh
26-
- name: Find cloned and latest versions
27-
run: |
28-
CLONED=$(git describe --tags)
29-
LATEST=$(git tag --sort=v:refname | tail -n1)
30-
echo "cloned_tag=$CLONED" >> $GITHUB_ENV
31-
echo "latest_tag=$LATEST" >> $GITHUB_ENV
32-
working-directory: packages/vertexai/test-utils/vertexai-sdk-test-data
33-
- name: Find comment from previous run if exists
34-
uses: peter-evans/find-comment@3eae4d37986fb5a8592848f6a574fdf654e61f9e
35-
id: fc
36-
with:
37-
issue-number: ${{github.event.number}}
38-
body-includes: Vertex AI Mock Responses Check
39-
- name: Comment on PR if newer version is available
40-
if: ${{env.cloned_tag != env.latest_tag && !steps.fc.outputs.comment-id}}
41-
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043
42-
with:
43-
issue-number: ${{github.event.number}}
44-
body: >
45-
### Vertex AI Mock Responses Check :warning:
46-
47-
A newer major version of the mock responses for Vertex AI unit tests is available.
48-
[update_vertexai_responses.sh](https://github.com/firebase/firebase-js-sdk/blob/main/scripts/update_vertexai_responses.sh)
49-
should be updated to clone the latest version of the responses: `${{env.latest_tag}}`
50-
- name: Delete comment when version gets updated
51-
if: ${{env.cloned_tag == env.latest_tag && steps.fc.outputs.comment-id}}
52-
uses: detomarco/delete-comment@850734dd44d8b15fef55b45252613b903ceb06f0
53-
with:
54-
comment-id: ${{ steps.fc.outputs.comment-id }}
27+
- uses: actions/checkout@v4
28+
- name: Clone mock responses
29+
run: scripts/update_vertexai_responses.sh
30+
- name: Find cloned and latest versions
31+
run: |
32+
CLONED=$(git describe --tags)
33+
LATEST=$(git tag --sort=v:refname | tail -n1)
34+
echo "cloned_tag=$CLONED" >> $GITHUB_ENV
35+
echo "latest_tag=$LATEST" >> $GITHUB_ENV
36+
working-directory: packages/vertexai/test-utils/vertexai-sdk-test-data
37+
- name: Find comment from previous run if exists
38+
uses: peter-evans/find-comment@v3
39+
id: fc
40+
with:
41+
issue-number: ${{github.event.number}}
42+
body-includes: Vertex AI Mock Responses Check
43+
- name: Comment on PR if newer version is available
44+
if: ${{env.cloned_tag != env.latest_tag && !steps.fc.outputs.comment-id}}
45+
uses: peter-evans/create-or-update-comment@v4
46+
with:
47+
issue-number: ${{github.event.number}}
48+
body: >
49+
### Vertex AI Mock Responses Check :warning:
50+
51+
A newer major version of the mock responses for Vertex AI unit tests is available.
52+
[update_vertexai_responses.sh](https://github.com/firebase/firebase-js-sdk/blob/main/scripts/update_vertexai_responses.sh)
53+
should be updated to clone the latest version of the responses: `${{env.latest_tag}}`
54+
- name: Delete comment when version gets updated
55+
if: ${{env.cloned_tag == env.latest_tag && steps.fc.outputs.comment-id}}
56+
uses: actions/github-script@v7
57+
with:
58+
script: |
59+
github.rest.issues.deleteComment({
60+
owner: context.repo.owner,
61+
repo: context.repo.repo,
62+
comment_id: ${{ steps.fc.outputs.comment-id }},
63+
})

‎.github/workflows/deploy-config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
# This makes Actions fetch all Git history so run-changed script can diff properly.
3737
fetch-depth: 0
3838
- name: Set up node (20)
39-
uses: actions/setup-node@v3
39+
uses: actions/setup-node@v4
4040
with:
4141
node-version: 22.10.0
4242
- name: Yarn install

‎.github/workflows/e2e-test.yml

+6
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,12 @@ jobs:
5050
TEST_ACCOUNT: ${{ secrets.TEST_ACCOUNT }}
5151
run: |
5252
echo "export const config = $PROJECT_CONFIG; export const testAccount = $TEST_ACCOUNT" > firebase-config.js
53+
- name: Poll npm until version to test is available for install
54+
run: |
55+
echo "Polling npm for firebase@${{ github.event.client_payload.versionOrTag }}"
56+
node ../scripts/release/poll-npm-publish.js
57+
env:
58+
VERSION: ${{ github.event.client_payload.versionOrTag }}
5359
- name: Yarn install
5460
run: |
5561
echo "Installing firebase@${{ github.event.client_payload.versionOrTag }}"

‎.github/workflows/format.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
# get all history for the diff
3333
fetch-depth: 0
3434
- name: Set up node (20)
35-
uses: actions/setup-node@v3
35+
uses: actions/setup-node@v4
3636
with:
3737
node-version: 22.10.0
3838
- name: Yarn install

‎.github/workflows/health-metrics-pull-request.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ jobs:
3838
if: (github.event_name == 'push' || !(github.event.pull_request.head.repo.fork)) && (github.actor != 'dependabot[bot]')
3939
runs-on: ubuntu-latest
4040
steps:
41-
- uses: actions/checkout@v3
42-
- uses: actions/setup-node@v3
41+
- uses: actions/checkout@v4
42+
- uses: actions/setup-node@v4
4343
with:
4444
node-version: 22.10.0
4545
- uses: 'google-github-actions/auth@v0'
@@ -55,8 +55,8 @@ jobs:
5555
if: (github.event_name == 'push' || !(github.event.pull_request.head.repo.fork)) && (github.actor != 'dependabot[bot]')
5656
runs-on: ubuntu-latest
5757
steps:
58-
- uses: actions/checkout@v3
59-
- uses: actions/setup-node@v3
58+
- uses: actions/checkout@v4
59+
- uses: actions/setup-node@v4
6060
with:
6161
node-version: 22.10.0
6262
- uses: 'google-github-actions/auth@v0'

0 commit comments

Comments
 (0)