Pin runtimes on init for functions.

Author: taeold

src/deploy/functions/runtimes/supported/types.ts

@@ -116,3 +116,5 @@ export type DecommissionedRuntime = {
     ? R
     : never;
 }[keyof typeof RUNTIMES];
+
+export type ActiveRuntime = Exclude<Runtime, DecommissionedRuntime>;

src/firebaseConfig.ts

@@ -7,7 +7,7 @@
 
 import type { HttpsOptions } from "firebase-functions/v2/https";
 import { IngressSetting, MemoryOption, VpcEgressSetting } from "firebase-functions/v2/options";
-import { Runtime, DecommissionedRuntime } from "./deploy/functions/runtimes/supported/types";
+import { ActiveRuntime } from "./deploy/functions/runtimes/supported/types";
 
 /**
  * Creates a type that requires at least one key to be present in an interface
@@ -167,7 +167,7 @@ export type FirestoreConfig = FirestoreSingle | FirestoreMultiple;
 export type FunctionConfig = {
   source?: string;
   ignore?: string[];
-  runtime?: Exclude<Runtime, DecommissionedRuntime>;
+  runtime?: ActiveRuntime;
   codebase?: string;
 } & Deployable;
 

src/init/features/functions/index.ts

@@ -14,6 +14,7 @@ import {
 } from "../../../functions/projectConfig";
 import { FirebaseError } from "../../../error";
 import { functionsOrigin, runtimeconfigOrigin } from "../../../api";
+import * as supported from "../../../deploy/functions/runtimes/supported";
 
 const MAX_ATTEMPTS = 5;
 
@@ -198,6 +199,9 @@ async function languageSetup(setup: any, config: Config): Promise<any> {
       break;
     case "python":
       cbconfig.ignore = ["venv", ".git", "firebase-debug.log", "firebase-debug.*.log", "*.local"];
+      // In practical sense, latest supported runtime will not be a decomissioned runtime,
+      // but in theory this doesn't have to be the case.
+      cbconfig.runtime = supported.latest("python") as supported.ActiveRuntime;
       break;
   }
   setup.functions.languageChoice = language;

src/init/features/functions/javascript.ts

@@ -2,6 +2,7 @@ import { askInstallDependencies } from "./npm-dependencies";
 import { confirm } from "../../../prompt";
 import { configForCodebase } from "../../../functions/projectConfig";
 import { readTemplateSync } from "../../../templates";
+import * as supported from "../../../deploy/functions/runtimes/supported";
 
 const INDEX_TEMPLATE = readTemplateSync("init/functions/javascript/index.js");
 const PACKAGE_LINTING_TEMPLATE = readTemplateSync("init/functions/javascript/package.lint.json");
@@ -20,13 +21,19 @@ export async function setup(setup: any, config: any): Promise<any> {
     cbconfig.predeploy = ['npm --prefix "$RESOURCE_DIR" run lint'];
     await config.askWriteProjectFile(
       `${setup.functions.source}/package.json`,
-      PACKAGE_LINTING_TEMPLATE,
+      PACKAGE_LINTING_TEMPLATE.replace(
+        "{{RUNTIME}}",
+        supported.latest("nodejs").replace("nodejs", ""),
+      ),
     );
     await config.askWriteProjectFile(`${setup.functions.source}/.eslintrc.js`, ESLINT_TEMPLATE);
   } else {
     await config.askWriteProjectFile(
       `${setup.functions.source}/package.json`,
-      PACKAGE_NO_LINTING_TEMPLATE,
+      PACKAGE_NO_LINTING_TEMPLATE.replace(
+        "{{RUNTIME}}",
+        supported.latest("nodejs").replace("nodejs", ""),
+      ),
     );
   }
 

src/init/features/functions/typescript.ts

@@ -2,6 +2,7 @@ import { askInstallDependencies } from "./npm-dependencies";
 import { confirm } from "../../../prompt";
 import { configForCodebase } from "../../../functions/projectConfig";
 import { readTemplateSync } from "../../../templates";
+import * as supported from "../../../deploy/functions/runtimes/supported";
 
 const PACKAGE_LINTING_TEMPLATE = readTemplateSync("init/functions/typescript/package.lint.json");
 const PACKAGE_NO_LINTING_TEMPLATE = readTemplateSync(
@@ -28,7 +29,10 @@ export async function setup(setup: any, config: any): Promise<any> {
     cbconfig.predeploy.push('npm --prefix "$RESOURCE_DIR" run build');
     await config.askWriteProjectFile(
       `${setup.functions.source}/package.json`,
-      PACKAGE_LINTING_TEMPLATE,
+      PACKAGE_LINTING_TEMPLATE.replace(
+        "{{RUNTIME}}",
+        supported.latest("nodejs").replace("nodejs", ""),
+      ),
     );
     await config.askWriteProjectFile(`${setup.functions.source}/.eslintrc.js`, ESLINT_TEMPLATE);
     // TODO: isn't this file out of date now?
@@ -40,7 +44,10 @@ export async function setup(setup: any, config: any): Promise<any> {
     cbconfig.predeploy.push('npm --prefix "$RESOURCE_DIR" run build');
     await config.askWriteProjectFile(
       `${setup.functions.source}/package.json`,
-      PACKAGE_NO_LINTING_TEMPLATE,
+      PACKAGE_NO_LINTING_TEMPLATE.replace(
+        "{{RUNTIME}}",
+        supported.latest("nodejs").replace("nodejs", ""),
+      ),
     );
   }
 

templates/init/functions/javascript/package.lint.json

@@ -10,7 +10,7 @@
     "logs": "firebase functions:log"
   },
   "engines": {
-    "node": "22"
+    "node": "{{RUNTIME}}"
   },
   "main": "index.js",
   "dependencies": {

templates/init/functions/javascript/package.nolint.json

@@ -9,7 +9,7 @@
     "logs": "firebase functions:log"
   },
   "engines": {
-    "node": "22"
+    "node": "{{RUNTIME}}"
   },
   "main": "index.js",
   "dependencies": {

templates/init/functions/typescript/package.lint.json

@@ -11,7 +11,7 @@
     "logs": "firebase functions:log"
   },
   "engines": {
-    "node": "22"
+    "node": "{{RUNTIME}}"
   },
   "main": "lib/index.js",
   "dependencies": {

templates/init/functions/typescript/package.nolint.json

@@ -10,7 +10,7 @@
     "logs": "firebase functions:log"
   },
   "engines": {
-    "node": "22"
+    "node": "{{RUNTIME}}"
   },
   "main": "lib/index.js",
   "dependencies": {
@@ -22,4 +22,4 @@
     "firebase-functions-test": "^3.1.0"
   },
   "private": true
-}
+}