chore: modernize \n- replace tslint with biome for linting and formatting- update dependencies- bump node version

Author: cabljac

extension.yaml

@@ -35,7 +35,7 @@ resources:
     properties:
       location: us-central1
       httpsTrigger: {}
-      runtime: "nodejs14"
+      runtime: "nodejs20"
 
 # Learn about the `params` field in the docs
 params:

functions/__tests__/bundle.test.ts

@@ -1,5 +1,5 @@
-import { buildQuery } from "../src/build_bundle";
 import * as admin from "firebase-admin";
+import { buildQuery } from "../src/build_bundle";
 
 describe("buildQuery", () => {
   let db: admin.firestore.Firestore;
@@ -22,7 +22,7 @@ describe("buildQuery", () => {
             collectionGroupQuery: true,
           },
           {},
-          {}
+          {},
         ),
         db.collectionGroup("test-coll") as admin.firestore.Query,
       ],
@@ -39,7 +39,7 @@ describe("buildQuery", () => {
             ],
           },
           {},
-          {}
+          {},
         ),
         db
           .collection("test-coll")
@@ -62,7 +62,7 @@ describe("buildQuery", () => {
             ],
           },
           {},
-          {}
+          {},
         ),
         db
           .collection("test-coll")
@@ -94,7 +94,7 @@ describe("buildQuery", () => {
             field: "field1",
             limit: 10,
             contains: ["a", "d", "e"],
-          }
+          },
         ),
         db
           .collection("test-coll")
@@ -126,7 +126,7 @@ describe("buildQuery", () => {
             otherField: "otherField",
             floatValue: 3.0,
             value: false,
-          }
+          },
         ),
         db
           .collection("test-coll")

functions/__tests__/functions.test.ts

@@ -1,5 +1,4 @@
 import * as admin from "firebase-admin";
-import axios from "axios";
 
 process.env.FIRESTORE_EMULATOR_HOST = "localhost:8080";
 process.env.FIREBASE_FIRESTORE_EMULATOR_ADDRESS = "localhost:8080";
@@ -30,7 +29,8 @@ describe("functions", () => {
   it("successfully returns a bundle with queries, documents and params combined", async () => {
     const bundleName = "documents-queries-params";
     const url = extUrl(bundleName);
-    const { data: bundle } = await axios(url);
+    const response = await fetch(url);
+    const bundle = await response.arrayBuffer();
 
     const [metadata, documentMetadata, document] =
       extractObjectfromBuffer(bundle);
@@ -49,7 +49,8 @@ describe("functions", () => {
   it("successfully returns a bundle using a query with a collection", async () => {
     const bundleName = "query-with-a-collection";
     const url = extUrl(bundleName);
-    const { data: bundle } = await axios(url);
+    const response = await fetch(url);
+    const bundle = await response.arrayBuffer();
 
     const [metadata, documentMetadata, document] =
       extractObjectfromBuffer(bundle);
@@ -68,7 +69,8 @@ describe("functions", () => {
   it("successfully returns a bundle using a query with a collection and condition", async () => {
     const bundleName = "query-with-a-collection-and-condition";
     const url = extUrl(bundleName);
-    const { data: bundle } = await axios(url);
+    const response = await fetch(url);
+    const bundle = await response.arrayBuffer();
 
     const [metadata, documentMetadata, document] =
       extractObjectfromBuffer(bundle);
@@ -87,7 +89,8 @@ describe("functions", () => {
   it("successfully returns a bundle using a query with a collection and where clause", async () => {
     const bundleName = "query-with-a-collection-and-condition";
     const url = extUrl(bundleName);
-    const { data: bundle } = await axios(url);
+    const response = await fetch(url);
+    const bundle = await response.arrayBuffer();
 
     const [metadata, documentMetadata, document] =
       extractObjectfromBuffer(bundle);
@@ -106,7 +109,8 @@ describe("functions", () => {
   xit("successfully returns a bundle using a query with a collection and multiple where clauses", async () => {
     const bundleName = "query-with-a-collection-and-multiple-where-conditions";
     const url = extUrl(bundleName);
-    const { data: bundle } = await axios(url);
+    const response = await fetch(url);
+    const bundle = await response.arrayBuffer();
 
     const [metadata, documentMetadata, document] =
       extractObjectfromBuffer(bundle);
@@ -125,7 +129,8 @@ describe("functions", () => {
   it("successfully returns a bundle using a document", async () => {
     const bundleName = "single-document";
     const url = extUrl(bundleName);
-    const { data: bundle } = await axios(url);
+    const response = await fetch(url);
+    const bundle = await response.arrayBuffer();
 
     const [metadata, documentMetadata, document] =
       extractObjectfromBuffer(bundle);
@@ -136,19 +141,20 @@ describe("functions", () => {
 
     /*** check document metadata */
     expect(documentMetadata.documentMetadata.name).toEqual(
-      "projects/demo-experimental/databases/(default)/documents/documents/document1"
+      "projects/demo-experimental/databases/(default)/documents/documents/document1",
     );
 
     /*** check document */
     expect(document.document.name).toEqual(
-      "projects/demo-experimental/databases/(default)/documents/documents/document1"
+      "projects/demo-experimental/databases/(default)/documents/documents/document1",
     );
   });
 
   it("successfully returns a bundle using multiple documents", async () => {
     const bundleName = "multiple-documents";
     const url = extUrl(bundleName);
-    const { data: bundle } = await axios(url);
+    const response = await fetch(url);
+    const bundle = await response.arrayBuffer();
 
     const [metadata, documentMetadata, document] =
       extractObjectfromBuffer(bundle);
@@ -172,7 +178,8 @@ describe("functions", () => {
   it("successfully returns a bundle using params", async () => {
     const bundleName = "query-with-param";
     const url = extUrl(bundleName) + "?name=document2";
-    const { data: bundle } = await axios(url);
+    const response = await fetch(url);
+    const bundle = await response.arrayBuffer();
 
     const [metadata, documentMetadata, document] =
       extractObjectfromBuffer(bundle);
@@ -191,7 +198,8 @@ describe("functions", () => {
   it("successfully returns a bundle using clientCache", async () => {
     const bundleName = "with-client-cache";
     const url = extUrl(bundleName);
-    const { data: bundle } = await axios(url);
+    const response = await fetch(url);
+    const bundle = await response.arrayBuffer();
 
     const [metadata, documentMetadata, document] =
       extractObjectfromBuffer(bundle);
@@ -204,7 +212,8 @@ describe("functions", () => {
   xit("successfully returns a bundle using serverCache", async () => {
     const bundleName = "with-server-cache";
     const url = extUrl(bundleName);
-    const { data: bundle } = await axios(url);
+    const response = await fetch(url);
+    const bundle = await response.arrayBuffer();
 
     const [metadata, documentMetadata, document] =
       extractObjectfromBuffer(bundle);
@@ -217,7 +226,8 @@ describe("functions", () => {
   xit("successfully returns a bundle using fileCache", async () => {
     const bundleName = "with-file-cache";
     const url = extUrl(bundleName);
-    const { data: bundle } = await axios(url);
+    const response = await fetch(url);
+    const bundle = await response.arrayBuffer();
 
     const [metadata, documentMetadata, document] =
       extractObjectfromBuffer(bundle);
@@ -230,7 +240,8 @@ describe("functions", () => {
   xit("successfully returns a request through a webiste hosted by Firebase", async () => {
     const bundleName = "documents-queries-params";
     const url = extHostedUrl(bundleName);
-    const { data: bundle } = await axios(url);
+    const response = await fetch(url);
+    const bundle = await response.arrayBuffer();
 
     const [metadata, documentMetadata, document] =
       extractObjectfromBuffer(bundle);
@@ -250,12 +261,7 @@ describe("functions", () => {
     const bundleName = "unknown-bundle";
     const url = extHostedUrl(bundleName);
 
-    return axios(url)
-      .then(() => {
-        fail("should not succeed");
-      })
-      .catch((ex) => {
-        expect(ex.response.status).toEqual(404);
-      });
+    const response = await fetch(url);
+    expect(response.status).toEqual(404);
   });
 });

functions/biome.json

@@ -0,0 +1,32 @@
+{
+  "$schema": "https://biomejs.dev/schemas/2.1.0/schema.json",
+  "vcs": {
+    "enabled": true,
+    "clientKind": "git",
+    "useIgnoreFile": true
+  },
+  "files": {
+    "ignoreUnknown": false,
+    "includes": ["src/**/*.ts", "__tests__/**/*.ts"]
+  },
+  "formatter": {
+    "enabled": true,
+    "indentStyle": "space",
+    "indentWidth": 2,
+    "lineWidth": 80
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true
+    }
+  },
+  "javascript": {
+    "formatter": {
+      "quoteStyle": "double"
+    }
+  },
+  "assist": {
+    "enabled": true
+  }
+}

functions/jest.config.js

@@ -1,14 +1,10 @@
-const packageJson = require("./package.json");
-
 module.exports = {
-  name: packageJson.name,
-  displayName: packageJson.name,
   rootDir: "./",
   preset: "ts-jest",
-  globals: {
-    "ts-jest": {
-      tsConfig: "<rootDir>/__tests__/tsconfig.json",
-    },
+  transform: {
+    "^.+\\.ts$": ["ts-jest", {
+      tsconfig: "<rootDir>/__tests__/tsconfig.json",
+    }],
   },
   testMatch: ["**/__tests__/*.test.ts"],
   testEnvironment: "node",