Skip to content

Commit 26a7d68

Browse files
committed
Merge branch 'firestore-pipelines-dart-api-v2' into firestore-pipelines-web
2 parents 84ef6a8 + 9dadc54 commit 26a7d68

File tree

2 files changed

+0
-47
lines changed

2 files changed

+0
-47
lines changed

packages/cloud_firestore/cloud_firestore/lib/src/pipeline_expression.dart

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -644,11 +644,6 @@ abstract class Expression implements PipelineSerializable {
644644
return _MapExpression(data.map((k, v) => MapEntry(k, _toExpression(v))));
645645
}
646646

647-
/// Creates a map expression from alternating key-value expressions
648-
static Expression mapFromPairs(List<Expression> keyValuePairs) {
649-
return _MapFromPairsExpression(keyValuePairs);
650-
}
651-
652647
/// Returns the current timestamp
653648
static Expression currentTimestamp() {
654649
return _CurrentTimestampExpression();
@@ -2848,26 +2843,6 @@ class _MapExpression extends FunctionExpression {
28482843
}
28492844
}
28502845

2851-
/// Represents a mapFromPairs expression
2852-
class _MapFromPairsExpression extends FunctionExpression {
2853-
final List<Expression> keyValuePairs;
2854-
2855-
_MapFromPairsExpression(this.keyValuePairs);
2856-
2857-
@override
2858-
String get name => 'map_from_pairs';
2859-
2860-
@override
2861-
Map<String, dynamic> toMap() {
2862-
return {
2863-
'name': name,
2864-
'args': {
2865-
'pairs': keyValuePairs.map((expr) => expr.toMap()).toList(),
2866-
},
2867-
};
2868-
}
2869-
}
2870-
28712846
/// Represents a raw function expression
28722847
class _RawFunctionExpression extends FunctionExpression {
28732848
final String functionName;

packages/cloud_firestore/cloud_firestore/pipeline_example/integration_test/pipeline/pipeline_expressions_e2e.dart

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -658,28 +658,6 @@ void runPipelineExpressionsTests() {
658658
expect(snapshot.result[0].data()!['mapped'], {'left': 1, 'right': 2});
659659
});
660660

661-
test(
662-
'addFields mapFromPairs',
663-
() async {
664-
final snapshot = await expressionsDocScore50(
665-
Expression.mapFromPairs([
666-
Expression.constant('k1'),
667-
Expression.constant(1),
668-
Expression.constant('k2'),
669-
Expression.constant('v2'),
670-
]).as('mapped_pairs'),
671-
);
672-
expectResultCount(snapshot, 1);
673-
expect(snapshot.result[0].data()!['mapped_pairs'], {
674-
'k1': 1,
675-
'k2': 'v2',
676-
});
677-
},
678-
skip:
679-
defaultTargetPlatform == TargetPlatform.android ||
680-
defaultTargetPlatform == TargetPlatform.iOS,
681-
);
682-
683661
test('addFields nullValue', () async {
684662
final snapshot = await expressionsDocScore50(
685663
Expression.nullValue().as('explicit_null'),

0 commit comments

Comments
 (0)