chore: update analysis options and refactor integration tests

Author: SelaseKay

packages/cloud_firestore/cloud_firestore/pipeline_example/analysis_options.yaml

@@ -9,6 +9,12 @@
 # packages, and plugins designed to encourage good coding practices.
 include: package:flutter_lints/flutter.yaml
 
+analyzer:
+  # Pipeline e2e tests uses firebase_options.dart injected in CI; exclude integration tests
+  # from analyze so analyze-ci passes.
+  exclude:
+    - integration_test/**
+
 linter:
   # The lint rules applied to this project can be customized in the
   # section below to disable rules from the `package:flutter_lints/flutter.yaml`

packages/cloud_firestore/cloud_firestore/pipeline_example/integration_test/pipeline/pipeline_add_fields_e2e.dart

@@ -14,27 +14,29 @@ void runPipelineAddFieldsTests() {
 
     setUpAll(() {
       firestore = FirebaseFirestore.instanceFor(
-          app: Firebase.app(), databaseId: 'firestore-pipeline-test');
+        app: Firebase.app(),
+        databaseId: 'firestore-pipeline-test',
+      );
     });
 
-    test('addFields with expression returns expected transformed data',
-        () async {
-      final snapshot = await firestore
-          .pipeline()
-          .collection('pipeline-e2e')
-          .where(Expression.field('test').equalValue('add-fields'))
-          .sort(Expression.field('title').ascending())
-          .addFields(
-            Expression.field('score').abs().as('abs_score'),
-          )
-          .limit(3)
-          .execute();
-      expectResultCount(snapshot, 3);
-      expectResultsData(snapshot, [
-        {'title': 'alpha', 'score': -7, 'abs_score': 7},
-        {'title': 'beta', 'score': 42, 'abs_score': 42},
-        {'title': 'gamma', 'score': 0, 'abs_score': 0},
-      ]);
-    });
+    test(
+      'addFields with expression returns expected transformed data',
+      () async {
+        final snapshot = await firestore
+            .pipeline()
+            .collection('pipeline-e2e')
+            .where(Expression.field('test').equalValue('add-fields'))
+            .sort(Expression.field('title').ascending())
+            .addFields(Expression.field('score').abs().as('abs_score'))
+            .limit(3)
+            .execute();
+        expectResultCount(snapshot, 3);
+        expectResultsData(snapshot, [
+          {'title': 'alpha', 'score': -7, 'abs_score': 7},
+          {'title': 'beta', 'score': 42, 'abs_score': 42},
+          {'title': 'gamma', 'score': 0, 'abs_score': 0},
+        ]);
+      },
+    );
   });
 }

packages/cloud_firestore/cloud_firestore/pipeline_example/integration_test/pipeline/pipeline_aggregate_e2e.dart

@@ -35,32 +35,36 @@ void runPipelineAggregateTests() {
       ]);
     });
 
-    test('aggregateWithOptions with groups returns one row per group',
-        () async {
-      final snapshot = await firestore
-          .pipeline()
-          .collection('pipeline-e2e')
-          .where(Expression.field('test').equalValue('aggregate'))
-          .aggregateWithOptions(
-            AggregateStageOptions(
-              accumulators: [
-                Expression.field('score').sum().as('total_score'),
-                CountAll().as('count'),
-              ],
-              groups: [Expression.field('category')],
-            ),
-          )
-          .execute();
-      expectResultCount(snapshot, 2);
-      final results = snapshot.result.map((r) => r.data()!).toList();
-      results.sort((a, b) =>
-          (a['category'] as String).compareTo(b['category'] as String));
-      expect(results[0]['category'], 'x');
-      expect(results[0]['total_score'], 30);
-      expect(results[0]['count'], 2);
-      expect(results[1]['category'], 'y');
-      expect(results[1]['total_score'], 70);
-      expect(results[1]['count'], 2);
-    });
+    test(
+      'aggregateWithOptions with groups returns one row per group',
+      () async {
+        final snapshot = await firestore
+            .pipeline()
+            .collection('pipeline-e2e')
+            .where(Expression.field('test').equalValue('aggregate'))
+            .aggregateWithOptions(
+              AggregateStageOptions(
+                accumulators: [
+                  Expression.field('score').sum().as('total_score'),
+                  CountAll().as('count'),
+                ],
+                groups: [Expression.field('category')],
+              ),
+            )
+            .execute();
+        expectResultCount(snapshot, 2);
+        final results = snapshot.result.map((r) => r.data()!).toList();
+        results.sort(
+          (a, b) =>
+              (a['category'] as String).compareTo(b['category'] as String),
+        );
+        expect(results[0]['category'], 'x');
+        expect(results[0]['total_score'], 30);
+        expect(results[0]['count'], 2);
+        expect(results[1]['category'], 'y');
+        expect(results[1]['total_score'], 70);
+        expect(results[1]['count'], 2);
+      },
+    );
   });
 }

packages/cloud_firestore/cloud_firestore/pipeline_example/integration_test/pipeline/pipeline_execute_options_e2e.dart

@@ -19,25 +19,19 @@ void runPipelineExecuteOptionsTests() {
       );
     });
 
-    test(
-      'execute with ExecuteOptions returns expected results',
-      () async {
-        final snapshot = await firestore
-            .pipeline()
-            .collection('pipeline-e2e')
-            .where(Expression.field('test').equalValue('add-fields'))
-            .sort(Expression.field('title').ascending())
-            .limit(2)
-            .execute(
-              options: const ExecuteOptions(
-                indexMode: IndexMode.recommended,
-              ),
-            );
-        expectResultCount(snapshot, 2);
-        expect(snapshot.result[0].data()!['title'], 'alpha');
-        expect(snapshot.result[1].data()!['title'], 'beta');
-      },
-      skip: true,
-    );
+    test('execute with ExecuteOptions returns expected results', () async {
+      final snapshot = await firestore
+          .pipeline()
+          .collection('pipeline-e2e')
+          .where(Expression.field('test').equalValue('add-fields'))
+          .sort(Expression.field('title').ascending())
+          .limit(2)
+          .execute(
+            options: const ExecuteOptions(indexMode: IndexMode.recommended),
+          );
+      expectResultCount(snapshot, 2);
+      expect(snapshot.result[0].data()!['title'], 'alpha');
+      expect(snapshot.result[1].data()!['title'], 'beta');
+    }, skip: true);
   });
 }