Addressed comments

Author: maneesht

packages/firebase_data_connect/firebase_data_connect/lib/src/common/dataconnect_error.dart

@@ -18,7 +18,7 @@ part of 'common_library.dart';
 enum DataConnectErrorCode { unavailable, unauthorized, other }
 
 /// Error thrown when DataConnect encounters an error.
-class DataConnectError<T> extends FirebaseException {
+class DataConnectError extends FirebaseException {
   DataConnectError(this.dataConnectErrorCode, String? message)
       : super(
           plugin: 'Data Connect',
@@ -29,11 +29,11 @@ class DataConnectError<T> extends FirebaseException {
 }
 
 /// Error thrown when an operation is partially successful.
-class DataConnectOperationError extends DataConnectError {
+class DataConnectOperationError<T> extends DataConnectError {
   DataConnectOperationError(
       DataConnectErrorCode code, String message, this.response)
       : super(code, message);
-  final DataConnectOperationFailureResponse response;
+  final DataConnectOperationFailureResponse<T> response;
 }
 
 /// Nested class containing errors and decoded data.
@@ -48,14 +48,20 @@ class DataConnectOperationFailureResponse<T> {
 class DataConnectOperationFailureResponseErrorInfo {
   DataConnectOperationFailureResponseErrorInfo(this.path, this.message);
   String message;
-  List<DataConnectOperationFailureErrorInfoPathSegment> path;
+  List<PathSegment> path;
 }
 
 /// Path where error occurred.
-class DataConnectOperationFailureErrorInfoPathSegment {
-  DataConnectOperationFailureErrorInfoPathSegment({this.field, this.listIndex});
-  String? field;
-  int? listIndex;
+sealed class PathSegment {}
+
+class StringValue extends PathSegment {
+  final String value;
+  StringValue(this.value);
+}
+
+class IntValue extends PathSegment {
+  final int value;
+  IntValue(this.value);
 }
 
 typedef Serializer<Variables> = String Function(Variables vars);

packages/firebase_data_connect/firebase_data_connect/lib/src/network/grpc_transport.dart

@@ -180,10 +180,8 @@ Data handleResponse<Data>(CommonResponse<Data> commonResponse) {
         .map((e) => DataConnectOperationFailureResponseErrorInfo(
             e.path.values
                 .map((val) => val.hasStringValue()
-                    ? DataConnectOperationFailureErrorInfoPathSegment(
-                        field: val.stringValue)
-                    : DataConnectOperationFailureErrorInfoPathSegment(
-                        listIndex: val.numberValue.toInt()))
+                    ? StringValue(val.stringValue)
+                    : IntValue(val.numberValue.toInt()))
                 .toList(),
             e.message))
         .toList();

packages/firebase_data_connect/firebase_data_connect/lib/src/network/rest_transport.dart

@@ -150,10 +150,8 @@ class RestTransport implements DataConnectTransport {
             .map((e) => DataConnectOperationFailureResponseErrorInfo(
                 (e['path'] as List)
                     .map((val) => val.runtimeType == String
-                        ? DataConnectOperationFailureErrorInfoPathSegment(
-                            field: val)
-                        : DataConnectOperationFailureErrorInfoPathSegment(
-                            listIndex: val))
+                        ? StringValue(val)
+                        : IntValue(val))
                     .toList(),
                 e['message']))
             .toList();

packages/firebase_data_connect/firebase_data_connect/test/src/network/rest_transport_test.dart

@@ -422,7 +422,8 @@ void main() {
             e.response.data!['abc'] == 'def' &&
             e.response.errors.first.message ==
                 'SQL query error: pq: duplicate key value violates unique constraint movie_pkey' &&
-            e.response.errors.first.path[0].field == 'the_matrix' &&
+            (e.response.errors.first.path[0] as StringValue).value ==
+                'the_matrix' &&
             e.response.decodedData is AbcHolder &&
             (e.response.decodedData as AbcHolder).abc == 'def')),
       );