Optimize install/attach/detach of firebug logger actor

[janodvarko]

The front (client) should attach Firebug logger actor only when necessary. It should be attached only when the server side logging options are on (at least one) and detached again when it's all off.

Further, the registration (installation) of the actor should not happen until the actor is actually needed. If the server logging options are off by default the actor should not even be registered. The installation should happen the first time the user actually sets any of the server side logging.

Honza

[janodvarko]

@fflorent: Are you interested in this one...?

This will be great optimization (no overhead if users are not using the server side logging)

Honza

[janodvarko]

This is follow up for #108

Honza

[fflorent]

I understand the need. Also I see a drawback: the user may want to just filter the logs displayed without turning on/off the feature.

How about having an option for the Console panel instead (enabled by default)?

Florent

[simonlindholm]

Enabled by default would be bad, IMO - you should not be punished (performance wise) by something you didn't notice existed. Adding an option is also confusing in that then we have two options for more or less the same thing.

Semi-related question: why is the remote logging included in the Firebug theme? Shouldn't it be separate? Then this question would mostly solve itself.

[fflorent]

Semi-related question: why is the remote logging included in the Firebug theme? Shouldn't it be separate? Then this question would mostly solve itself.

Good question. I think it would be fine to have it separately from the Firebug theme... Moreover, that could introduce what we are trying to do now (developing extensions and a theme) when we release Firebug.next. Honza?

Florent

[janodvarko]

Yes, I also think:

• there should be no overhead if off
• no additional option

Good question.

I am thinking about this a lot and I believe it's an advantage to have some features in Firebug 3. It's still not 100% clear what the list is in the end, but there are already some clear indications (the command editor or the DOM panel for example). The remote logging is basic and popular thing since it's in fact exposing the console API to the server side (big user base, remember all the extensions) and I believe it can fit in Firebug 3 nicely. Let's see, I'll try to gather some feedback yet.

Honza

[janodvarko]

The entire logger feature is now built-in Firefox

Honza