Display the full url for XHR requests in the console

[compojoom]

As mentioned in #358 it would be really good if the XHR requests that are being shown in the console have the complete url shown without having to hover or open the request to see the url.
This would help with navigation as on the same page we could have a lot of different XHR request (with different queries) and currently since we only show the domain name + path, we are missing on important information.

[fflorent]

Thanks for the report!

Florent

[fflorent]

Could be a good first bug. What do you think @janodvarko ?

Florent

[janodvarko]

Good point, label set.

Honza

[fflorent]

@josephmgonzalez would you be interested in that issue ?

Florent

[josephmgonzalez]

@fflorent This could be a possibility, could you give a little insight on how this should be done? I am newer to the project and don't really know where to find the issue.

[fflorent]

Sure. I am at work, I'll try to do that this evening.

Florent

[fflorent]

First, some resources:

• Setup your environment: The developer guide
• Since it plays with Domplate, you should take a look at these:
  • http://getfirebug.com/wiki/index.php/Domplate
  • http://www.softwareishard.com/blog/category/domplate/
• How to debug a debugger?... Well, fortunately there are tools for that :) :
  • https://github.com/firebug/firebug.next/wiki/Debugging-Firebug-Tips-&-Tricks
  • I personally use a lot the Browser Toolbox, and the FBTrace can also be useful to log things

So, what you need to do:

• Study a bit how the XHR logging part of Firebug works: https://github.com/firebug/firebug.next/tree/master/lib/console/xhr
• Probable entry point: https://github.com/firebug/firebug.next/blob/master/lib/console/xhr/xhr-spy.js#L142-L143
  • I guess this.url refer to a complete URL object. Just inspect it using either FBTrace or Browser Toolbox

As a first step, for now, you can try to just change the text correctly (.textContent = "...") as requested the issuer, in order to have the full URL. Also inspect the XHR logs using the Browser Toolbox or DOM Inspector.

Please, don't hesitate if you have any question.

Florent

[fflorent]

@janodvarko I complemented your developer guide :)

Florent