fix: respect IGNORE_PREDEFINED_VARS in .gitlab-ci-local-env (#1853)

Author: firecow

src/argv.ts

@@ -62,8 +62,8 @@ export class Argv {
         "variablesFile": ".gitlab-ci-local-variables.yml",
         "inputsFile": ".gitlab-ci-local-inputs.yml",
         "evaluateRuleChanges": true,
-        "ignoreSchemaPaths": [],
-        "ignorePredefinedVars": "",
+        "ignoreSchemaPaths": [] as string[],
+        "ignorePredefinedVars": [] as string[],
     };
 
     map: Map<string, any> = new Map<string, any>();
@@ -201,7 +201,10 @@ export class Argv {
     }
 
     get ignorePredefinedVars (): string[] {
-        return this.map.get("ignorePredefinedVars") ?? Argv.default.ignorePredefinedVars;
+        const val = this.map.get("ignorePredefinedVars");
+        if (Array.isArray(val)) return val;
+        if (typeof val === "string" && val.length > 0) return val.split(",");
+        return Argv.default.ignorePredefinedVars;
     }
 
     get pullPolicy (): string {

src/index.ts

@@ -344,7 +344,6 @@ process.on("SIGUSR2", async () => {
             type: "string",
             coerce: (v) => v.split(","),
             requiresArg: false,
-            default: Argv.default.ignorePredefinedVars,
             describe: "Comma-seperated list of predefined pipeline variables for which warnings should be suppressed",
         })
         .option("concurrency", {

tests/argv-input.test.ts

@@ -46,3 +46,16 @@ test("input namespace collision: same key as global and component name", async (
     expect(result._global["deploy"]).toEqual("prod");
     expect(result._components["deploy"]).toEqual({replicas: 5});
 });
+
+test("ignorePredefinedVars is loaded from .gitlab-ci-local-env", async () => {
+    const argv = await Argv.build({
+        cwd: "tests/test-cases/argv-dotenv-ignore-predefined-vars",
+        home: "tests/test-cases/argv-dotenv-ignore-predefined-vars",
+    }, writeStreams);
+    expect(argv.ignorePredefinedVars).toEqual(["CI_PIPELINE_SOURCE", "CI_PROJECT_NAME"]);
+});
+
+test("ignorePredefinedVars defaults to empty array", async () => {
+    const argv = await Argv.build({home: "tests/test-cases/argv-dotenv-ignore-predefined-vars"}, writeStreams);
+    expect(argv.ignorePredefinedVars).toEqual([]);
+});

tests/test-cases/argv-dotenv-ignore-predefined-vars/.gitlab-ci-local-env

@@ -0,0 +1 @@
+IGNORE_PREDEFINED_VARS=CI_PIPELINE_SOURCE,CI_PROJECT_NAME