Fix GCL_VARIABLE and array env vars not splitting multiple values

When setting array-type options via environment variables (e.g.
GCL_VARIABLE="VAR1=hello;VAR2=world"), yargs wraps the entire string
as a single array element. The getters checked for string type to
split, but since yargs already wrapped it as an array, no splitting
occurred.

Add splitArray helper that splits on semicolons for both string and
string[] inputs, and update all array-type getters to use it.

Fixes #992

Author: firecow

src/argv.ts

@@ -109,6 +109,12 @@ export class Argv {
         }
     }
 
+    private splitArray (val: string | string[] | undefined): string[] {
+        if (val == null) return [];
+        if (typeof val === "string") return val.split(";");
+        return val.flatMap((v: string) => v.split(";"));
+    }
+
     get cwd (): string {
         let cwd = this.map.get("cwd") ?? ".";
         assert(typeof cwd != "object", "--cwd option cannot be an array");
@@ -140,26 +146,23 @@ export class Argv {
     }
 
     get volume (): string[] {
-        const val = this.map.get("volume") ?? [];
-        return typeof val == "string" ? val.split(" ") : val;
+        return this.splitArray(this.map.get("volume"));
     }
 
     get network (): string[] {
-        const val = this.map.get("network") ?? [];
-        return typeof val == "string" ? val.split(" ") : val;
+        return this.splitArray(this.map.get("network"));
     }
 
     get extraHost (): string[] {
-        const val = this.map.get("extraHost") ?? [];
-        return typeof val == "string" ? val.split(" ") : val;
+        return this.splitArray(this.map.get("extraHost"));
     }
 
     get caFile (): string | null {
         return this.map.get("caFile") ?? null;
     }
 
     get ignoreSchemaPaths (): string[] {
-        return this.map.get("ignoreSchemaPaths") ?? Argv.default.ignoreSchemaPaths;
+        return this.splitArray(this.map.get("ignoreSchemaPaths"));
     }
 
     get ignorePredefinedVars (): string[] {
@@ -171,30 +174,26 @@ export class Argv {
     }
 
     get remoteVariables (): string[] {
-        const val = this.map.get("remoteVariables") ?? [];
-        return typeof val == "string" ? val.split(" ") : val;
+        return this.splitArray(this.map.get("remoteVariables"));
     }
 
     get variable (): {[key: string]: string} {
-        const val = this.map.get("variable");
         const variables: {[key: string]: string} = {};
-        const pairs = typeof val == "string" ? val.split(" ") : val;
-        (pairs ?? []).forEach((variablePair: string) => {
+        for (const variablePair of this.splitArray(this.map.get("variable"))) {
             const exec = /(?<key>\w*?)(=)(?<value>(.|\n|\r)*)/.exec(variablePair);
             if (exec?.groups?.key) {
                 variables[exec.groups.key] = exec?.groups?.value;
             }
-        });
+        }
         return variables;
     }
 
     get unsetVariables (): string[] {
-        return this.map.get("unsetVariable") ?? [];
+        return this.splitArray(this.map.get("unsetVariable"));
     }
 
     get manual (): string[] {
-        const val = this.map.get("manual") ?? [];
-        return typeof val == "string" ? val.split(" ") : val;
+        return this.splitArray(this.map.get("manual"));
     }
 
     get job (): string[] {
@@ -227,8 +226,7 @@ export class Argv {
     }
 
     get device (): string[] {
-        const val = this.map.get("device") ?? [];
-        return typeof val == "string" ? val.split(" ") : val;
+        return this.splitArray(this.map.get("device"));
     }
 
     get ulimit (): string | null {

tests/test-cases/cli-option-variables/integration.test.ts

@@ -25,3 +25,21 @@ line string`],
     ];
     expect(writeStreams.stdoutLines).toEqual(expect.arrayContaining(expected));
 });
+
+test("cli-option-variables semicolon-separated (GCL_VARIABLE env simulation)", async () => {
+    const writeStreams = new WriteStreamsMock();
+    await handler({
+        cwd: "tests/test-cases/cli-option-variables",
+        job: ["test-job"],
+        variable: ["CLI_VAR=hello world;CLI_VAR_DOT=dotdot", `CLI_MULTILINE=This is a multi
+line string`],
+    }, writeStreams);
+
+    const expected = [
+        chalk`{blueBright test-job} {greenBright >} hello world`,
+        chalk`{blueBright test-job} {greenBright >} dotdot`,
+        chalk`{blueBright test-job} {greenBright >} This is a multi`,
+        chalk`{blueBright test-job} {greenBright >} line string`,
+    ];
+    expect(writeStreams.stdoutLines).toEqual(expect.arrayContaining(expected));
+});