fix: respect --no-color and NO_COLOR - #1906
Merged
Merged
Conversation
The color guard checked argv.noColor, which yargs never sets: --no-color parses to color=false. It only worked because chalk sniffs process.argv itself, so FORCE_COLOR overrode it and NO_COLOR was ignored entirely.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The color guard checked
argv.noColor, which yargs never sets because--no-colorparses tocolor=false, so disabling color only worked via chalk's own argv sniffing, whichFORCE_COLORoverrides and which ignoresNO_COLORentirely.Summary by cubic
Fixes CLI color handling to respect --no-color and the NO_COLOR env var instead of relying on
chalkargv sniffing thatFORCE_COLORcan override. Colors disable when--no-coloris passed orNO_COLORis set, and stay enabled otherwise.argv.color === falseorprocess.env.NO_COLORis non-empty; keep it enabled by default and whenNO_COLORis empty.--no-color, andNO_COLORset/empty cases; type the savedchalklevel asColorSupportLevel.Written for commit fdd2152. Summary will update on new commits.