runtime: remove unused spad frame allocation

two-heart · ripatel-fd · commit ac2dd2217e54 · 2025-05-02T11:30:14.000Z
there is not spad_alloc in here anymore, so we can remove it. spad frame allocation are very expensive under deep asan
diff --git a/src/flamenco/runtime/fd_executor.c b/src/flamenco/runtime/fd_executor.c
@@ -842,8 +842,6 @@ fd_executor_validate_transaction_fee_payer( fd_exec_txn_ctx_t * txn_ctx ) {
 int
 fd_executor_setup_accessed_accounts_for_txn( fd_exec_txn_ctx_t * txn_ctx ) {
 
-  FD_SPAD_FRAME_BEGIN( txn_ctx->spad ) {
-
   txn_ctx->accounts_cnt = 0UL;
 
   fd_pubkey_t * tx_accs = (fd_pubkey_t *)((uchar *)txn_ctx->_txn_raw->raw + txn_ctx->txn_descriptor->acct_addr_off);
@@ -876,8 +874,6 @@ fd_executor_setup_accessed_accounts_for_txn( fd_exec_txn_ctx_t * txn_ctx ) {
     if( FD_UNLIKELY( err!=FD_RUNTIME_EXECUTE_SUCCESS ) ) return err;
   }
   return FD_RUNTIME_EXECUTE_SUCCESS;
-
-  } FD_SPAD_FRAME_END;
 }
 
 /* https://github.com/anza-xyz/agave/blob/c4b42ab045860d7b13b3912eafb30e6d2f4e593f/sdk/src/transaction_context.rs#L319-L357 */

Original file line number	Diff line number	Diff line change
`@@ -842,8 +842,6 @@ fd_executor_validate_transaction_fee_payer( fd_exec_txn_ctx_t * txn_ctx ) {`
`842`	`842`	`int`
`843`	`843`	`fd_executor_setup_accessed_accounts_for_txn( fd_exec_txn_ctx_t * txn_ctx ) {`
`844`	`844`
`845`		`- FD_SPAD_FRAME_BEGIN( txn_ctx->spad ) {`
`846`		`-`
`847`	`845`	`txn_ctx->accounts_cnt = 0UL;`
`848`	`846`
`849`	`847`	`fd_pubkey_t * tx_accs = (fd_pubkey_t )((uchar )txn_ctx->_txn_raw->raw + txn_ctx->txn_descriptor->acct_addr_off);`
`@@ -876,8 +874,6 @@ fd_executor_setup_accessed_accounts_for_txn( fd_exec_txn_ctx_t * txn_ctx ) {`
`876`	`874`	`if( FD_UNLIKELY( err!=FD_RUNTIME_EXECUTE_SUCCESS ) ) return err;`
`877`	`875`	`}`
`878`	`876`	`return FD_RUNTIME_EXECUTE_SUCCESS;`
`879`		`-`
`880`		`- } FD_SPAD_FRAME_END;`
`881`	`877`	`}`
`882`	`878`
`883`	`879`	`/* https://github.com/anza-xyz/agave/blob/c4b42ab045860d7b13b3912eafb30e6d2f4e593f/sdk/src/transaction_context.rs#L319-L357 */`