Merge branch 'release/v1.3.5'

Author: JC5

app/Services/CSV/Conversion/Task/Accounts.php

@@ -512,7 +512,7 @@ private function processTransaction(array $transaction): array
         $sourceArray = $this->getSourceArray($transaction);
         $destArray   = $this->getDestinationArray($transaction);
         $source      = $this->findAccount($sourceArray, $this->account);
-        $destination = $this->findAccount($destArray, $this->account);
+        $destination = $this->findAccount($destArray, null);
 
         /*
          * First, set source and destination in the transaction array:

app/Services/Camt/Transaction.php

@@ -315,11 +315,13 @@ public function getFieldByIndex(string $field, int $index): string
                 if (0 === count($this->levelD) || !array_key_exists($index, $this->levelD)) {
                     return $result;
                 }
-                /** @var EntryTransactionDetail $info */
-                $info            = $this->levelD[$index];
-                $opposingAccount = $this->getOpposingParty($info)?->getAccount();
-                if (null !== $opposingAccount && IbanAccount::class === get_class($opposingAccount)) {
-                    $result = (string)$opposingAccount->getIdentification();
+                /** @var EntryTransactionDetail|null $info */
+                $info = $this->levelD[$index] ?? null;
+                if (null !== $info) {
+                    $opposingAccount = $this->getOpposingParty($info)?->getAccount();
+                    if (is_object($opposingAccount) && IbanAccount::class === get_class($opposingAccount)) {
+                        $result = (string)$opposingAccount->getIdentification();
+                    }
                 }
 
                 return $result;
@@ -422,7 +424,8 @@ private function getOpposingParty(EntryTransactionDetail $transactionDetail): Re
     {
         $relatedParties           = $transactionDetail->getRelatedParties();
         $targetRelatedPartyObject = "Genkgo\Camt\DTO\Creditor";
-        if ($transactionDetail->getAmount()->getAmount() > 0) { // which part in this array is the interesting one?
+        $amount = $transactionDetail?->getAmount()?->getAmount();
+        if (null !== $amount && $amount > 0) { // which part in this array is the interesting one?
             $targetRelatedPartyObject = "Genkgo\Camt\DTO\Debtor";
         }
         foreach ($relatedParties as $relatedParty) {

changelog.md

@@ -2,6 +2,12 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## 1.3.5 - 2023-08-23
+
+### Fixed
+- Error in CSV import would break imports for many users, thanks for reporting!
+- Many null pointers removed from CAMT.053 import.
+
 ## 1.3.4 - 2023-08-21
 
 >  ⚠️ This release may create duplicate transactions. Don't import large batches!

composer.lock

@@ -23,7 +23,7 @@
 declare(strict_types=1);
 
 return [
-    'version'                 => '1.3.4',
+    'version'                 => '1.3.5',
     'flows'                   => ['nordigen', 'spectre', 'file'],
     'flow_titles'             => [
         'file'     => 'File',