Make it easier to add common props to test objects

Author: linclark

devtools/client/webconsole/new-console-output/test/components/console-api-call.test.js

@@ -13,27 +13,26 @@ const { createFactory } = require("devtools/client/shared/vendor/react");
 const ConsoleApiCall = createFactory(require("devtools/client/webconsole/new-console-output/components/message-types/console-api-call").ConsoleApiCall);
 
 // Test fakes.
-const { stubPreparedMessages } = require("devtools/client/webconsole/new-console-output/test/fixtures/stubs/index");
-const onViewSourceInDebugger = () => {};
-
+const { stubPreparedMessages: stubs } = require("devtools/client/webconsole/new-console-output/test/fixtures/stubs/index");
+const props = {
+  onViewSourceInDebugger: () => {},
+};
 const tempfilePath = "http://example.com/browser/devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/test-tempfile.js";
 
 describe("ConsoleAPICall component:", () => {
   describe("console.log", () => {
     it("renders string grips", () => {
-      const message = stubPreparedMessages.get("console.log('foobar', 'test')");
-      const wrapper = render(ConsoleApiCall({ message, onViewSourceInDebugger }));
+      const message = stubs.get("console.log('foobar', 'test')");
+      const wrapper = render(ConsoleApiCall(Object.assign({}, props, { message })));
 
       expect(wrapper.find(".message-body").text()).toBe("foobar test");
       expect(wrapper.find(".objectBox-string").length).toBe(2);
       expect(wrapper.find("div.message.cm-s-mozilla span span.message-flex-body span.message-body.devtools-monospace").length).toBe(1);
     });
 
     it("renders repeat node", () => {
-      const message =
-        stubPreparedMessages.get("console.log('foobar', 'test')")
-        .set("repeat", 107);
-      const wrapper = render(ConsoleApiCall({ message, onViewSourceInDebugger }));
+      const message = stubs.get("console.log('foobar', 'test')").set("repeat", 107);
+      const wrapper = render(ConsoleApiCall(Object.assign({}, props, { message })));
 
       expect(wrapper.find(".message-repeats").text()).toBe("107");
 
@@ -43,35 +42,35 @@ describe("ConsoleAPICall component:", () => {
 
   describe("console.count", () => {
     it("renders", () => {
-      const message = stubPreparedMessages.get("console.count('bar')");
-      const wrapper = render(ConsoleApiCall({ message, onViewSourceInDebugger }));
+      const message = stubs.get("console.count('bar')");
+      const wrapper = render(ConsoleApiCall(Object.assign({}, props, { message })));
 
       expect(wrapper.find(".message-body").text()).toBe("bar: 1");
     });
   });
 
   describe("console.assert", () => {
     it("renders", () => {
-      const message = stubPreparedMessages.get("console.assert(false, {message: 'foobar'})");
-      const wrapper = render(ConsoleApiCall({ message, onViewSourceInDebugger }));
+      const message = stubs.get("console.assert(false, {message: 'foobar'})");
+      const wrapper = render(ConsoleApiCall(Object.assign({}, props, { message })));
 
       expect(wrapper.find(".message-body").text()).toBe("Assertion failed: Object { message: \"foobar\" }");
     });
   });
 
   describe("console.time", () => {
     it("does not show anything", () => {
-      const message = stubPreparedMessages.get("console.time('bar')");
-      const wrapper = render(ConsoleApiCall({ message, onViewSourceInDebugger }));
+      const message = stubs.get("console.time('bar')");
+      const wrapper = render(ConsoleApiCall(Object.assign({}, props, { message })));
 
       expect(wrapper.find(".message-body").text()).toBe("");
     });
   });
 
   describe("console.timeEnd", () => {
     it("renders as expected", () => {
-      const message = stubPreparedMessages.get("console.timeEnd('bar')");
-      const wrapper = render(ConsoleApiCall({ message, onViewSourceInDebugger }));
+      const message = stubs.get("console.timeEnd('bar')");
+      const wrapper = render(ConsoleApiCall(Object.assign({}, props, { message })));
 
       expect(wrapper.find(".message-body").text()).toBe(message.messageText);
       expect(wrapper.find(".message-body").text()).toMatch(/^bar: \d+(\.\d+)?ms$/);
@@ -80,9 +79,9 @@ describe("ConsoleAPICall component:", () => {
 
   describe("console.trace", () => {
     it("renders", () => {
-      const message = stubPreparedMessages.get("console.trace()");
-      const wrapper = render(ConsoleApiCall({ message, onViewSourceInDebugger, open: true }));
-      const filepath = `${tempfilePath}`;
+      const message = stubs.get("console.trace()");
+      const wrapper = render(ConsoleApiCall(Object.assign({}, props, { message, open: true })));
+      const filepath = `${tempfilePath}?key=console.trace()`;
 
       expect(wrapper.find(".message-body").text()).toBe("console.trace()");