Skip to content

Check rewrites not fully working #2

Open
@grossmann

Description

@grossmann

The rewrite checks seems to not working fully correct.
With just 2 modules installed ( FireGento_GermanSetup and Sitewards_B2BProfessional) they both extend the class Mage_Catalog_Block_Product_Price. But Firegento don't show an error because the files where the class is extended reside in different paths in the file systems.

Core: magento\app\code\core\Mage\Catalog\Block\Product\Price.php
GermanSetup: magento\app\code\community\FireGento\GermanSetup\Block\Catalog\Product\Price.php
B2BProffessional: magento\app\code\community\Sitewards\B2BProfessional\Block\Price.php

I think Firegento should not just check for the path (which can differ very much) but also for the extended classes if there happens a rewrite.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions