Merge pull request #15694 from mcgratta/master

Python: Allow scripts to run if sub-scripts fail

Author: mcgratta

Manuals/FDS_Validation_Guide/Experiment_Chapter.tex

@@ -10,21 +10,21 @@ \chapter{Description of Experiments}
 \section{Aalto Woods Experiments}
 \label{Aalto_Woods_Description}
 
-Rinta-Paavola et al. developed a material model for Norway spruce and Scots pine woods to predict char front progress and heat release in burning timber~\cite{Rinta-Paavola:2023}. The material models are calibrated using temperature, mass loss rate and heat release rate measurements of wood specimens in a cone calorimeter. The model is intended for a number of different fire scenarios, such as fully developed fire with only little oxygen in the compartment, or the decay period after flaming with exposed char still smoldering. Cone calorimeter measurements were conducted under flaming, inert, and and smoldering conditions to replicate these scenarios. The estimated material models are able to predict the experiments in the scale of cone calorimeter.
+Rinta-Paavola et al.~developed a material model for Norway spruce and Scots pine woods to predict char front progress and heat release in burning timber~\cite{Rinta-Paavola:2023}. The material models are calibrated using temperature, mass loss rate and heat release rate measurements of wood specimens in a cone calorimeter. The model is intended for fully-developed compartment fires or the subsequent decay period with exposed, smoldering char. Cone calorimeter measurements were conducted under flaming, inert, and smoldering conditions to replicate these scenarios. The material models are able to predict the bench-scale experiments.
 
-The material model for spruce developed using cone calorimeter measurements is tested in prediction of heat release rates in two previously existing experiments: an ISO 9705 room corner test~\cite{Sundstrom:1998} (test code M12 in the original source) and a modified room corner test originally reported in Finnish in~\cite{Hietaniemi:2001}. English description of the modified test is available in~\cite{Hietaniemi:1}.
+The material model for spruce developed using cone calorimeter measurements is evaluated for its prediction of heat release rates in two previous experiments: an ISO~9705 room corner test~\cite{Sundstrom:1998} (test code M12 in the original source) and a modified room corner test originally reported in Finnish in~\cite{Hietaniemi:2001}. An English description of the modified test is available in Ref.~\cite{Hietaniemi:1}.
 
-In a room corner test, the walls and the ceiling of a 2.4~m by 3.6~m by 2.4~m (width, length, height) test compartment are lined with the tested material. The 2.4~m wide front wall has a 0.8~m wide, 2.0~m high door opening in the middle, and the back corner adjacent to the wall opposite to the door has a gas burner with an output of 100~kW for the first ten minutes of the test. If flashover does not occur during this time, the burner heat release is increased to 300~kW for another ten minutes. The test is terminated after 20 minutes or when flashover occurs.
+In a room corner test, the walls and ceiling of a 2.4~m by 3.6~m by 2.4~m tall compartment are lined with the sample material. The 2.4~m wide front wall has a 0.8~m wide, 2.0~m high door opening in the middle, and the back corner adjacent to the wall opposite to the door has a gas burner with an output of 100~kW for 10~min. If flashover does not occur during this time, the burner heat release is increased to 300~kW for another 10~min. The test is terminated after 20~min or when flashover occurs.
 
-In the test M12~\cite{Sundstrom:1998} the walls and the ceiling are lined with 10~mm thick spruce timber, whereas in the modified test~\cite{Hietaniemi:2001} the walls and ceiling only in the proximity of the gas burner was lined with 22~mm thick spruce timber, elsewhere being exposed concrete. In both of the studied tests the flashover occurred within the first ten minutes, so the burner heat release was 100~kW over the entire duration of the test.
+In the test M12~\cite{Sundstrom:1998}, the walls and the ceiling are lined with 10~mm thick spruce timber, whereas in the modified test~\cite{Hietaniemi:2001} the walls and ceiling only in the proximity of the gas burner were lined with 22~mm thick spruce timber, elsewhere being exposed concrete. In both tests, flashover occurred within the first 10~min.
 
 \subsubsection{Modeling Notes}
 
-In the simulations of flaming cone calorimeter experiments, the computational domain is 20~cm in length and width and 30~cm in height, with a grid resolution of 1~cm. For the inert and smoldering experiments the domain is 30~cm by 30~cm by 30~cm with the resolution of 10~cm, as the gaseous phase was not directly modeled. In the simulations of room corner tests, the computational domain continued for 1.5~m outside after the 20~cm thick front wall. In the corner where the burner was located, the grid resolution was 2~cm over a volume that extends for 0.5~m from the corner at x-, and y directions, and spans the entire height from floor to the ceiling. Elsewhere, a resolution of 10~cm was used.
+In the simulations of flaming cone calorimeter experiments, the computational domain is 20~cm in length and width and 30~cm in height, with a grid resolution of 1~cm. For the inert and smoldering experiments, the domain is 30~cm by 30~cm by 30~cm with a resolution of 10~cm because the gaseous phase is not directly modeled. In the simulations of room corner tests, the computational domain is extended 1.5~m outside the 20~cm thick front wall. In the corner where the burner is located, the grid resolution is 2~cm over a volume that extends 0.5~m from the corner and spans the entire height from floor to ceiling. Elsewhere, a resolution of 10~cm is used.
 
-Neither~\cite{Sundstrom:1998} nor~\cite{Hietaniemi:2001} reported the initial moisture content of the timbers, so a moisture mass fraction of 0.09 similar to the cone calorimeter specimens in~\cite{Rinta-Paavola:2023}, was assumed in the beginning of room corner tests. This is a relevant moisture content for timber in normal room air.
+Neither Ref.~\cite{Sundstrom:1998} nor Ref.~\cite{Hietaniemi:2001} reports the initial moisture content of the timbers; thus, a moisture mass fraction of 0.09 is assumed, similar to the cone calorimeter specimens in Ref.~\cite{Rinta-Paavola:2023}.
 
-The parameters in the original research of Rinta-Paavola et al.~\cite{Rinta-Paavola:2023} were estimated for FDS 6.7.7, but in FDS 6.7.8 and later the reaction rate equation for solid pyrolysis is different, possibly requiring scaling of the pre-exponential factor when parameters are carried from a FDS version with the old reaction rate definition to a newer one. See~\cite{Rinta-Paavola:2023} for greater detail. Table~\ref{Aalto_Woods_Properties} presents appropriately scaled parameters that yield results consistent to the original simulations in~\cite{Rinta-Paavola:2023} when initial moisture mass fraction is 0.09. If a different initial moisture content is used, re-scaling of the frequency factor would be necessary to gain most accurate possible agreement with the model presented in~\cite{Rinta-Paavola:2023}.
+The parameters in the original research of Rinta-Paavola~et~al.~\cite{Rinta-Paavola:2023} were estimated for FDS 6.7.7, but in FDS 6.7.8 and later the reaction rate equation for solid pyrolysis is different, possibly requiring scaling of the pre-exponential factor when parameters are carried from a FDS version with the old reaction rate definition to a newer one. See Ref.~\cite{Rinta-Paavola:2023} for details. Table~\ref{Aalto_Woods_Properties} presents appropriately scaled parameters that yield results consistent with the original simulations in Ref.~\cite{Rinta-Paavola:2023} when the initial moisture mass fraction is 0.09. If a different initial moisture content is used, re-scaling of the frequency factor would be necessary to obtain the most accurate possible agreement with the model presented in Ref.~\cite{Rinta-Paavola:2023}.
 
 
 \section{ArupFire Tunnel Fire Experiments}

Utilities/Python/FDS_validation_script.py

@@ -1,29 +1,38 @@
 #!$FIREMODELS/fds/.github/fds_python_env/bin/python
 
+import subprocess
 import fdsplotlib
 import importlib
 import runpy
 importlib.reload(fdsplotlib) # use for development (while making changes to fdsplotlib.py)
 
+# If there is an error in one of the sub-scripts, print the message but do not stop the main script.
+
+def safe_run(script_path):
+    try:
+        runpy.run_path(script_path, run_name="__main__")
+    except Exception as exc:
+        print(f"Error in {script_path}: {exc}")
+
 # Scripts to run prior to dataplot
 
-print("NIST_deposition_gauge...");        runpy.run_path("./scripts/NIST_deposition_gauge.py", run_name="__main__")
-print("flame_height...");                 runpy.run_path("./scripts/flame_height.py", run_name="__main__")
-print("NIST_RSE...");                     runpy.run_path("./scripts/NIST_RSE.py", run_name="__main__")
-print("sippola_aerosol_deposition...");   runpy.run_path("./scripts/sippola_aerosol_deposition.py", run_name="__main__")
-print("layer_height...");                 runpy.run_path("./scripts/layer_height.py", run_name="__main__")
-print("NIST_NRC_Corner_Effects...");      runpy.run_path("./scripts/NIST_NRC_Corner_Effects.py", run_name="__main__")
-print("LNG_Dispersion...");               runpy.run_path("./scripts/LNG_Dispersion.py", run_name="__main__")
-print("LNG_wind_profiles...");            runpy.run_path("./scripts/LNG_wind_profiles.py", run_name="__main__")
-print("FM_Vertical_Wall_Flames...");      runpy.run_path("./scripts/FM_Vertical_Wall_Flames.py", run_name="__main__")
-print("umd_line_burner_process...");      runpy.run_path("./scripts/umd_line_burner_process.py", run_name="__main__")
-# print("Askervein_Hill...");               runpy.run_path("./scripts/Askervein_Hill.py", run_name="__main__")
-print("UWO_Wind_Tunnel...");              runpy.run_path("./scripts/UWO_Wind_Tunnel.py", run_name="__main__")
-print("FM_Burner...");                    runpy.run_path("./scripts/FM_Burner.py", run_name="__main__")
-print("Crown_Fires...");                  runpy.run_path("./scripts/Crown_Fires.py", run_name="__main__")
-print("Ranz_Marshall...");                runpy.run_path("./scripts/Ranz_Marshall.py", run_name="__main__")
-print("Phoenix_LNG_Fires...");            runpy.run_path("./scripts/Phoenix_LNG_Fires.py", run_name="__main__")
-print("Sandia_Plumes_TKE...");            runpy.run_path("./scripts/Sandia_Plumes_TKE.py", run_name="__main__")
+print("NIST_deposition_gauge...");        safe_run("./scripts/NIST_deposition_gauge.py")
+print("flame_height...");                 safe_run("./scripts/flame_height.py")
+print("NIST_RSE...");                     safe_run("./scripts/NIST_RSE.py")
+print("sippola_aerosol_deposition...");   safe_run("./scripts/sippola_aerosol_deposition.py")
+print("layer_height...");                 safe_run("./scripts/layer_height.py")
+print("NIST_NRC_Corner_Effects...");      safe_run("./scripts/NIST_NRC_Corner_Effects.py")
+print("LNG_Dispersion...");               safe_run("./scripts/LNG_Dispersion.py")
+print("LNG_wind_profiles...");            safe_run("./scripts/LNG_wind_profiles.py")
+print("FM_Vertical_Wall_Flames...");      safe_run("./scripts/FM_Vertical_Wall_Flames.py")
+print("umd_line_burner_process...");      safe_run("./scripts/umd_line_burner_process.py")
+# print("Askervein_Hill...");               safe_run("./scripts/Askervein_Hill.py")
+print("UWO_Wind_Tunnel...");              safe_run("./scripts/UWO_Wind_Tunnel.py")
+print("FM_Burner...");                    safe_run("./scripts/FM_Burner.py")
+print("Crown_Fires...");                  safe_run("./scripts/Crown_Fires.py")
+print("Ranz_Marshall...");                safe_run("./scripts/Ranz_Marshall.py")
+print("Phoenix_LNG_Fires...");            safe_run("./scripts/Phoenix_LNG_Fires.py")
+print("Sandia_Plumes_TKE...");            safe_run("./scripts/Sandia_Plumes_TKE.py")
 
 # Dataplot and scatplot options
 
@@ -71,27 +80,27 @@
 
 # Create table of git statistics for FDS Validation Guide
 
-print("validation_git_stats...");         runpy.run_path("./scripts/validation_git_stats.py", run_name="__main__")
+print("validation_git_stats...");         safe_run("./scripts/validation_git_stats.py")
 
 # Special cases
 
-print("Backward_Facing_Step...");         runpy.run_path("./scripts/Backward_Facing_Step.py", run_name="__main__")
-print("Beyler_Hood...");                  runpy.run_path("./scripts/Beyler_Hood.py", run_name="__main__")
-print("BRE_LEMTA_Sprays...");             runpy.run_path("./scripts/BRE_LEMTA_Sprays.py", run_name="__main__")
-print("catchpole_spread_rates...");       runpy.run_path("./scripts/catchpole_spread_rates.py", run_name="__main__")
-print("FHWA_Tunnel...");                  runpy.run_path("./scripts/FHWA_Tunnel.py", run_name="__main__")
-print("FM_FPRF_Datacenter...");           runpy.run_path("./scripts/FM_FPRF_Datacenter.py", run_name="__main__")
-print("Heskestad_Flame_Height_2...");     runpy.run_path("./scripts/Heskestad_Flame_Height_2.py", run_name="__main__")
-print("McCaffrey_Plume...");              runpy.run_path("./scripts/McCaffrey_Plume.py", run_name="__main__")
-print("Memorial_Tunnel...");              runpy.run_path("./scripts/Memorial_Tunnel.py", run_name="__main__")
-print("Memorial_Tunnel_2...");            runpy.run_path("./scripts/Memorial_Tunnel_2.py", run_name="__main__")
-print("NIST_NRC_Parallel_Panels...");     runpy.run_path("./scripts/NIST_NRC_Parallel_Panels.py", run_name="__main__")
-print("Sandia_Plumes...");                runpy.run_path("./scripts/Sandia_Plumes.py", run_name="__main__")
-print("Sandia_Pools...");                 runpy.run_path("./scripts/Sandia_Pools.py", run_name="__main__")
-print("Theobald_Hose_Stream...");         runpy.run_path("./scripts/Theobald_Hose_Stream.py", run_name="__main__")
-print("TUS_Facade...");                   runpy.run_path("./scripts/TUS_Facade_contours.py", run_name="__main__")
-print("USFS_Deep_Fuel_Beds...");          runpy.run_path("./scripts/USFS_Deep_Fuel_Beds.py", run_name="__main__")
-print("Wu_Bakar_Tunnels...");             runpy.run_path("./scripts/Wu_Bakar_Tunnels.py", run_name="__main__")
+print("Backward_Facing_Step...");         safe_run("./scripts/Backward_Facing_Step.py")
+print("Beyler_Hood...");                  safe_run("./scripts/Beyler_Hood.py")
+print("BRE_LEMTA_Sprays...");             safe_run("./scripts/BRE_LEMTA_Sprays.py")
+print("catchpole_spread_rates...");       safe_run("./scripts/catchpole_spread_rates.py")
+print("FHWA_Tunnel...");                  safe_run("./scripts/FHWA_Tunnel.py")
+print("FM_FPRF_Datacenter...");           safe_run("./scripts/FM_FPRF_Datacenter.py")
+print("Heskestad_Flame_Height_2...");     safe_run("./scripts/Heskestad_Flame_Height_2.py")
+print("McCaffrey_Plume...");              safe_run("./scripts/McCaffrey_Plume.py")
+print("Memorial_Tunnel...");              safe_run("./scripts/Memorial_Tunnel.py")
+print("Memorial_Tunnel_2...");            safe_run("./scripts/Memorial_Tunnel_2.py")
+print("NIST_NRC_Parallel_Panels...");     safe_run("./scripts/NIST_NRC_Parallel_Panels.py")
+print("Sandia_Plumes...");                safe_run("./scripts/Sandia_Plumes.py")
+print("Sandia_Pools...");                 safe_run("./scripts/Sandia_Pools.py")
+print("Theobald_Hose_Stream...");         safe_run("./scripts/Theobald_Hose_Stream.py")
+print("TUS_Facade...");                   safe_run("./scripts/TUS_Facade_contours.py")
+print("USFS_Deep_Fuel_Beds...");          safe_run("./scripts/USFS_Deep_Fuel_Beds.py")
+print("Wu_Bakar_Tunnels...");             safe_run("./scripts/Wu_Bakar_Tunnels.py")
 
 print("Python validation scripts completed successfully!")