Skip to content

Commit 762f235

Browse files
committed
FireX: Merge with firemodels/master
2 parents 9add5c5 + 0ca9afb commit 762f235

File tree

11 files changed

+411
-488
lines changed

11 files changed

+411
-488
lines changed

Manuals/FDS_User_Guide/FDS_User_Guide.tex

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14195,6 +14195,7 @@ \chapter{Error Codes}
1419514195
266 \> \ct{REAC ... FUEL ... is not a predefined or tracked species.} \> Section~\ref{info:simple_chemistry} \\
1419614196
267 \> \ct{REAC ... has no consumed species.} \> Section~\ref{info:REAC_Diagnostics} \\
1419714197
268 \> \ct{BACK tracked species ... not found.} \> Section~\ref{info:BACK} \\
14198+
269 \> \ct{MATL ... The specified pyrolysis parameters result in A >...} \> Section~\ref{info:kinetic_parameters} \\
1419814199
\> \> \\
1419914200
299 \> \ct{SURF ... has no solid or particle for TGA.} \> Section~\ref{info:TGA_DSC_MCC} \\
1420014201
300 \> \ct{N_LAYER_CELLS_MAX should be at least ... for ...} \> Section~\ref{info:solid_phase_stability} \\

Source/dump.f90

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1409,7 +1409,7 @@ SUBROUTINE INITIALIZE_MESH_DUMPS(NM)
14091409
IF (ABS(OB%Z2-M%ZS)<TWO_EPSILON_EB) IOR = 3
14101410
IF (IOR==0) CYCLE OBST_LOOP
14111411
M%N_PATCH = M%N_PATCH + 1
1412-
IF (M%N_PATCH>SIZE(M%PATCH)) CALL REALLOCATE_PATCH(NM,SIZE(M%PATCH),SIZE(M%PATCH)+10)
1412+
IF (M%N_PATCH>SIZE(M%PATCH)) CALL REALLOCATE_PATCH(NM,SIZE(M%PATCH),SIZE(M%PATCH)+10,'PATCH')
14131413
PA => M%PATCH(M%N_PATCH)
14141414
PA%I1 = MIN(M%IBAR,MAX(0,NINT( GINV(OB%X1-M%XS,1,NM)*RDXI ))) ; PA%IG1 = PA%I1+1
14151415
PA%I2 = MIN(M%IBAR,MAX(0,NINT( GINV(OB%X2-M%XS,1,NM)*RDXI ))) ; PA%IG2 = PA%I2
@@ -1733,20 +1733,30 @@ END SUBROUTINE WRITE_STL_FILE
17331733
!> \param NM Mesh number
17341734
!> \param N1 Current size of array
17351735
!> \param N2 New size of array
1736+
!> \param PATCH_NAME Character string indicating which PATCH_TYPE variable to reallocate
17361737

1737-
SUBROUTINE REALLOCATE_PATCH(NM,N1,N2)
1738+
SUBROUTINE REALLOCATE_PATCH(NM,N1,N2,PATCH_NAME)
17381739

17391740
INTEGER, INTENT(IN) :: N1,N2,NM
17401741
TYPE (PATCH_TYPE), DIMENSION(:), ALLOCATABLE :: PATCH_DUMMY
17411742
TYPE (MESH_TYPE), POINTER :: M
1743+
CHARACTER(*), INTENT(IN) :: PATCH_NAME
17421744

17431745
M => MESHES(NM)
17441746

17451747
ALLOCATE(PATCH_DUMMY(1:N2))
1746-
PATCH_DUMMY(1:N1) = M%PATCH(1:N1)
1747-
DEALLOCATE(M%PATCH)
1748-
ALLOCATE(M%PATCH(1:N2))
1749-
M%PATCH(1:N2) = PATCH_DUMMY(1:N2)
1748+
SELECT CASE(PATCH_NAME)
1749+
CASE('PATCH')
1750+
PATCH_DUMMY(1:N1) = M%PATCH(1:N1)
1751+
DEALLOCATE(M%PATCH)
1752+
ALLOCATE(M%PATCH(1:N2))
1753+
M%PATCH(1:N2) = PATCH_DUMMY(1:N2)
1754+
CASE('EXTERIOR_PATCH')
1755+
PATCH_DUMMY(1:N1) = M%EXTERIOR_PATCH(1:N1)
1756+
DEALLOCATE(M%EXTERIOR_PATCH)
1757+
ALLOCATE(M%EXTERIOR_PATCH(1:N2))
1758+
M%EXTERIOR_PATCH(1:N2) = PATCH_DUMMY(1:N2)
1759+
END SELECT
17501760
DEALLOCATE(PATCH_DUMMY)
17511761

17521762
END SUBROUTINE REALLOCATE_PATCH
@@ -2784,6 +2794,8 @@ SUBROUTINE DUMMY_VENTS(FI,N1,N2)
27842794
VENT_INDICES(I:ISTP,J:JSTP,FI) = -1
27852795

27862796
M%N_EXTERIOR_PATCH = M%N_EXTERIOR_PATCH + 1
2797+
IF (M%N_EXTERIOR_PATCH>SIZE(M%EXTERIOR_PATCH)) &
2798+
CALL REALLOCATE_PATCH(NM,SIZE(M%EXTERIOR_PATCH),SIZE(M%EXTERIOR_PATCH)+10,'EXTERIOR_PATCH')
27872799
EP => M%EXTERIOR_PATCH(M%N_EXTERIOR_PATCH)
27882800
SELECT CASE(FI)
27892801
CASE (1) ; EP%I1=0 ; EP%I2=0 ; EP%J1=I-1 ; EP%J2=ISTP ; EP%K1=J-1 ; EP%K2=JSTP ; EP%IOR= 1
@@ -2816,7 +2828,7 @@ SUBROUTINE ADD_EXTERIOR_VENTS
28162828
IF (PROCESS(NM)/=MY_RANK) CYCLE
28172829
M => MESHES(NM)
28182830

2819-
ALLOCATE(M%EXTERIOR_PATCH(10*(6+N_VENT_TOTAL))) ; M%N_EXTERIOR_PATCH = 0
2831+
ALLOCATE(M%EXTERIOR_PATCH(10)) ; M%N_EXTERIOR_PATCH = 0 ! The size of EXTERIOR_PATCH will expand if need be.
28202832
ALLOCATE(VENT_INDICES(MAX(M%IBAR,M%JBAR),MAX(M%JBAR,M%KBAR),6)) ; VENT_INDICES = 0
28212833

28222834
VENT_LOOP: DO N=1,M%N_VENT

Source/read.f90

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7461,6 +7461,12 @@ SUBROUTINE READ_MATL
74617461
PEAK_REACTION_RATE = 2._EB*ML%HEATING_RATE(NR)/ML%PYROLYSIS_RANGE(NR)
74627462
ENDIF
74637463
ML%E(NR) = EXP(1._EB)*PEAK_REACTION_RATE*R0*ML%TMP_REF(NR)**2/ML%HEATING_RATE(NR)
7464+
! 0.0001 HUGE_EB is used so the reaction rate is not overflowed when multiplied by RHO.
7465+
IF (LOG(0.0001_EB*HUGE_EB)*R0*ML%TMP_REF(NR) < ML%E(NR)) THEN
7466+
WRITE(MESSAGE,'(3A,E10.3)') 'ERROR(269): MATL ',TRIM(ML%ID),' The specified pyrolysis parameters result in A >',&
7467+
0.0001_EB*HUGE_EB
7468+
CALL SHUTDOWN(MESSAGE) ; RETURN
7469+
ENDIF
74647470
ML%A(NR) = EXP(1._EB)*PEAK_REACTION_RATE*EXP(ML%E(NR)/(R0*ML%TMP_REF(NR)))
74657471
ENDIF
74667472

Utilities/Matlab/FDS_validation_dataplot_inputs.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2532,7 +2532,7 @@ s,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,
25322532
d,SWJTU Tunnels,SWJTU_Tunnels/SWJTU_Tunnels_Extinction.csv,1,2,HRR_1,Time_1,Exp,k-,0,10000,,5.2,6,-10000,10000,0,SWJTU_Tunnels/Test_I-1_hrr.csv,2,3,HRR,Time,FDS,k--,0,10000,,5.2,6,-10000,10000,0,Extinction Time; Test I-1,HRR (kW),Time (s),0,20,1,0,800,1,yes,0.05 0.90,East,,1,SWJTU_Tunnels/Test_I-1_git.txt,linear,FDS_Validation_Guide/SCRIPT_FIGURES/SWJTU_Tunnels/Test_I-1_Ext_Time,0,max,0,SWJTU Tunnels,g^,g,TeX
25332533
d,SWJTU Tunnels,SWJTU_Tunnels/SWJTU_Tunnels_Extinction.csv,1,2,HRR_2,Time_2,Exp,k-,0,10000,,10,12,-10000,10000,0,SWJTU_Tunnels/Test_I-2_hrr.csv,2,3,HRR,Time,FDS,k--,0,10000,,10,12,-10000,10000,0,Extinction Time; Test I-2,HRR (kW),Time (s),0,20,1,0,800,1,yes,0.05 0.90,East,,1,SWJTU_Tunnels/Test_I-2_git.txt,linear,FDS_Validation_Guide/SCRIPT_FIGURES/SWJTU_Tunnels/Test_I-2_Ext_Time,0,max,0,SWJTU Tunnels,g^,g,TeX
25342534
d,SWJTU Tunnels,SWJTU_Tunnels/SWJTU_Tunnels_Extinction.csv,1,2,HRR_3,Time_3,Exp,k-,0,10000,,16,17,-10000,10000,0,SWJTU_Tunnels/Test_I-3_hrr.csv,2,3,HRR,Time,FDS,k--,0,10000,,16,17,-10000,10000,0,Extinction Time; Test I-3,HRR (kW),Time (s),0,20,1,0,800,1,yes,0.05 0.90,East,,1,SWJTU_Tunnels/Test_I-3_git.txt,linear,FDS_Validation_Guide/SCRIPT_FIGURES/SWJTU_Tunnels/Test_I-3_Ext_Time,0,max,0,SWJTU Tunnels,g^,g,TeX
2535-
d,SWJTU Tunnels,SWJTU_Tunnels/SWJTU_Tunnels_Extinction.csv,1,2,HRR_4,Time_4,Exp,k-,0,10000,,5.2,6,-10000,10000,0,SWJTU_Tunnels/Test_I-4_hrr.csv,2,3,HRR,Time,FDS,k--,0,10000,,5.2,6,-10000,10000,0,Extinction Time; Test I-4,HRR (kW),Time (s),0,20,1,0,800,1,yes,0.05 0.90,East,,1,SWJTU_Tunnels/Test_I-4_git.txt,linear,FDS_Validation_Guide/SCRIPT_FIGURES/SWJTU_Tunnels/Test_I-4_Ext_Time,0,max,0,SWJTU Tunnels,g^,g,TeX
2535+
d,SWJTU Tunnels,SWJTU_Tunnels/SWJTU_Tunnels_Extinction.csv,1,2,HRR_4,Time_4,Exp,k-,0,10000,,4.5,6,-10000,10000,0,SWJTU_Tunnels/Test_I-4_hrr.csv,2,3,HRR,Time,FDS,k--,0,10000,,4.5,6,-10000,10000,0,Extinction Time; Test I-4,HRR (kW),Time (s),0,20,1,0,800,1,yes,0.05 0.90,East,,1,SWJTU_Tunnels/Test_I-4_git.txt,linear,FDS_Validation_Guide/SCRIPT_FIGURES/SWJTU_Tunnels/Test_I-4_Ext_Time,0,max,0,SWJTU Tunnels,g^,g,TeX
25362536
d,SWJTU Tunnels,SWJTU_Tunnels/SWJTU_Tunnels_Extinction.csv,1,2,HRR_5,Time_5,Exp,k-,0,10000,,10,12,-10000,10000,0,SWJTU_Tunnels/Test_I-5_hrr.csv,2,3,HRR,Time,FDS,k--,0,10000,,10,12,-10000,10000,0,Extinction Time; Test I-5,HRR (kW),Time (s),0,20,1,0,800,1,yes,0.05 0.90,East,,1,SWJTU_Tunnels/Test_I-5_git.txt,linear,FDS_Validation_Guide/SCRIPT_FIGURES/SWJTU_Tunnels/Test_I-5_Ext_Time,0,max,0,SWJTU Tunnels,g^,g,TeX
25372537
d,SWJTU Tunnels,SWJTU_Tunnels/SWJTU_Tunnels_Extinction.csv,1,2,HRR_6,Time_6,Exp,k-,0,10000,,15,17,-10000,10000,0,SWJTU_Tunnels/Test_I-6_hrr.csv,2,3,HRR,Time,FDS,k--,0,10000,,12,17,-10000,10000,0,Extinction Time; Test I-6,HRR (kW),Time (s),0,20,1,0,800,1,yes,0.05 0.90,East,,1,SWJTU_Tunnels/Test_I-6_git.txt,linear,FDS_Validation_Guide/SCRIPT_FIGURES/SWJTU_Tunnels/Test_I-6_Ext_Time,0,max,0,SWJTU Tunnels,g^,g,TeX
25382538
s,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,

Utilities/Python/FDS_validation_script.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,9 @@
7070
# verbose=True,
7171
# )
7272

73+
# Create table of git statistics for FDS Validation Guide
74+
75+
print("validation_git_stats..."); runpy.run_path("./scripts/validation_git_stats.py", run_name="__main__")
7376

7477
# Special cases
7578

0 commit comments

Comments
 (0)