Skip to content

Commit 917186f

Browse files
authored
Merge pull request #15594 from rmcdermo/mw_cor_2
FDS Source: IMPORTANT, add back FLUX_LIMITER_MW_CORRECTION with 2 ghost cells as default, remove single coefficient scheme
2 parents 9aeb558 + 2eccecb commit 917186f

File tree

11 files changed

+364
-377
lines changed

11 files changed

+364
-377
lines changed

Manuals/FDS_User_Guide/FDS_User_Guide.tex

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9139,7 +9139,7 @@ \section{Flux Limiters}
91399139
Central differencing & \ct{'CENTRAL'} \\
91409140
Godunov & \ct{'GODUNOV'} \\
91419141
Superbee (VLES, SVLES default) & \ct{'SUPERBEE'} \\
9142-
CHARM (DNS, LES default) & \ct{'CHARM'} \\
9142+
CHARM (DNS, LES default) & \ct{'CHARM'} \\
91439143
\hline
91449144
\end{tabular}
91459145
\end{table}
@@ -14426,8 +14426,8 @@ \chapter{Error Codes}
1442614426
610 \> \ct{HOLE ... Cannot overlap HOLEs with a DEVC or CTRL_ID.} \> Section~\ref{info:HOLE} \\
1442714427
611 \> \ct{OBST ... has a BULK_DENSITY but zero volume.} \> Section~\ref{info:BURN_AWAY} \\
1442814428
612 \> \ct{OBST ... must have a volume to be assigned HT3D.} \> Section~\ref{checkerboard} \\
14429-
614 \> \ct{OBST_ID ... cannot have a SURF with NODE_ID} \> Section~\ref{info:hvac_geom} \\
14430-
615 \> \ct{OBST ... cannot overlap OBST ...} \> Section~\ref{info:OVERLAY} \\
14429+
614 \> \ct{OBST_ID ... cannot have a SURF with NODE_ID} \> Section~\ref{info:hvac_geom} \\
14430+
615 \> \ct{OBST ... cannot overlap OBST ...} \> Section~\ref{info:OVERLAY} \\
1443114431
\> \> \\
1443214432
701 \> \ct{problem with GEOM, local SURF_ID index ... out of bounds.} \> Section~\ref{info:GEOM_Basics} \\
1443314433
702 \> \ct{problem with GEOM, SURF_IDS not defined properly.} \> Section~\ref{info:first_geom} \\

Manuals/FDS_Verification_Guide/FDS_Verification_Guide.tex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5141,7 +5141,7 @@ \subsection{Case 8: 2-D Heat Transfer with Temperature-Dependent Conductivity}
51415141
\FloatBarrier
51425142

51435143

5144-
\subsection{Case 9: 2-D Heat Transfer in a Composite Section with Temperature-Dependent Conductivity}
5144+
\subsection{Case 9: 2-D Heat Transfer in a Composite Section, Variable Conductivity}
51455145
\label{SFPE_Case_9}
51465146

51475147
A hollow square metal tube ($\rho=7850$~kg/m$^3$, $c=0.6$~kJ/(kg~K), $\epsilon=0.8$) is filled with an insulation material ($k=0.05$~W/(m~K), $\rho=50$~kg/m$^3$, $c=1$~kJ/(kg~K)). The thermal conductivity of the metal tube varies linearly with temperature such that its value is 54.7~W/(m~K) at 0~°C, 27.3~W/(m~K) at 800~°C, and 27.3~W/(m~K) at 1200~°C. The tube walls are 0.5~mm thick, and the exterior width of the assembly is 0.201~m. The surrounding air temperature is 1000~°C, and the initial temperature of the assembly is 0~°C. Assuming that the heating is by convection and radiation, and that the heat transfer coefficient is 10~W/(m$^2$~K), calculate the temperature at the center of the tube as a function of time (Fig.~\ref{fig:SFPE_Case_9}).

Source/cons.f90

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,7 @@ MODULE GLOBAL_CONSTANTS
278278
LOGICAL :: STORE_FIRE_RESIDENCE=.FALSE. !< Flag for tracking residence time of spreading fire front over a surface
279279
LOGICAL :: STORE_LS_SPREAD_RATE=.FALSE. !< Flag for outputting local level set spread rate magnitude
280280
LOGICAL :: TEST_NEW_CHAR_MODEL=.FALSE. !< Flag to envoke new char model
281+
LOGICAL :: FLUX_LIMITER_MW_CORRECTION=.TRUE. !< Flag for MW correction ensure consistent equation of state at face
281282

282283
INTEGER, ALLOCATABLE, DIMENSION(:) :: CHANGE_TIME_STEP_INDEX !< Flag to indicate if a mesh needs to change time step
283284
INTEGER, ALLOCATABLE, DIMENSION(:) :: SETUP_PRESSURE_ZONES_INDEX !< Flag to indicate if a mesh needs to keep searching for ZONEs

Source/data.f90

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1360,42 +1360,6 @@ SUBROUTINE DEFINE_OUTPUT_QUANTITIES
13601360
OUTPUT_QUANTITY(553)%UNITS = 'm/s'
13611361
OUTPUT_QUANTITY(553)%SHORT_NAME = 'V_LS'
13621362

1363-
OUTPUT_QUANTITY(560)%NAME = 'BFX'
1364-
OUTPUT_QUANTITY(560)%UNITS = ''
1365-
OUTPUT_QUANTITY(560)%SHORT_NAME = 'bfx'
1366-
OUTPUT_QUANTITY(560)%CELL_POSITION = CELL_FACE
1367-
OUTPUT_QUANTITY(560)%IOR = 1
1368-
1369-
OUTPUT_QUANTITY(561)%NAME = 'BFY'
1370-
OUTPUT_QUANTITY(561)%UNITS = ''
1371-
OUTPUT_QUANTITY(561)%SHORT_NAME = 'bfy'
1372-
OUTPUT_QUANTITY(561)%CELL_POSITION = CELL_FACE
1373-
OUTPUT_QUANTITY(561)%IOR = 2
1374-
1375-
OUTPUT_QUANTITY(562)%NAME = 'BFZ'
1376-
OUTPUT_QUANTITY(562)%UNITS = ''
1377-
OUTPUT_QUANTITY(562)%SHORT_NAME = 'bfz'
1378-
OUTPUT_QUANTITY(562)%CELL_POSITION = CELL_FACE
1379-
OUTPUT_QUANTITY(562)%IOR = 3
1380-
1381-
OUTPUT_QUANTITY(563)%NAME = 'BFX MINUS'
1382-
OUTPUT_QUANTITY(563)%UNITS = ''
1383-
OUTPUT_QUANTITY(563)%SHORT_NAME = 'bfx-'
1384-
OUTPUT_QUANTITY(563)%CELL_POSITION = CELL_FACE
1385-
OUTPUT_QUANTITY(563)%IOR = 1
1386-
1387-
OUTPUT_QUANTITY(564)%NAME = 'BFY MINUS'
1388-
OUTPUT_QUANTITY(564)%UNITS = ''
1389-
OUTPUT_QUANTITY(564)%SHORT_NAME = 'bfy-'
1390-
OUTPUT_QUANTITY(564)%CELL_POSITION = CELL_FACE
1391-
OUTPUT_QUANTITY(564)%IOR = 2
1392-
1393-
OUTPUT_QUANTITY(565)%NAME = 'BFZ MINUS'
1394-
OUTPUT_QUANTITY(565)%UNITS = ''
1395-
OUTPUT_QUANTITY(565)%SHORT_NAME = 'bfz-'
1396-
OUTPUT_QUANTITY(565)%CELL_POSITION = CELL_FACE
1397-
OUTPUT_QUANTITY(565)%IOR = 3
1398-
13991363
! Boundary Quantities (Negative indices)
14001364

14011365
OUTPUT_QUANTITY(-1)%NAME = 'RADIATIVE HEAT FLUX'

0 commit comments

Comments
 (0)