Fix busy-loop in I2P Accept when socket has error

The Wait() function returns false for both timeout and socket errors.
Previously, the Accept loop treated all false returns as timeouts and
continued, which could cause a busy-loop if the socket had an error.

Now we call IsConnected() when Wait() returns false to distinguish:
- If socket has error: break out of loop with error message
- If genuine timeout: continue waiting for connections

This prevents CPU spinning when the socket is in an error state.

Co-authored-by: reuben <[email protected]>

Author: cursoragent

src/i2p.cpp

@@ -206,7 +206,15 @@ bool Session::Accept(Connection& conn)
 
     while (!(*m_interrupt)) {
         if (!Wait(conn.sock, MAX_WAIT_FOR_IO, true)) {
-            // Timeout, no incoming connections or errors within MAX_WAIT_FOR_IO.
+            // Wait returned false - could be timeout or socket error
+            // Check if the socket is still valid to distinguish between the two
+            std::string socket_errmsg;
+            if (!IsConnected(conn.sock, socket_errmsg)) {
+                // Socket error - break out to avoid busy-looping
+                errmsg = strprintf("Socket error while waiting for connection: %s", socket_errmsg);
+                break;
+            }
+            // Genuine timeout - continue waiting for incoming connections
             continue;
         }