fix: update config data when config_update signaled and fix set_charge_mode (#203)

* fix: update config data when config_update signaled

* fix set_charge_mode function

* formatting

* update test

* formatting

Author: firstof9

openevsehttp/__main__.py

@@ -113,6 +113,8 @@ async def process_request(
                     if resp.status in [404, 405, 500]:
                         _LOGGER.error("%s", message)
 
+                    if method == "post" and "config_version" in message:
+                        await self.update()
                     return message
 
             except (TimeoutError, ServerTimeoutError):
@@ -264,7 +266,7 @@ async def set_charge_mode(self, mode: str = "fast") -> None:
         """Set the charge mode."""
         url = f"{self.url}config"
 
-        if mode != "fast" or mode != "eco":
+        if mode not in ["fast", "eco"]:
             _LOGGER.error("Invalid value for charge_mode: %s", mode)
             raise ValueError
 
@@ -274,7 +276,8 @@ async def set_charge_mode(self, mode: str = "fast") -> None:
         response = await self.process_request(
             url=url, method="post", data=data
         )  # noqa: E501
-        if response["msg"] != "done":
+        result = response["msg"]
+        if result not in ["done", "no change"]:
             _LOGGER.error("Problem issuing command: %s", response["msg"])
             raise UnknownError
 

setup.py

@@ -5,7 +5,7 @@
 
 PROJECT_DIR = Path(__file__).parent.resolve()
 README_FILE = PROJECT_DIR / "README.md"
-VERSION = "0.1.41"
+VERSION = "0.1.42"
 
 setup(
     name="python-openevse-http",

tests/test_main.py

@@ -9,11 +9,12 @@
 from aiohttp.client_exceptions import ContentTypeError, ServerTimeoutError
 
 import openevsehttp.__main__ as main
+from openevsehttp.exceptions import MissingSerial, UnknownError, UnsupportedFeature
 from tests.common import load_fixture
-from openevsehttp.exceptions import MissingSerial, UnsupportedFeature
 
 pytestmark = pytest.mark.asyncio
 
+TEST_URL_STATUS = "http://openevse.test.tld/status"
 TEST_URL_RAPI = "http://openevse.test.tld/r"
 TEST_URL_OVERRIDE = "http://openevse.test.tld/override"
 TEST_URL_CONFIG = "http://openevse.test.tld/config"
@@ -1203,3 +1204,55 @@ async def test_version_check(test_charger_new, mock_aioclient, caplog):
 
     result = test_charger_new._version_check("4.0.0", "4.1.7")
     assert not result
+
+
+async def test_set_charge_mode(test_charger, mock_aioclient, caplog):
+    """Test v4 Status reply."""
+    await test_charger.update()
+    value = {"msg": "done"}
+    mock_aioclient.post(
+        TEST_URL_CONFIG,
+        status=200,
+        body=json.dumps(value),
+    )
+    with caplog.at_level(logging.DEBUG):
+        await test_charger.set_charge_mode("eco")
+
+    mock_aioclient.get(
+        TEST_URL_STATUS,
+        status=200,
+        body=load_fixture("v4_json/status.json"),
+    )
+    mock_aioclient.get(
+        TEST_URL_CONFIG,
+        status=200,
+        body=load_fixture("v4_json/config.json"),
+    )
+    value = {"config_version": 2, "msg": "done"}
+    mock_aioclient.post(
+        TEST_URL_CONFIG,
+        status=200,
+        body=json.dumps(value),
+    )
+    with caplog.at_level(logging.DEBUG):
+        await test_charger.set_charge_mode("fast")
+
+    value = {"msg": "error"}
+    mock_aioclient.post(
+        TEST_URL_CONFIG,
+        status=200,
+        body=json.dumps(value),
+    )
+    with caplog.at_level(logging.DEBUG):
+        with pytest.raises(UnknownError):
+            await test_charger.set_charge_mode("fast")
+            assert "Problem issuing command: error" in caplog.text
+
+    value = {"msg": "done"}
+    mock_aioclient.post(
+        TEST_URL_CONFIG,
+        status=200,
+        body=json.dumps(value),
+    )
+    with pytest.raises(ValueError):
+        await test_charger.set_charge_mode("test")