refactor: Plugin + Session builder API updated from bones refactor (#1049)

Update plugins for builder pattern, from changes in bones:
fishfolk/bones#489

Author: MaxCWhitehead

Cargo.lock

@@ -7,12 +7,16 @@ pub use music::*;
 pub fn game_plugin(game: &mut Game) {
     game.init_shared_resource::<AudioCenter>();
 
-    let session = match game.sessions.get_mut(SessionNames::AUDIO) {
-        Some(session) => session,
-        None => panic!("Audio plugin failed to find existing bones audio session, make sure jumpy audio plugin is installed after bones default plugins.")
-    };
+    let modified_session = game.sessions.modify_and_replace_existing_session(
+        SessionNames::AUDIO,
+        |session: &mut SessionBuilder| {
+            session.stages().add_system_to_stage(First, music_system);
+        },
+    );
 
-    session.stages.add_system_to_stage(First, music_system);
+    if modified_session.is_none() {
+        panic!("Audio plugin failed to find existing bones audio session, make sure jumpy audio plugin is installed after bones default plugins.")
+    }
 }
 
 /// Extension of bones [`AudioCenter`].

src/audio.rs

@@ -72,7 +72,7 @@ pub struct MatchPlayerInfo {
 }
 
 impl SessionPlugin for MatchPlugin {
-    fn install(self, session: &mut Session) {
+    fn install(self, session: &mut SessionBuilder) {
         session
             .install_plugin(DefaultSessionPlugin)
             .install_plugin(LuaPluginLoaderSessionPlugin(self.plugins));
@@ -94,7 +94,7 @@ impl SessionPlugin for MatchPlugin {
         scoring::session_plugin(session);
 
         let current_map = self.maps.current_map;
-        session.world.insert_resource(self.maps);
+        session.insert_resource(self.maps);
 
         // Initialize LoadedMap on startup as we cannot access AssetServer during MatchPlugin install
         // to get map meta.
@@ -105,11 +105,11 @@ impl SessionPlugin for MatchPlugin {
             },
         );
 
-        session.world.insert_resource(MatchInputs {
+        session.insert_resource(MatchInputs {
             players: self.player_info,
         });
-        session.world.insert_resource(self.score);
-        session.runner = self.session_runner;
+        session.insert_resource(self.score);
+        session.set_session_runner(self.session_runner);
     }
 }
 

src/core.rs

@@ -7,9 +7,8 @@
 //! sure that, for example, a held item will bob up and down with the player.
 use crate::prelude::*;
 
-pub fn install(session: &mut Session) {
+pub fn install(session: &mut SessionBuilder) {
     session
-        .stages
         .add_system_to_stage(CoreStage::Last, update_player_body_attachments)
         .add_system_to_stage(CoreStage::Last, remove_player_body_attachments)
         .add_system_to_stage(CoreStage::Last, update_attachments);

src/core/attachment.rs

@@ -10,7 +10,7 @@ pub fn game_plugin(game: &mut Game) {
 }
 
 /// Install this module.
-pub fn session_plugin(session: &mut Session) {
+pub fn session_plugin(session: &mut SessionBuilder) {
     Bullet::register_schema();
     BulletHandle::register_schema();
 

src/core/bullet.rs

@@ -3,7 +3,7 @@
 use crate::prelude::*;
 
 /// Install this module.
-pub fn install(session: &mut Session) {
+pub fn install(session: &mut SessionBuilder) {
     session
         .stages
         .add_system_to_stage(CoreStage::Last, camera_controller);

src/core/camera.rs

@@ -7,13 +7,11 @@ use crate::prelude::*;
 use super::utils::Rect;
 
 /// Install this module.
-pub fn install(session: &mut Session) {
+pub fn install(session: &mut SessionBuilder) {
     DamageRegion::register_schema();
     DamageRegionOwner::register_schema();
 
-    session
-        .stages
-        .add_system_to_stage(CoreStage::PostUpdate, kill_players_in_damage_region);
+    session.add_system_to_stage(CoreStage::PostUpdate, kill_players_in_damage_region);
 }
 
 /// A rectangular damage region.

src/core/damage.rs

@@ -4,7 +4,7 @@ use crate::prelude::*;
 use rapier2d::prelude as rapier;
 
 /// Install this module.
-pub fn plugin(session: &mut Session) {
+pub fn plugin(session: &mut SessionBuilder) {
     session
         .stages
         .add_system_to_stage(CoreStage::Last, debug_render_colliders)

src/core/debug.rs

@@ -6,7 +6,7 @@ use crate::core::map_constructor::{shiftnanigans::ShiftnanigansMapConstructor, M
 use crate::prelude::*;
 
 /// Install this module.
-pub fn install(session: &mut Session) {
+pub fn install(session: &mut SessionBuilder) {
     session
         .stages
         .add_system_to_stage(CoreStage::PreUpdate, handle_editor_input);

src/core/editor.rs

@@ -284,7 +284,7 @@ impl<'a> SpawnerManager<'a> {
 /// Helper macro to install element game and session plugins
 macro_rules! install_plugins {
     ($($module:ident),* $(,)?) => {
-        pub fn session_plugin(session: &mut Session) {
+        pub fn session_plugin(session: &mut SessionBuilder) {
             ElementHandle::register_schema();
             MapElementHydrated::register_schema();
             DehydrateOutOfBounds::register_schema();