Address Copilot review comments

- type lexer results explicitly in validateBundle
- surface smoke-build failures as validation violations
- clamp bundle budget at zero for tiny upload limits
- fix package description typo and add license field

Author: Gawor270

packages/composition-cli/package.json

@@ -1,7 +1,8 @@
 {
   "name": "@fishjam-cloud/composition-cli",
   "version": "0.29.0-rc.2",
-  "description": "Utilites to build, validate composition React code",
+  "description": "CLI for scaffolding and building Fishjam composition templates",
+  "license": "Apache-2.0",
   "homepage": "https://github.com/fishjam-cloud/js-server-sdk",
   "author": "Fishjam Team",
   "repository": {

packages/composition-cli/src/build.ts

@@ -47,7 +47,7 @@ export async function buildTemplate(entry: string, outfile: string, manifest: Ma
   const violations = await validateBundle(bundle.text, manifest);
 
   const bytes = bundle.contents.byteLength;
-  const maxBundleBytes = manifest.maxUploadBytes - UPLOAD_OVERHEAD_RESERVE_BYTES;
+  const maxBundleBytes = Math.max(0, manifest.maxUploadBytes - UPLOAD_OVERHEAD_RESERVE_BYTES);
   if (bytes > maxBundleBytes) {
     violations.push(
       `bundle is ${bytes} bytes; the upload limit is ${manifest.maxUploadBytes} bytes and ${UPLOAD_OVERHEAD_RESERVE_BYTES} bytes are reserved for registration config and multipart overhead, so bundles must stay under ${maxBundleBytes} bytes`

packages/composition-cli/src/smoke.ts

@@ -8,28 +8,34 @@ export async function smokeLoadBundle(source: string, manifest: Manifest): Promi
   const escaped = manifest.allowedImports.map((spec) => spec.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'));
   const allowedFilter = new RegExp(`^(${escaped.join('|')})$`);
 
-  const result = await build({
-    stdin: { contents: source, loader: 'js' },
-    bundle: true,
-    write: false,
-    format: 'esm',
-    logLevel: 'silent',
-    plugins: [
-      {
-        name: 'stub-allowed-imports',
-        setup(builder) {
-          builder.onResolve({ filter: allowedFilter }, (args) => ({
-            path: args.path,
-            namespace: 'stub',
-          }));
-          builder.onLoad({ filter: /.*/, namespace: 'stub' }, () => ({
-            contents: stubModule,
-            loader: 'js',
-          }));
+  let result;
+  try {
+    result = await build({
+      stdin: { contents: source, loader: 'js' },
+      bundle: true,
+      write: false,
+      format: 'esm',
+      logLevel: 'silent',
+      plugins: [
+        {
+          name: 'stub-allowed-imports',
+          setup(builder) {
+            builder.onResolve({ filter: allowedFilter }, (args) => ({
+              path: args.path,
+              namespace: 'stub',
+            }));
+            builder.onLoad({ filter: /.*/, namespace: 'stub' }, () => ({
+              contents: stubModule,
+              loader: 'js',
+            }));
+          },
         },
-      },
-    ],
-  });
+      ],
+    });
+  } catch (err) {
+    const message = err instanceof Error ? err.message : String(err);
+    return [`bundle could not be prepared for loading: ${message}`];
+  }
 
   const encoded = Buffer.from(result.outputFiles[0].contents).toString('base64');
   let mod: { default?: unknown };

packages/composition-cli/src/validate.ts

@@ -1,11 +1,11 @@
-import { init, parse } from 'es-module-lexer';
+import { type ExportSpecifier, type ImportSpecifier, init, parse } from 'es-module-lexer';
 import type { Manifest } from './manifests';
 
 export async function validateBundle(source: string, manifest: Manifest): Promise<string[]> {
   await init;
 
-  let imports;
-  let exports;
+  let imports: readonly ImportSpecifier[];
+  let exports: readonly ExportSpecifier[];
   try {
     [imports, exports] = parse(source);
   } catch {