This repository was archived by the owner on Feb 10, 2026. It is now read-only.
Commit 5fd2622
authored
## Description
While taking a shower tonight, it struck me that in this PR
#474 I actually
introduced a bug. The `joinRoom` promise should be rejected, instead of
just returning the function.
## Motivation and Context
There was a bug that might lead to errors (unresolved promise).
## How has this been tested?
android + iOS
## Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to
not work as expected)
## Checklist:
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
## Screenshots (if appropriate)
1 parent 967069a commit 5fd2622
2 files changed
Lines changed: 2 additions & 2 deletions
File tree
- packages/react-native-client
- android/src/main/java/io/fishjam/reactnative
- ios
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
299 | 299 | | |
300 | 300 | | |
301 | 301 | | |
302 | | - | |
| 302 | + | |
303 | 303 | | |
304 | 304 | | |
305 | 305 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
225 | 225 | | |
226 | 226 | | |
227 | 227 | | |
228 | | - | |
| 228 | + | |
229 | 229 | | |
230 | 230 | | |
231 | 231 | | |
| |||
0 commit comments