This repository was archived by the owner on Feb 10, 2026. It is now read-only.
Commit a5cfe3f
authored
feat: add option to configure display name of ios screen broadcast extension (#527)
## Description
This PR adds the option to configure the display name of the extension.
This display name is shown in the native pop-up after starting to share
the screen.
## Motivation and Context
Currently, our app shows `FishjamScreenBroadcast` in the native popup,
which can be confusing for our users, as they have no idea what Fishjam
is.
## Documentation impact
I am not sure about this. I didn't find any related documentation to
update. Similar to tests, I have tested it in the
`internal/fishjam-chat` by running prebuild and checking the
`Info.plist` file manually.
- [ ] Documentation update required
- [ ] Documentation updated [in another PR](_)
- [ ] No documentation update required
## Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to
not work as expected)1 parent 662ef7a commit a5cfe3f
4 files changed
Lines changed: 16 additions & 2 deletions
File tree
- internal/fishjam-chat
- packages/react-native-client/plugin
- broadcastExtensionFiles
- src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
| 72 | + | |
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
20 | 24 | | |
21 | 25 | | |
22 | 26 | | |
| |||
26 | 30 | | |
27 | 31 | | |
28 | 32 | | |
| 33 | + | |
29 | 34 | | |
30 | 35 | | |
31 | 36 | | |
| |||
249 | 254 | | |
250 | 255 | | |
251 | 256 | | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
252 | 264 | | |
253 | 265 | | |
254 | 266 | | |
| |||
0 commit comments